From Christian Packard to ~technomancy/fennel
Your docs are very well written, this case was just general ambiguities of English and myself reading them very literally :) I think if there was another clause in the last sentence like “Note, this variable must be a string, but there’s no need to include quotes in the variable itself.”, that would make the distinction clear. -- Christian > On Aug 24, 2023, at 2:58 PM, Andrey <andreyorst@gmail.com> wrote: > >> Ah that makes sense, no worries and thanks for clarifying. > > Maybe you can suggest a better wording? English isn't my first language, and I'm not all that familiar with customize docs > > --
From Christian Packard to ~technomancy/fennel
Ah that makes sense, no worries and thanks for clarifying. > On Aug 24, 2023, at 12:34, Andrey <andreyorst@gmail.com> wrote: > > >> >> One small note to share: in the docstring of >> `fennel-proto-repl-fennel-module-name` it says that there’s no need >> to include quotes in module name, but I found that I did need quotes. >> For example: >> >> ┌──── >> │ ((fennel-mode . ((fennel-proto-repl-fennel-module-name . lib\.fennel)))) >> └────
From Christian Packard to ~technomancy/fennel
Andrey Listopadov <andreyorst@gmail.com> writes: > Christian Packard <christian@cpacklabs.com> writes: > >> I can see the benefits of a standard solution. Armed with the knowledge >> above I’d be fine using the configured path and discarding this patch. >> >> What originally prompted me to submit it is that there wasn’t an indication >> that the misconfigured path was the issue. Even when setting >> `fennel-proto-repl-log-communication` to `t` and >> `fennel-proto-repl-kill-process-buffers` to `nil` the only message I had was >> `fennel-proto-repl–start-server: Unable to initialize Fennel Proto REPL: timeout`; >> no other debug info or buffers were available. >>
From Christian Packard to ~technomancy/fennel
> You can work around this issue by just ensuring that it's available > under both names: > > package.loaded.fennel = package.loaded["lib.fennel"] Sure enough I added this to my `main.lua` and proto-repl works again with the default `:fennel` name. Thank you for the example! >> However, I still don't think that this should be solved this way - an >> appropriate fennel-path should be configured when starting the REPL. I can see the benefits of a standard solution. Armed with the knowledge above I’d be fine using the configured path and discarding this patch.
From Christian Packard to ~technomancy/fennel
Hi Andrey, Yes that’s exactly the issue I was running into. Can you explain how fennel-path can be configured when starting the REPL? If there’s a better way to solve this I’m happy to test it out, I just couldn’t find any mention of it in the docs. -- Christian Packard > On Aug 21, 2023, at 2:18 AM, Andrey Listopadov <andreyorst@gmail.com> wrote: > > >> What exactly is the issue you're trying to solve here? > > Re-reading the patch, I think I now see the problem, that the Fennel can > be unavailable by just requiring :fennel, and indeed you'll need to
From to ~technomancy/fennel
From: Christian Packard <christian@cpacklabs.com> Add a var `fennel-proto-repl-lib-module` which allows users to customize the location of the `fennel` library module. This allows projects such as min-love2d-fennel to work with the Proto REPL, where the `fennel` command is in a non-top-level location like the `lib` folder. --- README.md | 29 +++++++++++++ fennel-proto-repl.el | 98 ++++++++++++++++++++++++++------------------ 2 files changed, 86 insertions(+), 41 deletions(-) diff --git a/README.md b/README.md index a49932a..6e13e2c 100644 [message trimmed]