Oregon, US
From Clayton Craft to ~postmarketos/pmbootstrap-devel
On Sun, 13 Aug 2023 00:41:40 +0100 Caleb Connolly <kc@postmarketos.org> wrote: > Add a new "auto_checksum" config option which, when set, will make > pmbootstrap fix checksums for local sources in-place before building a > package. > > This _drastically_ speeds up development when working with files that > are local to pmaports. > > It isn't done automatically for remote sources as there is still some > value in having these error out (e.g. catching corrupt downloads). > Additionally, those sources shouldn't change regularly (if you're doing > local development like this, please use "pmbootstrap build --src"!) > > Enable this option by default, it doesn't introduce any additional risk.
From Clayton Craft to ~postmarketos/pmbootstrap-devel
On Wed, 02 Aug 2023 19:21:51 +0200 Oliver Smith <ollieparanoid@postmarketos.org> wrote: > Modernize default values and tweak the hidden UIs message one sees after > creating a new port. > > Oliver Smith (2): > pmb.aportgen.device: modernize defaults > init: tweak UIs hidden message > > pmb/aportgen/device.py | 4 ++-- > pmb/config/init.py | 8 +++----- > 2 files changed, 5 insertions(+), 7 deletions(-) > > -- > 2.41.0
From Clayton Craft to ~postmarketos/pmbootstrap-devel
On Thu, 20 Jul 2023 18:47:03 +0200 Pablo Correa Gómez <pabloyoyoista@postmarketos.org> wrote: > From: Pablo Correa Gómez <ablocorrea@hotmail.com> > > So deviceinfo_modules_initfs is going to be phased out in pmaports!4169 as > a preparation for pmaports#1836. The implementation for the alternative of > using a modules file has already been merged in pmaports!4193, so stop > promoting the soon-to-be-phased-out deviceinfo variable, and instead use > the new and already-supported alternative. > > Relates https://gitlab.com/postmarketOS/pmaports/-/issues/1836 > > Relates https://gitlab.com/postmarketOS/pmaports/-/merge_requests/4169 > > Relates https://gitlab.com/postmarketOS/pmaports/-/merge_requests/4193
From Clayton Craft to ~postmarketos/pmbootstrap-devel
On Thu, 13 Jul 2023 20:19:48 +0200 Oliver Smith <ollieparanoid@postmarketos.org> wrote: > Fix that the list "cmd" was turned into a string if one of the proxy > vars was set in the environment. Add a test for this code path. Before > this patch: > > $ FTP_PROXY=test pmbootstrap -v --details-to-stdout status > … > % cd /home/user/.local/var/pmbootstrap/cache_git/pmaports; git remote -v > run: FTP_PROXY=test ['git', 'remote', '-v'] > ERROR: [Errno 2] No such file or directory: "FTP_PROXY=test ['git', 'remote', '-v']" > > Fixes: 1a00c04f ("pmb.helpers.run_core: always configure proxy vars if set in environment") Thank you for fixing this!
From Clayton Craft to ~postmarketos/pmbootstrap-devel
This is now handled in helpers.run_core.core. --- pmb/chroot/root.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/pmb/chroot/root.py b/pmb/chroot/root.py index 4e5fc586..d1e70013 100644 --- a/pmb/chroot/root.py +++ b/pmb/chroot/root.py @@ -65,12 +65,6 @@ def root(args, cmd, suffix="native", working_dir="/", output="log", for key, value in env.items(): env_all[key] = value # Preserve proxy environment variables[message trimmed]
From Clayton Craft to ~postmarketos/pmbootstrap-devel
By configuring proxy vars in run_core.core, we can ensure that the environment is always aware of any configured proxy, whether it's running natively or in a chroot. fixes https://gitlab.com/postmarketOS/pmbootstrap/-/issues/2249 --- pmb/helpers/run_core.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pmb/helpers/run_core.py b/pmb/helpers/run_core.py index 10b22020..c7412948 100644 --- a/pmb/helpers/run_core.py +++ b/pmb/helpers/run_core.py [message trimmed]
From Clayton Craft to ~postmarketos/pmbootstrap-devel
In V2, I just moved the code preserving the proxy environment into helpers.run_core.core, this way we can always be sure that the proxy env config is preserved any time a command is executed anywhere in the code base. Clayton Craft (2): pmb.helpers.run_core: always configure proxy vars if set in environment pmb.chroot.root: don't include proxy env variables pmb/chroot/root.py | 6 ------ pmb/helpers/run_core.py | 7 +++++++ 2 files changed, 7 insertions(+), 6 deletions(-)
From Clayton Craft to ~postmarketos/pmbootstrap-devel
Thanks for the patch! Could you please explain what this does exactly, the motivations for it, and why you went with this approach? On Wed, 12 Jul 2023 19:19:32 +0000 JustSoup321 <brandonboese@protonmail.com> wrote: > --- > pmb/flasher/init.py | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/pmb/flasher/init.py b/pmb/flasher/init.py > index aff7808d..3569bcce 100644 > --- a/pmb/flasher/init.py > +++ b/pmb/flasher/init.py > @@ -32,6 +32,10 @@ def install_depends(args):
From Clayton Craft to ~postmarketos/pmbootstrap-devel
On Wed, 12 Jul 2023 19:24:27 +0100 Caleb Connolly <kc@postmarketos.org> wrote: > Some packages have cyclical dependencies and benefit from having a > separate bootstrap variant, make this process easier by automatically > setting up an environment similar to what's used in the openssh alpine > package. > > Support the APKBUILD variable "depends_nonbootstrap" which is used to > specify dependencies which aren't used when bootstrapping, allowing > pmbootstrap to remove them from the dependencies list. Where is `depends_bootstrap` documented? I didn't see it in the APKBUILD reference: https://wiki.alpinelinux.org/wiki/APKBUILD_Reference Or is this introducing a new variable (like pmb_recommends) ?
From Clayton Craft to ~postmarketos/pmbootstrap-devel
On Tue, 04 Jul 2023 17:37:00 +0200 Luca Weiss <luca@z3ntu.xyz> wrote: > On Dienstag, 4. Juli 2023 00:33:59 CEST Clayton Craft wrote: > > pmb is already preserving proxy vars if it runs things in a chroot, but > > this handles other situations where it is running things outside of the > > chroot (e.g. apk.static.) > > Makes sense I guess. > > > > > (partially) fixes https://gitlab.com/postmarketOS/pmbootstrap/-/issues/2249 > > Do we know what else would be missing for this to be fully resolved? Yes, the other piece for this user was that they had set the proxy url to a