[PATCH] passlist: show the gpg dialog in a separate thread

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH] passlist: show the gpg dialog in a separate thread

Paper <paper@tilde.institute>

Details

Message ID: <20210302174500.23257-1-paper@tilde.institute>
DKIM signature: missing

Download raw message

3 years ago

Patch: +2 -1

* fixes "Application not responding" warning message on GNOME
---
 caerbannog/passlist.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/caerbannog/passlist.py b/caerbannog/passlist.py
index 651960f..a908366 100644
--- a/caerbannog/passlist.py
+++ b/caerbannog/passlist.py
@@ -5,6 +5,7 @@ import fuzzyfinder
 import gc
 import gi
 import importlib
+import threading
 import os
 from .logger import Logger
 gi.require_version('Gdk', '3.0')
@@ -172,7 +173,7 @@ class PassList(Gtk.ListBox):
         # order of this conditional is important, since PassItem is derived
         # from PassSection
         if isinstance(node, PassItem):
-            self._copy_pass(node)
+            threading.Thread(target=self._copy_pass, args=(node,)).start()
         elif isinstance(node, PassSection):
             # populate listbox with selected subsection
             self._tree_cur = node
-- 
2.30.1

clayton craft <clayton@craftyguy.net>

Details

Message ID: <C9P7MYKIH4A4.3PXN2CVXBQ0LD@thinkpad>
In-Reply-To: <20210302174500.23257-1-paper@tilde.institute> (view parent)
DKIM signature: missing

Download raw message

3 years ago

Thanks, but I think I'm going to go with the patch I posted yesterday, since it
limits what runs in a separate thread (even if it's not as succinct as your
patch here). What do you think?

~craftyguy/caerbannog-devel

[PATCH] passlist: show the gpg dialog in a separate thread