FWIW, I found the gray background to be a bit boring. Trying out yellow now, too :)

Personally, I'm not opposed to the yellow foreground. I wouldn't mind if kept the default foreground color either, though :)

Not sure about the lack of contrast in #efefef (thanks for the quick elisp to change the org-checkbox face):

(set-face-attribute 'org-checkbox nil :foreground nil :background "#efefef")

For what it's worth, I was considering to add a background style to the
three characters, too, so they stand out in union a bit more. Was
thinking about a light gray, like #efefef.

Button-like styling sounds like a bit too invasive for a theme IMHO.

-- Christian

I received a comment the other day:

> I want to do the opposite, even enabling hl-line-mode in dired-mode, I
> want to make hl-line have a lower priority than dired-marked. But
> setting a smaller number than -50 seems not work.
> https://christiantietze.de/posts/2022/03/hl-line-priority/#fast-comments-jt=VyQDBtmKE1e

While I personally never noticed that, even though I have been nerd-sniped
a bit, I couldn't figure out how to prioritize the marked color. Funnily
enough, all-the-icons's icons's  bg color works :) See screenshot.

My non-matching personal preference for colors aside, macOS is, if nothing else, rich in contrast when it comes to search result overlays: the current search result is popped to the foreground with black-on-yellow text in light mode, and the rest is toned-down. Other matches retain their default colors, so black-on-white (or whichever color the text had before). So essentially everything becomes black on gray, except for matches.

Time to backpedal! It's not lin's fault at all :)

I used this to make lin's colors win over other mode's faces. Was a
quick fix I added a while ago and forgot about.

    ;; From -50 to +50 to override other faces, e.g. neotree links
    (setq hl-line-overlay-priority +50)

Removing that (or reverting to -50) fixes all my problems. (Or at least
those I reported here.)

Cheers!
Christian

Yes, that makes sense now -- I cannot enable a mode to highlight
lines in a way that suggests per-line selection, and then break with the
expectation by moving the point sideways with a region :)

So hl-line-mode it is. Will test-drive that for a while. Thanks!

-- Christian

Hi,

With these settings, I have per-line highlight in dired with lin, but when I select the file name, the region's color isn't visible. That's a problem to copy parts of a file name or file sizes:

- `modus-themes-region` is '(accented)
- `lin-face` is 'lin-mac-override-fg, for white text on blue line highlight

Would I have to disable `lin-mode` in dired, or is it possible to add a quick fix to faces for this combo in my config?

Thanks!
Christian

-- 
Sent from Bielefeld, Germany <3

Hi Prot and the List,

I noticed in a screenshot of a mode-line with a lighter gray background
that this allows colors in the mode-line to pop more.[1] Wanted to share
that finding with you.

[1]: https://github.com/jojojames/fussy/blob/main/screenshots/fussy.png

The mode-line-inactive face has almost the same Hex value (#ebebeb,
where the picture has #efefef). I'm experimenting with making that even
lighter, the lunatic that I am, using just #ffffff.

The most straight-forward way I found so far is to, well, experiment and
override the mode line faces:

FWIW, I have similar functions and overrides that use the
`modus-themes-after-load-theme-hook'. It's not that bad in sum.

-- Christian