~dachary

Recent activity

Re: go-ap is now a dependency of Gitea 7 months ago

From Loïc Dachary to ~mariusor/activitypub-go


On 21/06/2022 08:56, Marius Orcsik wrote:
> On 22-06-20 15:58:11, Loïc Dachary wrote:
>> For the record, as of yesterday[0] go-ap is a dependency of Gitea for the purpose of implementing federation with ActivityPub.
> 
> Hi Loïc,
> 
> If I'll have any changes to the libraries that might impact Gitea, how
> should I announce them? Usually I just send an email here, but probably
> I can open a ticket on github for you guys.

I don't have a GitHub account so I won't see it. But most Gitea communication goes through GitHub so it would make sense.

go-ap is now a dependency of Gitea 7 months ago

From Loïc Dachary to ~mariusor/activitypub-go

Bonjour,

For the record, as of yesterday[0] go-ap is a dependency of Gitea for the purpose of implementing federation with ActivityPub. It is in the development branch that will be released some time at the end of 2022 as Gitea 1.18. The work continues and the best way to follow it is to subscribe to the corresponding task list[1].

Cheers

[0] https://github.com/go-gitea/gitea/pull/19133
[1] https://gitea.com/Ta180m/gitea/issues/3
-- 
Loïc Dachary, Artisan Logiciel Libre

Re: [PATCH] Adding Repository MarshalJSON and UnmarshalJSON methods 7 months ago

From Loïc Dachary to ~mariusor/activitypub-go

Hi,

Side note, too early at this stage I realize but that crossed my mind :-) The forgefed specs at https://forgefed.org/modeling.html#repository have not yet been updated with the latest changes, which include `cloneUri` https://codeberg.org/ForgeFed/ForgeFed/src/branch/master/spec/modeling.md#repository

My 2cts

On 16/06/2022 23:40, Anthony Wang wrote:
> ------- Original Message -------
> On Thursday, June 16th, 2022 at 12:03, Anthony Wang <ta180m@proton.me> wrote:
> 
> 
>> I agree that exporting some of the writeJSON functions would be beneficial, since most of this patch seems to be duplicating work that's already in go-ap/activitypub.
> 
> 

Re: forgefriends monthly update & go-ap 8 months ago

From Loïc Dachary to ~mariusor/activitypub-go


On 20/05/2022 07:25, Marius Orcsik wrote:
> On 22-05-19 06:41:12, Loïc Dachary wrote:
>>
>> A short note to let you know today May 19th 7pm UTC+2 is the https://forgefriends.org monthly update
> 
> Thank you very much for the invite Loïc, yesterday was a busy day and I
> only saw the email just now in the morning.
> 
> Were there any meaningful conclusions reached?

Most of the meeting was about go-ap (the recording is available[0]). The short version of it is: let's give it a try. Anthony is motivated to rework a pull request he has to use go-ap. And I'm motivated to assist him.

forgefriends monthly update & go-ap 8 months ago

From Loïc Dachary to ~mariusor/activitypub-go

Bonjour,

A short note to let you know today May 19th 7pm UTC+2 is the https://forgefriends.org monthly update[0]. There will be discussions regarding go-ap and how it could be used to implement ActivityPub in Gitea. The videoconference is open to everyone[1] and will be recorded for people who cannot attend.

Cheers

[0] https://forum.forgefriends.org/t/forgefriends-monthly-update-may-19h-2022-7pm-8pm-utc-2/697
[1] https://meet.jit.si/ForgeFriendsCommunityMeetup

-- 
Loïc Dachary, Artisan Logiciel Libre

Re: [PATCH] s/pacakges/packages/ 8 months ago

From Loïc Dachary to ~mariusor/activitypub-go

Is this the right list to send patches to the wiki?

On 12/05/2022 13:38, Marius Orcsik wrote:
> Thanx, applied and pushed.
> 
> /Marius

-- 
Loïc Dachary, Artisan Logiciel Libre

Re: Gitea & go-ap 8 months ago

From Loïc Dachary to ~mariusor/activitypub-go

This is enlightening and will save code reading time to other Gitea developers.

As a long time C developer I'm not shocked by how unsafe imposes a requirement on the types describing the vocabulary: struct member alignment is not my favorite activity but it is occasionally useful. And imposing this same requirement when adding new types which will be necessary for forgefed also sounds reasonable.

But I've never used unsafe and I may be ignorant of the reasons why this might be not be such a good idea. The first thing that comes to mind is that relying on the undocumented (is it undocumented really?) internal layout of the type could mean that in a future release of Go the assumptions you made do not hold true and the entire construct collapses? Or am I seeing monsters where there are none?

On 12/05/2022 08:25, Marius Orcsik wrote:
> Hi again Loïc,
> 
> If you don't mind, instead of answering your questions one by one I'll
> try to offer a broad picture description of how I made the design
> decisions that went into the go-ap/activitypub package:
> 
> The main problem of implementing the ActivityPub spec in Go, stems from

[PATCH] s/pacakges/packages/ 8 months ago

From Loic Dachary to ~mariusor/activitypub-go

From: Loïc Dachary <loic@dachary.org>

Signed-off-by: Loïc Dachary <loic@dachary.org>
---
 index.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/index.md b/index.md
index 1c1c1a9..66ba43c 100644
--- a/index.md
+++ b/index.md
@@ -5,7 +5,7 @@ The projects that fall under this umbrella are:

* The [FedBOX](https://github.com/go-ap/fedbox) generic ActivityPub service project. [Wiki](./fedbox/index.md).
[message trimmed]

Re: Gitea & go-ap 8 months ago

From Loïc Dachary to ~mariusor/activitypub-go

So, back in 2019 you started the ToObject function which is the base of a dynamic hierarchy of types (Actor, Activity, etc.)

https://github.com/go-ap/activitypub/blob/master/object.go#L442-L506

which is further derived, for instance for Activity into IntransitiveActivity, Question

https://github.com/go-ap/activitypub/blob/master/activity.go#L736-L760

so you effectively hand crafted a kind of object class hierarchy that bypasses Go strong typing. This is all based on https://pkg.go.dev/unsafe which looks scary at first glance. But I assume it is kind of ok since everything is done within the go-ap package in a tightly controlled environment. And not exposed to the caller of the library.

Am I getting close? Or did I deeply misunderstand something?


On 11/05/2022 22:06, Loïc Dachary wrote:

Re: Gitea & go-ap 8 months ago

From Loïc Dachary to ~mariusor/activitypub-go

I see you've been using generics for go-ap even before 1.18 was released, back in November 2021.

https://github.com/go-ap/activitypub/blob/master/object.go#L136-L142

I'm yet to figure out how unsafe is used. Interesting mix of reflect/unsafe/generics: great source of inspiration.

On 11/05/2022 21:53, Loïc Dachary wrote:
> Bonjour,
> 
> This is a followup discussion of the topic started on mastodon at https://mastodon.social/@humanetech/108284656261295851
> 
> To be continued!
>