~damiencassou

Recent activity

Re: Adding support for embark-act to tmr-tabulated a month ago

From Damien Cassou to ~protesilaos/tmr

Hi Daniel,

Daniel Mendler <mail@daniel-mendler.de> writes:
> I assume that you observe an unfortunate interaction of
> tmr--read-timer-hook and the minibuffer injection. When acting in the
> tabulated mode buffer, the hook is used to read the timer at point, such
> that Embark doesn't even get a chance to inject the timer. Instead the
> timer is injection as description, which leads to the weird description.


this makes perfect sense, you are right.


> However there is no point in using Embark in the tabulated buffer, since

Adding support for embark-act to tmr-tabulated a month ago

From Damien Cassou to ~protesilaos/tmr

Hi,

I wanted to let the user get a list of tmr commands when calling
embark-act from a timer line in the tmr-tabulated view.

For this, I wrote this code:

    (defun my/tmr-tabulated-target-timer-at-point ()
      "Target the timer on the current line in a tmr-tabulated buffer."
      (when (derived-mode-p 'tmr-tabulated-mode)
        (when-let ((timer (tabulated-list-get-id)))
          `(
            tmr-timer
            ,(substring-no-properties (tmr--long-description timer))

Re: Feedback a month ago

From Damien Cassou to ~protesilaos/tmr

Daniel Mendler <mail@daniel-mendler.de> writes:
> My recommendation is to use default bindings <t> and an alist.

Thank you very much!

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Re: Feedback a month ago

From Damien Cassou to ~protesilaos/tmr

Protesilaos Stavrou <info@protesilaos.com> writes:
>> This will give us the best of both worlds. The history candidates will
>> be available for direct selection and you can also predefine some
>> default descriptions which will always appear at the top. What do you
>> think?
> Waiting for Damien on this.  I also mentioned a compromise in the
> previous email.

Please don't wait for me. Do whatever you want and I will happily try
and report if I'm missing a feature.

>> Learning positions by heart is not something I recommend for
>> completing-read anyway.
> […] I would still argue that it is some kind of abuse of the

Re: Feedback a month ago

From Damien Cassou to ~protesilaos/tmr

>>> [1] https://github.com/jwiegley/alert
>> Do we have a need for this?  It feels overkill.
> I prefer if tmr does not depend on alert. I don't use the alert package.


we don't. I was just mentioning an option. We should just remember that
the tmr notification system only works on Linux with dbus and a system
notification daemon. alert brings portability to other systems and users
can implement new back-ends based on their need.


> Generally I like if packages are loosely coupled and don't incur
> dependencies.

Re: Feedback a month ago

From Damien Cassou to ~protesilaos/tmr

> My Emacs is compiled without dbus. Maybe this is a bit odd, but I've
> not seen much benefits in adding this, since Emacs is often fullscreen
> anyway.


My Emacs is also fullscreen but I appreciate desktop notifications
anyway 😃.


>> I am not yet sure where to add it. Maybe it would be sufficient to add
>> it to these hook functions you've defined? Additionally we would need a
>> hook function tmr-timer-modified-functions.

[PATCH] denote--punctuation-regexp: Forbid usage of slash in filenames a month ago

From Damien Cassou to ~protesilaos/denote

---
 denote.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/denote.el b/denote.el
index 222af06..75b9bd9 100644
--- a/denote.el
+++ b/denote.el
@@ -227,7 +227,7 @@ (defconst denote--file-regexp
  (concat denote--file-title-regexp "\\([0-9A-Za-z_-]*\\)\\(\\.?.*\\)")
  "Regular expression to match the entire file name'.")

(defconst denote--punctuation-regexp "[][{}!@#$%^&*()_=+'\"?,.\|;:~`‘’“”]*"
(defconst denote--punctuation-regexp "[][{}!@#$%^&*()_=+'\"?,.\|;:~`‘’“”/]*"
[message trimmed]

Re: Incompatibility between hl-line-mode and hi-lock a month ago

From Damien Cassou to ~protesilaos/modus-themes

Protesilaos Stavrou <info@protesilaos.com> writes:
> Very well!  Just pushed the change.  Please keep an eye out for any
> possible weird results caused by how we use the ':inverse-video'.

I will, thank you very much.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Re: Incompatibility between hl-line-mode and hi-lock a month ago

From Damien Cassou to ~protesilaos/modus-themes

Protesilaos Stavrou <info@protesilaos.com> writes:
> Oh, okay then.  We cannot have an inverse foreground as that will get
> inverted back to the background.  So we need to always use colours
> from the themes' palette.  What do you think of the revised patch?  As
> far as I can tell, the foreground remains constant.

seems to work great for me. Thank you very much!

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Re: Incompatibility between hl-line-mode and hi-lock a month ago

From Damien Cassou to ~protesilaos/modus-themes

Hi Prot,

Protesilaos Stavrou <info@protesilaos.com> writes:
> Fair enough!  I conducted a major review.  What do you think about the
> attached patch?  Notice the comment about the use of inverse-video.

it seems to work in some buffers but not others (e.g., in js-mode and
Info-mode). See attached screenshot: the foreground is white on a yellow
background so I can't read the text.

-- 
Damien Cassou

"Success is the ability to go from one failure to another without