~delthas

~delthas/senpai-dev

Last active 3 months ago
View more

Recent activity

Re: [PATCH] Add an app store exception to the license 11 days ago

From delthas to ~emersion/goguma-dev

> Allow developers to distribute the app via the Apple app store.

> delthas, Jean, Noah, Pedro: since you own the copyright, can you reply
> with an ACK?

ACK.

-- 
delthas

[PATCH] service: reject commands with unexpected arguments 11 days ago

From delthas to ~emersion/soju-dev

This avoids issues where a user misstypes the following message:

     network update foobar enabled -false

This is obviously a typo of:

     network update foobar -enabled false

But we currently accept it without failing, and ignore the trailing
parameter "false".

This fixes this behavior by failing on unexpected arguments.
---
 service.go | 41 ++++++++++++++++++++++++++++++++++++-----
[message trimmed]

[PATCH v2] Fix regression in compact message formatting 22 days ago

From delthas to ~emersion/goguma-dev

A recent commit [1] broke mesage formatting in compact message mode.

Linkify was stripping all formatting, and the style was never passed
back before displaying it.

We can just wrap the TextSpan linkify returns in another TextSpan with
the current span style and with an only child that is the linkified
text span.

[1]: 6c7c51b029c9be8664c958279f632313bac5f193
---
 lib/page/buffer.dart | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
[message trimmed]

[PATCH] Fix regression in compact message formatting a month ago

From delthas to ~emersion/goguma-dev

A recent commit [1] broke mesage formatting in compact message mode.

Linkify was stripping all formatting, and the style was never passed
back before displaying it.

We cannot just rely on a DefaultStyle here because there are multiple
styles we want to apply, one per formatting span found in the IRC
message formatting.

Instead, this patch adds back the text style parameter to linkify, but
making it optional.

[1]: 6c7c51b029c9be8664c958279f632313bac5f193
---
[message trimmed]

[PATCH] page/buffer: Support link previews in compact mode a month ago

From delthas to ~emersion/goguma-dev

---
The display code is just copied over from the non compact view for now.

 lib/page/buffer.dart   | 30 +++++++++++++++++++++++++++---
 lib/page/settings.dart |  2 +-
 2 files changed, 28 insertions(+), 4 deletions(-)

diff --git a/lib/page/buffer.dart b/lib/page/buffer.dart
index 80641ed..58a548f 100644
--- a/lib/page/buffer.dart
+++ b/lib/page/buffer.dart
@@ -415,6 +415,7 @@ class _CompactMessageItem extends StatelessWidget {

	@override
[message trimmed]

[PATCH] Store only select TAGMSG types in message stores a month ago

From delthas to ~emersion/soju-dev

We only want to store TAGMSG that should be persistent. +typing TAGMSG
should be dropped, but +react messages should be kept.

This introduces a whitelist for TAGMSG labels. We only store TAGMSG
having a least one tag in that whitelist.
---
 upstream.go | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/upstream.go b/upstream.go
index 49e5a76..542d742 100644
--- a/upstream.go
+++ b/upstream.go
@@ -44,6 +44,12 @@ var permanentUpstreamCaps = map[string]bool{
[message trimmed]

[PATCH] Avoid sending push notifications for all channel context messages a month ago

From delthas to ~emersion/soju-dev

...Instead, send them only when their text content contains the user
nick, as if they were regular channel messages.
---
 upstream.go | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/upstream.go b/upstream.go
index 0b43fb8..49e5a76 100644
--- a/upstream.go
+++ b/upstream.go
@@ -593,14 +593,16 @@ func (uc *upstreamConn) handleMessage(ctx context.Context, msg *irc.Message) err
			break
		}

[message trimmed]

[PATCH v4] Support @+draft/channel-context a month ago

From delthas to ~emersion/goguma-dev

---
Addresses comments in v3 ;-)

 lib/client_controller.dart | 16 +++++++++++-----
 lib/push.dart              |  8 +++++++-
 2 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/lib/client_controller.dart b/lib/client_controller.dart
index 72f3e4c..1223b1a 100644
--- a/lib/client_controller.dart
+++ b/lib/client_controller.dart
@@ -576,7 +576,12 @@ class ClientController {
			// target can be my own nick for direct messages, "*" for server
			// messages, "$xxx" for server-wide broadcasts
[message trimmed]

[PATCH v2] Store bouncer network names locally a month ago

From delthas to ~emersion/goguma-dev

---
 lib/client_controller.dart |  6 ++++++
 lib/database.dart          | 13 +++++++++++--
 lib/models.dart            |  7 ++++++-
 3 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/lib/client_controller.dart b/lib/client_controller.dart
index 72f3e4c..9e82ed6 100644
--- a/lib/client_controller.dart
+++ b/lib/client_controller.dart
@@ -764,6 +764,12 @@ class ClientController {
			return;
		}

[message trimmed]

[PATCH] page/join: display the number of users per channel a month ago

From delthas to ~emersion/goguma-dev

Can be useful to identify which channel has the most users, eg when
looking for the official support channel of a project.
---
 lib/page/join.dart | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/lib/page/join.dart b/lib/page/join.dart
index d74c4c2..1d65b62 100644
--- a/lib/page/join.dart
+++ b/lib/page/join.dart
@@ -219,8 +219,19 @@ class _JoinItem extends StatelessWidget {
		);

		if (action is _JoinChannelAction) {
[message trimmed]