~delthas

~delthas/senpai-dev

Last active 3 months ago
View more

Recent activity

[PATCH gamja] Fix stripping hex color formatting 2 years ago

From delthas to ~emersion/public-inbox

Hex colors can be set with the same formats as the regular colors:
<CODE>, <CODE><COLOR>, or <CODE><COLOR>,<COLOR>.

Previously we only supporteed <CODE><COLOR>.

This patch enables stripping colors for all valid color formats.
---
 lib/ansi.js | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/lib/ansi.js b/lib/ansi.js
index 108af27..f4e81da 100644
--- a/lib/ansi.js
+++ b/lib/ansi.js
[message trimmed]

Re: [PATCH] check word boundary on highlight 2 years ago

From delthas to ~delthas/senpai-dev

Hi,

> This patch checks for a `\b` on either side of the highlight terms, so 
> as to
> only trigger a highlight if the word occurs by itself. This incurs the 
> added
> overhead of compiling a small regex, but it should be well worth the 
> trade-off.

Thanks for your patch!

During a previous CPU profiling of senpai, I had noticed that running a 
regex on every incoming message had a non trivial cost, especially on 
application startup.

Re: [PATCH senpai] Add a config option to beep on highlight 2 years ago

From delthas to ~taiite/public-inbox

Thanks!

Pushed with minor edits:
- use on-highlight-beep rather than beep
- disable this feature by default

To git.sr.ht:~taiite/senpai
    f13aa04..e8ed8e7  master -> master

Re: [PATCH] fix /msg command only sending first word 2 years ago

From delthas to ~delthas/senpai-dev

Thanks!

It's actually more of a bug in fieldsN which should properly return an 
array of size MaxArgs without splitting the last field.
I've pushed a fix that takes care of a bug, but by fixing fieldsN rather 
than the command.

To git.sr.ht:~taiite/senpai
    e740a6f..b3f64ae  master -> master

Re: [PATCH senpai] config: add user specified disabled-error list 2 years ago

From delthas to ~delthas/senpai-dev

> Allow users to specify additional disabled (blacklisted) errors via a
> config option. These will be added to the default list of disabled
> errors.

Nice patch. What's your use case? Which errors would you like to see 
blacklisted?

Re: [BUG] senpai: `panic: runtime error: slice bounds out of range` 2 years ago

From delthas to ~taiite/public-inbox

Hi,

> I cannot reproduce this issue, but it certainly exists (as the error
> message attests.) Hopefully it'll be helpful in finding the actual
> cause :)

Thanks for sending me a panic trace! I just pushed a fix.

To git.sr.ht:~taiite/senpai
    7a9fe74..1c5d730  master -> master

The issue was actually related to backsearch (Ctrl+R) and backspace, not 
to Ctrl+C.

Re: [PATCH v1 2/2] Use Unicode for better typography 2 years ago

From delthas to ~delthas/senpai-dev

Thanks for your patch! However, as a developer I like ASCII better in my 
README (normal dot-dot-dot and regular ASCII single quotes).

[PATCH avpn-extract v2] Fix coordinates order for maps.google links 2 years ago

From delthas to ~emersion/public-inbox

GeoJSON uses [lng, lat] order. Coincidentally this worked for
/maps/embed links because the extraction was inverted too.

This fixes maps.google links POIs being shown in the wrong location.
---
 main.go | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/main.go b/main.go
index 3666174..8f6e1e2 100644
--- a/main.go
+++ b/main.go
@@ -111,9 +111,9 @@ func fetchMember(pageURL string) (*geojsonFeature, error) {
		if len(l) <= 6 {
[message trimmed]

[PATCH avpn-extract] Fix coordinates order for maps.google links 2 years ago

From delthas to ~emersion/public-inbox

GeoJSON uses [lng, lat] order. Coincidentally this worked for
/maps/embed links because the extraction was inverted too.

This fixes maps.google links POIs being shown in the wrong location.
---
 main.go | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/main.go b/main.go
index 3666174..baff113 100644
--- a/main.go
+++ b/main.go
@@ -111,8 +111,8 @@ func fetchMember(pageURL string) (*geojsonFeature, error) {
		if len(l) <= 6 {
[message trimmed]

Re: [PATCH v1 2/2] make install an independant task in Makefile 2 years ago

From delthas to ~delthas/senpai-dev

Pushed, thanks!

To git.sr.ht:~taiite/senpai
    f963090..917f754  master -> master