Recent activity

Re: [PATCH 1/2] ui/app: (wayland) refactor code path to allow X11 fallback 4 days ago

From Denys Smirnov to ~eliasnaur/gio

On Tue, 17 Sep 2019 at 16:59, Elias Naur <mail@eliasnaur.com> wrote:
>
> On Tue Sep 17, 2019 at 3:57 PM Denys Smirnov wrote:
> > On Tue, 17 Sep 2019 at 12:21, Elias Naur <mail@eliasnaur.com> wrote:
> > >
> > >         diff --git a/ui/app/egl_wayland.go b/ui/app/egl_wayland.go
> > >         index d8fc4a5..4279b50 100644
> > >         --- a/ui/app/egl_wayland.go
> > >         +++ b/ui/app/egl_wayland.go
> > >         -func newEGLWindow(w _EGLNativeWindowType, width, height int) (*eglWindow, error) {
> > >         -       surf := (*C.struct_wl_surface)(unsafe.Pointer(w))
> > >         +func (w *wlWindow) newEGLWindow(ew _EGLNativeWindowType, width, height int) (eglWindow, error) {
> > >
> > > An EGL specific method for wlWindow, nice.

Re: [PATCH 1/2] ui/app: (wayland) refactor code path to allow X11 fallback 4 days ago

From Denys Smirnov to ~eliasnaur/gio

On Tue, 17 Sep 2019 at 12:21, Elias Naur <mail@eliasnaur.com> wrote:
>
>         diff --git a/ui/app/egl_wayland.go b/ui/app/egl_wayland.go
>         index d8fc4a5..4279b50 100644
>         --- a/ui/app/egl_wayland.go
>         +++ b/ui/app/egl_wayland.go
>         -func newEGLWindow(w _EGLNativeWindowType, width, height int) (*eglWindow, error) {
>         -       surf := (*C.struct_wl_surface)(unsafe.Pointer(w))
>         +func (w *wlWindow) newEGLWindow(ew _EGLNativeWindowType, width, height int) (eglWindow, error) {
>
> An EGL specific method for wlWindow, nice.

I only surfaced the code that was already calling the same
functionality indirectly. No more dependencies that it had, no less.

Re: [PATCH 6/6] ui/app: add "no X11" build tag 10 days ago

From Denys Smirnov to ~eliasnaur/gio

On Sun, 8 Sep 2019 at 12:14, Elias Naur <mail@eliasnaur.com> wrote:
>
> Thankyou. I'm using the result of a squash of all 6 patches for this
> review.
>
>         diff --git a/ui/app/egl.go b/ui/app/egl.go
>         index ee07993..6c448d9 100644
>         --- a/ui/app/egl.go
>         +++ b/ui/app/egl.go
>         @@ -9,6 +9,7 @@ import (
>                 "fmt"
>                 "runtime"
>                 "strings"
>         +       "unsafe"

[PATCH 1/6] ui/app: (wayland) return a specific error value when connection fails 14 days ago

From Denys Smirnov to ~eliasnaur/gio

Returning specific error will help the high-level code fallback from
Wayland to X11 code path.

Signed-off-by: Denys Smirnov <denis.smirnov.91@gmail.com>
---
 ui/app/os_wayland.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ui/app/os_wayland.go b/ui/app/os_wayland.go
index 571e8f2..5f8d654 100644
--- a/ui/app/os_wayland.go
+++ b/ui/app/os_wayland.go
@@ -54,6 +54,8 @@ import (
 */

Re: [PATCH] wayland: fix call in the initialization code 22 days ago

From Denys Smirnov to ~eliasnaur/gio

Awesome, thanks! It helps a lot.

On Fri, 30 Aug 2019 at 11:40, Elias Naur <mail@eliasnaur.com> wrote:
>
> On Fri Aug 30, 2019 at 1:19 AM Denys Smirnov wrote:
> >
> > Can you please make a few more comments here, e.g. point to callbacks
> > that receive those calls, or anything else that helps understand why
> > there are exactly 2 calls and not 1 or 3?
> >
>
> Expanded in
>
> To git.sr.ht:~eliasnaur/gio

Re: [PATCH] wayland: fix call in the initialization code 23 days ago

From Denys Smirnov to ~eliasnaur/gio

Got it, will revert locally. Thanks for checking it!

Can you please make a few more comments here, e.g. point to callbacks
that receive those calls, or anything else that helps understand why
there are exactly 2 calls and not 1 or 3?


On Thu, 29 Aug 2019 at 21:55, Elias Naur <mail@eliasnaur.com> wrote:
>
> > diff --git a/ui/app/os_wayland.go b/ui/app/os_wayland.go
> > index 2954459..aec7a39 100644
> > --- a/ui/app/os_wayland.go
> > +++ b/ui/app/os_wayland.go
> > @@ -1119,7 +1119,7 @@ func waylandConnect() error {