~dstar4138

Detroit, MI

https://dstar4138.com

[He/Him] Husband, Father, Programming Language and Distributed System Fanatic.

~dstar4138/note-devel

Last active 5 months ago

~dstar4138/crate-devel

Last active 5 months ago

~dstar4138/localnet-devel

Last active 8 months ago

~dstar4138/localnet-announce

Last active 8 months ago
View more

Recent activity

[PATCH genpdf-rs v2] Adds image support. 4 months ago

From Alexander Dean-Kennedy to ~ireas/public-inbox

#### [Purpose / Implementation Overview]
* Changes `elements` module to a directory to allow for conditional subelements.
* Gates this feature behind `images` feature-flag.
* Adds support to the demo, and includes a couple public-domain images.
* Adds another demo document for full functionality testing.
* BREAKING: Moves `Alignment` struct out of `elements` up to root.

### [Testing]
```
cargo run --example demo demo.pdf
cargo run --features images --example demo demo-with-images.pdf
cargo run --features images --example images images.pdf
```
---
[message trimmed]

Re: [[PATCH genpdf-rs]] Adds image support. 4 months ago

From Alexander Dean-Kennedy to ~ireas/public-inbox

Howdy!

>  I can’t apply the patch due to an error when adding the images

Shoot, I'm sorry, I'll double check that with V2.


> 1. The patch subject has an additional pair of brackets.

Yeah... I'm embarrassed, sorry. I'm still new to this style of PR.


> 2. Why do we need cfg-if?

[[PATCH genpdf-rs]] Adds image support. 4 months ago

From Alexander Dean-Kennedy to ~ireas/public-inbox

#### [Purpose / Implementation Overview]
* Changes `elements` module to a directory to allow for conditional subelements.
* Gates this feature behind `images` feature-flag.
* Adds support to the demo, and includes a couple public-domain images.
* BREAKING: Moves `Alignment` struct out of `elements` up to root.

### [Testing]
```
cargo run --features images --example demo demo.pdf
```
---
 CHANGELOG.md                         |   2 +
 Cargo.toml                           |   9 +
 README.md                            |   4 +-
[message trimmed]