Hi Robin,

On Mon, Feb 20, 2023, at 10:59 AM, Robin Jarry wrote:
> Hi all,
>
> as you may know, aerc is currently distributed under the MIT license.
> This prevents from shipping aerc with notmuch support always enabled
> (notmuch being GPL).
>
> After some multiple reported issues when building from source and
> countless discussions on IRC, it was suggested to change the licensing
> of aerc to GPL. Most downstream distributions already build aerc with
> notmuch support enabled anyways. This means that a lot of people are
> using aerc with GPL contamination.

This helps maintain uniform coding style, at least for me. I work on a
bunch of projects, most of which have different styles, so wires get
crossed sometimes without help of automation.

Most editors support .editorconfig out of the box. If not, there's a
whole bunch of pre-written plugins [0]. I happen to use
`editorconfig/editorconfig-vim`.

[0]: https://editorconfig.org/

Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
---
 .editorconfig | 3 +++
 1 file changed, 3 insertions(+)
[message trimmed]

Leaks resources to not close.

Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
---
 main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/main.c b/main.c
index dc76a86..b6548b7 100644
--- a/main.c
+++ b/main.c
@@ -185,6 +185,9 @@ main(int ac, char *av[])
 			}
 		}
[message trimmed]

typ->fields could be allocated but not freed.

Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
---
 parse.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/parse.c b/parse.c
index 70c291b..1a500a8 100644
--- a/parse.c
+++ b/parse.c
@@ -171,6 +171,17 @@ lexinit()
 	done = 1;
 }
[message trimmed]

I noticed a few memory leaks when running some examples under valgrind.

The fixes seemed simple enough so here they are.

Daniel Xu (2):
  Plug memory leak in type fields
  Close input file after done reading

 main.c  |  3 +++
 parse.c | 13 ++++++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

-- 
2.35.1

Hi,

Looks like the docs hosted online are out of date
( https://c9x.me/compile/doc/il.html ). Spent some time
figuring out the hello world example needed an `export`
on main(). Then noticed the fix was already checked in.

Thanks,
Daniel

On Tue, Nov 3, 2020, at 10:57 AM, y0ast wrote:
> Co-authored-by: Kevin Kuehler <keur@xcf.berkeley.edu>
> Co-authored-by: Reto Brunner <reto@labrat.space>
> ---
> v1 -> v2: rebase on master (by Reto)
> v2 -> v3: add account specific config
> 
> Please test and report bugs :)
[...]

I noticed that replies to old messages don't always get bubbled up to
the top of the message list. Not sure if this is intended or not.

I think it'd make sense to bubble the entire thread up to the top if a

On Sun Nov 8, 2020 at 8:58 AM PST, VÖRÖSKŐI András wrote:
> On Tue Nov 3, 2020 at 7:57 PM CET, y0ast wrote:
> >
> > Please test and report bugs :)
>
> I get `Unknown command: UID THREAD` at startup. Is gmail.com expected to
> work with it or i should not even try?

IIRC in an earlier patchset version it was mentioned gmail does not
support server side threading. Could be wrong, though.

FWIW, I'm using fastmail.

[...]

On Tue Nov 3, 2020 at 10:57 AM PST, y0ast wrote:
> Co-authored-by: Kevin Kuehler <keur@xcf.berkeley.edu>
> Co-authored-by: Reto Brunner <reto@labrat.space>
> ---
> v1 -> v2: rebase on master (by Reto)
> v2 -> v3: add account specific config
>
> Please test and report bugs :)

Applied and did some basic mail tasks. Seems to work great on my fairly
large mailing list folders (20k+ messages). I'll keep using it and
report any issues I see.

Thanks all for the great work!

The code was trying to compile the `~` as well. In this case, it was
trying to match a literal `~` to the front of the supplied regex.

Fixes: 334ca89bea381 ("folder filter: only assume regex if filter is
~fmt")

Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
---
 widgets/dirlist.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/widgets/dirlist.go b/widgets/dirlist.go
index 68ba61c..6214c8e 100644
--- a/widgets/dirlist.go
[message trimmed]