~ecs

https://ecs.d2evs.net

Recent activity

Re: How reflection works in **** 20 days ago

From Eyal Sawady to ~sircmpwn/public-inbox

On Tue Oct 5, 2021 at 9:39 PM UTC, Alexey T wrote:
> even after curly braces

The reason for this is consistency. Curly braces (or rather, compound
expressions) are just another type of expression in ****, and as such
shouldn't be special-cased as not having semicolons following them.

Re: [PATCH scdoc v2 1/2] Check for and abort on failed memory allocations 22 days ago

From Eyal Sawady to ~sircmpwn/public-inbox

On Sun Oct 3, 2021 at 5:34 PM UTC, Drew DeVault wrote:
> I don't think the oom function is needed anymore, just move its logic
> into xcalloc.

It is, but that usage should be replaced by xrealloc.

Re: [PATCH] Disallows differing row lengths in table 23 days ago

From Eyal Sawady to ~sircmpwn/public-inbox

On Sun Oct 3, 2021 at 12:36 AM UTC, Sebastian wrote:
> Whoops, sorry, the patch is for scdoc. Forgot to change the subject.

By the way, you can use `git config format.subjectPrefix 'PATCH scdoc'`
to fix the subject automatically for future patches.

Re: About "readability-as-a-service" 25 days ago

From Eyal Sawady to ~sircmpwn/public-inbox

On Thu Sep 30, 2021 at 4:29 PM UTC, Nulo wrote:
> On Sat, Sep 25, 2021 at 09:07:38AM +0200, Drew DeVault wrote:
> > https://readability.ignaskiela.eu/
>
> This page has an invalid TLS certificate, and when ignored, it presents
> a page in a language which I do not understand :B

It was moved to https://uncrap.agency

Re: [PATCH] keybindings: add shift as possible modifier 26 days ago

From Eyal Sawady to ~sircmpwn/visurf-devel

On Wed Sep 29, 2021 at 6:49 PM UTC, Jonathan Halmen wrote:
> this makes it possible to bind <S-space>
> ---
> frontends/visurf/keybindings.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/frontends/visurf/keybindings.c
> b/frontends/visurf/keybindings.c
> index 53af3fd6a..e51e4e11c 100644
> --- a/frontends/visurf/keybindings.c
> +++ b/frontends/visurf/keybindings.c
> @@ -13,6 +13,7 @@ struct mod_map {
> };
>  

[PATCH] nsvi: fix invalid write on paste a month ago

From Eyal Sawady to ~sircmpwn/visurf-devel

If the pasted string was larger than the command buffer, we didn't grow
the buffer by enough.
---
 frontends/visurf/window.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/frontends/visurf/window.c b/frontends/visurf/window.c
index 7ca67bbbf..96bfc7c5e 100644
--- a/frontends/visurf/window.c
+++ b/frontends/visurf/window.c
@@ -1100,7 +1100,9 @@ nsvi_window_exline_paste(struct nsvi_window *win)
			break;
		}
		if (exline->cmdln + n + 1 >= exline->cmdsz) {
[message trimmed]

[PATCH] nsvi: don't abort on follow with no hints a month ago

From Eyal Sawady to ~sircmpwn/visurf-devel

---
 frontends/visurf/commands.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/frontends/visurf/commands.c b/frontends/visurf/commands.c
index ef38ea527..81e97659e 100644
--- a/frontends/visurf/commands.c
+++ b/frontends/visurf/commands.c
@@ -242,6 +242,10 @@ cmd_follow(struct nsvi_state *state, int argc, char *argv[])
	}
	struct box *tree = html_get_box_tree(handle);
	follow_collect_hints(gw, tree, 0, 0);
	if (gw->nhint == 0) {
		NSLOG(netsurf, ERROR, "follow: no hints");
[message trimmed]

[PATCH] nsvi: add settings command a month ago

From Eyal Sawady to ~sircmpwn/visurf-devel

And add settings for the font and colors
---
Probably won't apply without my exline patch applied
 frontends/visurf/Makefile   |  2 +-
 frontends/visurf/commands.c | 20 ++++++++
 frontends/visurf/main.c     |  9 ++++
 frontends/visurf/settings.c | 98 +++++++++++++++++++++++++++++++++++++
 frontends/visurf/settings.h | 17 +++++++
 frontends/visurf/visurf.h   |  2 +
 frontends/visurf/window.c   | 90 ++++++++++++++++++++--------------
 7 files changed, 200 insertions(+), 38 deletions(-)
 create mode 100644 frontends/visurf/settings.c
 create mode 100644 frontends/visurf/settings.h
[message trimmed]

[PATCH] nsvi: don't draw exline twice a month ago

From Eyal Sawady to ~sircmpwn/visurf-devel

---
The issue is more noticable with smaller font sizes
 frontends/visurf/window.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/frontends/visurf/window.c b/frontends/visurf/window.c
index 01f789d3e..9b22ebbb7 100644
--- a/frontends/visurf/window.c
+++ b/frontends/visurf/window.c
@@ -209,13 +209,11 @@ draw_exline_statusbar(struct nsvi_window *win, struct pool_buffer *buf)
			win->width, MARGIN * 2 + height);
	cairo_fill(buf->cairo);

	cairo_set_source_u32(buf->cairo, 0xFFFFFFFF);
[message trimmed]

[PATCH] nsvi_bindings_handle: ignore modifiers a month ago

From Eyal Sawady to ~sircmpwn/visurf-devel

Fixes `gO` and any other bindings with modifiers after the first keysym.
---
There has to be a better way to check if a keysym is a modifier
 frontends/visurf/keybindings.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/frontends/visurf/keybindings.c b/frontends/visurf/keybindings.c
index c23ce4fc6..53af3fd6a 100644
--- a/frontends/visurf/keybindings.c
+++ b/frontends/visurf/keybindings.c
@@ -151,6 +151,9 @@ nsvi_bindings_handle(struct nsvi_bindings *state,
		state->nbuf = 0;
		return;
	}
[message trimmed]