~edwardloveall/scribe

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2

[PATCH scribe] Fix build missing carbon dependency in shards files

Details
Message ID
<168367170482.17109.6258559945263324615-0@git.sr.ht>
DKIM signature
missing
Download raw message
Patch: +7 -0
From: Lomanic <lomanic@hotmail.fr>

See for example https://gitlab.com/Lomanic/scribe-binaries/-/jobs/4249385293
for the error shown when trying to build scribe image.
---
 shard.lock | 4 ++++
 shard.yml  | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/shard.lock b/shard.lock
index 77c29ce..32b9985 100644
--- a/shard.lock
+++ b/shard.lock
@@ -16,6 +16,10 @@ shards:
    git: https://github.com/cadmiumcr/transliterator.git
    version: 0.1.0+git.commit.46c4c14594057dbcfaf27e7e7c8c164d3f0ce3f1

  carbon:
    git: https://github.com/luckyframework/carbon.git
    version: 0.3.0

  cry:
    git: https://github.com/luckyframework/cry.git
    version: 0.4.3
diff --git a/shard.yml b/shard.yml
index a5cda11..c8362d6 100644
--- a/shard.yml
+++ b/shard.yml
@@ -26,6 +26,9 @@ dependencies:
  lucky_task:
    github: luckyframework/lucky_task
    version: ~> 0.1.1
  carbon:
    github: luckyframework/carbon
    version: ~> 0.3.0
  monads:
    github: alex-lairan/monads
development_dependencies:
-- 
2.38.4
Details
Message ID
<23F3E76E-1015-4E0D-ABD9-5FBB3E6B1871@edwardloveall.com>
In-Reply-To
<168367170482.17109.6258559945263324615-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
Thanks Lomanic.

Carbon is a shard for sending emails. Since Scribe doesn't send emails,
would you be up for removing carbon entirely? You'll have to remove it
from a couple other places like src/shards.cr, spec/spec_helper.cr, and
spec/setup/reset_emails.cr.

If it ends up being more difficult we can use your original change. It
would be nice to remove it though since I don't ever plan to send emails
via Scribe.

Edward

On 9 May 2023, at 18:29, ~lomanic wrote:

> From: Lomanic <lomanic@hotmail.fr>
>
> See for example https://gitlab.com/Lomanic/scribe-binaries/-/jobs/4249385293
> for the error shown when trying to build scribe image.
> ---
>  shard.lock | 4 ++++
>  shard.yml  | 3 +++
>  2 files changed, 7 insertions(+)
>
> diff --git a/shard.lock b/shard.lock
> index 77c29ce..32b9985 100644
> --- a/shard.lock
> +++ b/shard.lock
> @@ -16,6 +16,10 @@ shards:
>      git: https://github.com/cadmiumcr/transliterator.git
>      version: 0.1.0+git.commit.46c4c14594057dbcfaf27e7e7c8c164d3f0ce3f1
>
> +  carbon:
> +    git: https://github.com/luckyframework/carbon.git
> +    version: 0.3.0
> +
>    cry:
>      git: https://github.com/luckyframework/cry.git
>      version: 0.4.3
> diff --git a/shard.yml b/shard.yml
> index a5cda11..c8362d6 100644
> --- a/shard.yml
> +++ b/shard.yml
> @@ -26,6 +26,9 @@ dependencies:
>    lucky_task:
>      github: luckyframework/lucky_task
>      version: ~> 0.1.1
> +  carbon:
> +    github: luckyframework/carbon
> +    version: ~> 0.3.0
>    monads:
>      github: alex-lairan/monads
>  development_dependencies:
> -- 
> 2.38.4
Details
Message ID
<2AE8D202-A1CE-43F1-9AA6-174250F8B2DF@edwardloveall.com>
In-Reply-To
<23F3E76E-1015-4E0D-ABD9-5FBB3E6B1871@edwardloveall.com> (view parent)
DKIM signature
missing
Download raw message
Hi Limanic. I just pushed a new version that should fix your error.

Edward

On 9 May 2023, at 19:36, Edward Loveall wrote:

> Thanks Lomanic.
>
> Carbon is a shard for sending emails. Since Scribe doesn't send emails,
> would you be up for removing carbon entirely? You'll have to remove it
> from a couple other places like src/shards.cr, spec/spec_helper.cr, and
> spec/setup/reset_emails.cr.
>
> If it ends up being more difficult we can use your original change. It
> would be nice to remove it though since I don't ever plan to send emails
> via Scribe.
>
> Edward
>
> On 9 May 2023, at 18:29, ~lomanic wrote:
>
>> From: Lomanic <lomanic@hotmail.fr>
>>
>> See for example https://gitlab.com/Lomanic/scribe-binaries/-/jobs/4249385293
>> for the error shown when trying to build scribe image.
>> ---
>>  shard.lock | 4 ++++
>>  shard.yml  | 3 +++
>>  2 files changed, 7 insertions(+)
>>
>> diff --git a/shard.lock b/shard.lock
>> index 77c29ce..32b9985 100644
>> --- a/shard.lock
>> +++ b/shard.lock
>> @@ -16,6 +16,10 @@ shards:
>>      git: https://github.com/cadmiumcr/transliterator.git
>>      version: 0.1.0+git.commit.46c4c14594057dbcfaf27e7e7c8c164d3f0ce3f1
>>
>> +  carbon:
>> +    git: https://github.com/luckyframework/carbon.git
>> +    version: 0.3.0
>> +
>>    cry:
>>      git: https://github.com/luckyframework/cry.git
>>      version: 0.4.3
>> diff --git a/shard.yml b/shard.yml
>> index a5cda11..c8362d6 100644
>> --- a/shard.yml
>> +++ b/shard.yml
>> @@ -26,6 +26,9 @@ dependencies:
>>    lucky_task:
>>      github: luckyframework/lucky_task
>>      version: ~> 0.1.1
>> +  carbon:
>> +    github: luckyframework/carbon
>> +    version: ~> 0.3.0
>>    monads:
>>      github: alex-lairan/monads
>>  development_dependencies:
>> -- 
>> 2.38.4
Reply to thread Export thread (mbox)