Hi,
Would you please consider adding a separate Dockerfile.arm64 <https://github.com/zedeus/nitter/blob/master/Dockerfile.arm64>? Network timeouts and the lack of a crystallang base image are two main issues on ARM. They can be solved by changing the following lines. Thanks!
# RUN yarn install --no-progress --frozen-lockfile
RUN yarn install --network-timeout 120000 --no-progress --frozen-lockfile
# FROM crystallang/crystal:1.5-alpine as lucky_buildFROM alpine:3.18.4 AS lucky_build
RUN apk add --no-cache 'crystal=1.8.2-r0' shards sqlite-static yaml-static yaml-dev libxml2-dev zlib-static openssl-libs-static openssl-dev musl-dev
Hi,
Would you please consider adding a separate Dockerfile.arm64? Network timeouts and the lack of a crystallang base image are two main issues on ARM. They can be solved by changing the following lines. Thanks!
# RUN yarn install --no-progress --frozen-lockfile
RUN yarn install --network-timeout 120000 --no-progress --frozen-lockfile
# FROM crystallang/crystal:1.5-alpine as lucky_build
FROM alpine:3.18.4 AS lucky_build
RUN apk add --no-cache 'crystal=1.8.2-r0' shards sqlite-static yaml-static yaml-dev libxml2-dev zlib-static openssl-libs-static openssl-dev musl-dev
Hi opnxng,
I just pushed a branch "el-docker-arm64" with the changes you mentioned. I don't use Docker, so would you try it out to make sure it works?
If all looks good I'll merge it in.
Edward
On 10 Oct 2023, at 13:46, opnxng@tuta.io wrote:
> Hi,>> Would you please consider adding a separate Dockerfile.arm64 <https://github.com/zedeus/nitter/blob/master/Dockerfile.arm64> ? Network timeouts and the lack of a crystallang base image are two main issues on ARM. They can be solved by changing the following lines. Thanks!>>> # RUN yarn install --no-progress --frozen-lockfile> RUN yarn install --network-timeout 120000 --no-progress --frozen-lockfile>> # FROM crystallang/crystal:1.5-alpine as lucky_buildFROM alpine:3.18.4 AS lucky_build> RUN apk add --no-cache 'crystal=1.8.2-r0' shards sqlite-static yaml-static yaml-dev libxml2-dev zlib-static openssl-libs-static openssl-dev musl-dev
Hi Edward,
Thanks for the swift reply. In my testing, "FROM alpine:3.18.4 AS lucky_build" need to be added after "RUN yarn prod", the build process fails otherwise with the following error:
invalid from flag value node_build: pull access denied for node_build, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
A working dockerfile.amd64 can be found here: https://b.opnxng.com/?a1098a94417264d9#8KaJpcSxpgfb7k4SQewtJ2xcnJf8w4LeDh38RZNvwApQ
(Tested on my instance m.opnxng.com <http://m.opnxng.com>.) Thank you!
Oct 11, 2023, 07:47 by edward@edwardloveall.com:
> Hi opnxng,>> I just pushed a branch "el-docker-arm64" with the changes you mentioned. I don't use Docker, so would you try it out to make sure it works?>> If all looks good I'll merge it in.>> Edward>> On 10 Oct 2023, at 13:46, opnxng@tuta.io wrote:>>> Hi,>>>> Would you please consider adding a separate Dockerfile.arm64 <https://github.com/zedeus/nitter/blob/master/Dockerfile.arm64> ? Network timeouts and the lack of a crystallang base image are two main issues on ARM. They can be solved by changing the following lines. Thanks!>>>>>> # RUN yarn install --no-progress --frozen-lockfile>> RUN yarn install --network-timeout 120000 --no-progress --frozen-lockfile>>>> # FROM crystallang/crystal:1.5-alpine as lucky_buildFROM alpine:3.18.4 AS lucky_build>> RUN apk add --no-cache 'crystal=1.8.2-r0' shards sqlite-static yaml-static yaml-dev libxml2-dev zlib-static openssl-libs-static openssl-dev musl-dev>>
Ah I see. I think your initial message was missing a newline around the FROM and I thought you were saying I should remove that line. I just committed it back to the branch and pushed it up. It should now match your example Dockerfile (thank you for that, BTW).
If that works, let me know and I'll merge it.
Edward
P.S. Both of your emails have come in twice so far. Is that intentional?
On 11 Oct 2023, at 23:47, opnxng@tuta.io wrote:
> Hi Edward,>> Thanks for the swift reply. In my testing, "FROM alpine:3.18.4 AS lucky_build" need to be added after "RUN yarn prod", the build process fails otherwise with the following error:>> invalid from flag value node_build: pull access denied for node_build, repository does not exist or may require 'docker login': denied: requested access to the resource is denied>> A working dockerfile.amd64 can be found here: https://b.opnxng.com/?a1098a94417264d9#8KaJpcSxpgfb7k4SQewtJ2xcnJf8w4LeDh38RZNvwApQ>> (Tested on my instance m.opnxng.com <http://m.opnxng.com> .) Thank you!>>> Oct 11, 2023, 07:47 by edward@edwardloveall.com:>>> Hi opnxng,>>>> I just pushed a branch "el-docker-arm64" with the changes you mentioned. I don't use Docker, so would you try it out to make sure it works?>>>> If all looks good I'll merge it in.>>>> Edward>>>> On 10 Oct 2023, at 13:46, opnxng@tuta.io wrote:>>>>> Hi,>>>>>> Would you please consider adding a separate Dockerfile.arm64 <https://github.com/zedeus/nitter/blob/master/Dockerfile.arm64> ? Network timeouts and the lack of a crystallang base image are two main issues on ARM. They can be solved by changing the following lines. Thanks!>>>>>>>>> # RUN yarn install --no-progress --frozen-lockfile>>> RUN yarn install --network-timeout 120000 --no-progress --frozen-lockfile>>>>>> # FROM crystallang/crystal:1.5-alpine as lucky_buildFROM alpine:3.18.4 AS lucky_build>>> RUN apk add --no-cache 'crystal=1.8.2-r0' shards sqlite-static yaml-static yaml-dev libxml2-dev zlib-static openssl-libs-static openssl-dev musl-dev>>>
Dear Edward,
Thank you! It works as intended now.
Sorry I'm unfamiliar with the sourcehunt mailing list and made some mistakes.
Best,
O
Oct 13, 2023, 08:19 by edward@edwardloveall.com:
> Ah I see. I think your initial message was missing a newline around the FROM and I thought you were saying I should remove that line. I just committed it back to the branch and pushed it up. It should now match your example Dockerfile (thank you for that, BTW).>> If that works, let me know and I'll merge it.>> Edward>> P.S. Both of your emails have come in twice so far. Is that intentional?>> On 11 Oct 2023, at 23:47, opnxng@tuta.io wrote:>>> Hi Edward,>>>> Thanks for the swift reply. In my testing, "FROM alpine:3.18.4 AS lucky_build" need to be added after "RUN yarn prod", the build process fails otherwise with the following error:>>>> invalid from flag value node_build: pull access denied for node_build, repository does not exist or may require 'docker login': denied: requested access to the resource is denied>>>> A working dockerfile.amd64 can be found here: https://b.opnxng.com/?a1098a94417264d9#8KaJpcSxpgfb7k4SQewtJ2xcnJf8w4LeDh38RZNvwApQ>>>> (Tested on my instance m.opnxng.com <http://m.opnxng.com> .) Thank you!>>>>>> Oct 11, 2023, 07:47 by edward@edwardloveall.com:>>>>> Hi opnxng,>>>>>> I just pushed a branch "el-docker-arm64" with the changes you mentioned. I don't use Docker, so would you try it out to make sure it works?>>>>>> If all looks good I'll merge it in.>>>>>> Edward>>>>>> On 10 Oct 2023, at 13:46, opnxng@tuta.io wrote:>>>>>>> Hi,>>>>>>>> Would you please consider adding a separate Dockerfile.arm64 <https://github.com/zedeus/nitter/blob/master/Dockerfile.arm64> ? Network timeouts and the lack of a crystallang base image are two main issues on ARM. They can be solved by changing the following lines. Thanks!>>>>>>>>>>>> # RUN yarn install --no-progress --frozen-lockfile>>>> RUN yarn install --network-timeout 120000 --no-progress --frozen-lockfile>>>>>>>> # FROM crystallang/crystal:1.5-alpine as lucky_buildFROM alpine:3.18.4 AS lucky_build>>>> RUN apk add --no-cache 'crystal=1.8.2-r0' shards sqlite-static yaml-static yaml-dev libxml2-dev zlib-static openssl-libs-static openssl-dev musl-dev>>>>
Great! It's now on main.
And no worries. I wasn't sure if I was missing some context. Mailing lists are not what a lot of folks are used to.
Thanks for your help in adding this.
Edward
On 12 Oct 2023, at 22:18, opnxng@tuta.io wrote:
> Dear Edward,>> Thank you! It works as intended now.>> Sorry I'm unfamiliar with the sourcehunt mailing list and made some mistakes.>> Best,> O>>> Oct 13, 2023, 08:19 by edward@edwardloveall.com:>>> Ah I see. I think your initial message was missing a newline around the FROM and I thought you were saying I should remove that line. I just committed it back to the branch and pushed it up. It should now match your example Dockerfile (thank you for that, BTW).>>>> If that works, let me know and I'll merge it.>>>> Edward>>>> P.S. Both of your emails have come in twice so far. Is that intentional?>>>> On 11 Oct 2023, at 23:47, opnxng@tuta.io wrote:>>>>> Hi Edward,>>>>>> Thanks for the swift reply. In my testing, "FROM alpine:3.18.4 AS lucky_build" need to be added after "RUN yarn prod", the build process fails otherwise with the following error:>>>>>> invalid from flag value node_build: pull access denied for node_build, repository does not exist or may require 'docker login': denied: requested access to the resource is denied>>>>>> A working dockerfile.amd64 can be found here: https://b.opnxng.com/?a1098a94417264d9#8KaJpcSxpgfb7k4SQewtJ2xcnJf8w4LeDh38RZNvwApQ>>>>>> (Tested on my instance m.opnxng.com <http://m.opnxng.com> .) Thank you!>>>>>>>>> Oct 11, 2023, 07:47 by edward@edwardloveall.com:>>>>>>> Hi opnxng,>>>>>>>> I just pushed a branch "el-docker-arm64" with the changes you mentioned. I don't use Docker, so would you try it out to make sure it works?>>>>>>>> If all looks good I'll merge it in.>>>>>>>> Edward>>>>>>>> On 10 Oct 2023, at 13:46, opnxng@tuta.io wrote:>>>>>>>>> Hi,>>>>>>>>>> Would you please consider adding a separate Dockerfile.arm64 <https://github.com/zedeus/nitter/blob/master/Dockerfile.arm64> ? Network timeouts and the lack of a crystallang base image are two main issues on ARM. They can be solved by changing the following lines. Thanks!>>>>>>>>>>>>>>> # RUN yarn install --no-progress --frozen-lockfile>>>>> RUN yarn install --network-timeout 120000 --no-progress --frozen-lockfile>>>>>>>>>> # FROM crystallang/crystal:1.5-alpine as lucky_buildFROM alpine:3.18.4 AS lucky_build>>>>> RUN apk add --no-cache 'crystal=1.8.2-r0' shards sqlite-static yaml-static yaml-dev libxml2-dev zlib-static openssl-libs-static openssl-dev musl-dev>>>>>