scribe: Fix build missing carbon dependency in shards files v1 PROPOSED

~lomanic: 1
 Fix build missing carbon dependency in shards files

 2 files changed, 7 insertions(+), 0 deletions(-)

Hi Limanic. I just pushed a new version that should fix your error.

Edward

[PATCH scribe] Fix build missing carbon dependency in shards files Export this patch

From: Lomanic <lomanic@hotmail.fr>

See for example https://gitlab.com/Lomanic/scribe-binaries/-/jobs/4249385293
for the error shown when trying to build scribe image.
---
 shard.lock | 4 ++++
 shard.yml  | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/shard.lock b/shard.lock
index 77c29ce..32b9985 100644
--- a/shard.lock
+++ b/shard.lock
@@ -16,6 +16,10 @@ shards:
     git: https://github.com/cadmiumcr/transliterator.git
     version: 0.1.0+git.commit.46c4c14594057dbcfaf27e7e7c8c164d3f0ce3f1
 
+  carbon:
+    git: https://github.com/luckyframework/carbon.git
+    version: 0.3.0
+
   cry:
     git: https://github.com/luckyframework/cry.git
     version: 0.4.3
diff --git a/shard.yml b/shard.yml
index a5cda11..c8362d6 100644
--- a/shard.yml
+++ b/shard.yml
@@ -26,6 +26,9 @@ dependencies:
   lucky_task:
     github: luckyframework/lucky_task
     version: ~> 0.1.1
+  carbon:
+    github: luckyframework/carbon
+    version: ~> 0.3.0
   monads:
     github: alex-lairan/monads
 development_dependencies:
-- 
2.38.4

Edward Loveall <edward@edwardloveall.com>

1 year, 5 months ago

Thanks Lomanic.

Carbon is a shard for sending emails. Since Scribe doesn't send emails,
would you be up for removing carbon entirely? You'll have to remove it
from a couple other places like src/shards.cr, spec/spec_helper.cr, and
spec/setup/reset_emails.cr.

If it ends up being more difficult we can use your original change. It
would be nice to remove it though since I don't ever plan to send emails
via Scribe.

Edward