From Elias Naur to ~eliasnaur/gio-patches
Thanks, merged.
From Elias Naur to ~eliasnaur/gio-patches
I think this change is generally good:
- The user can access the system menu by pressing Alt+Space.
- cmd.exe also blocks F10 from showing the system menu, presumably
because it doesn't have a regular menu, or maybe because F10 means
other things in a terminal.
- You mentioned debuggers use F10 for their own purposes as well.
However, your change also blocks the Alt key for accessing the system
menu; in particular, Alt-F4 no longer exits a Gio program. I think you
need to filter F10 specifically.
On Fri Apr 9, 2021 at 10:05, aarzilli wrote:
> F10 has a special meaning on Windows, if the default handler runs the
From Elias Naur to ~eliasnaur/gio-patches
On Wed Apr 7, 2021 at 10:01 CEST, Pierre Curto wrote: > Le mer. 7 avr. 2021 à 09:58, Elias Naur <mail@eliasnaur.com> a écrit : > > > > On Wed Apr 7, 2021 at 09:44 CEST, Pierre Curto wrote: > > > Great! > > > > > > Now, how do you see manipulating the window options from ops? > > > A WindowOptionOp in the op package for instance? > > > > > > > Can you think of a use-case for WindowOptionOp where app.Window.Option > > is not appropriate? > > > > Triggering an option change (say, fullscreen mode) may happen as a
From Elias Naur to ~eliasnaur/gio-patches
On Wed Apr 7, 2021 at 09:44 CEST, Pierre Curto wrote: > Great! > > Now, how do you see manipulating the window options from ops? > A WindowOptionOp in the op package for instance? > Can you think of a use-case for WindowOptionOp where app.Window.Option is not appropriate? Triggering an option change (say, fullscreen mode) may happen as a result of interacting with a widget (say, a checkbox) but setting the option itself seems to belong in the main program logic, not in an op.
From Elias Naur to ~eliasnaur/gio-patches
Thanks, merged. Elias
From Elias Naur to ~eliasnaur/gio-patches
On Wed Apr 7, 2021 at 09:02 CEST, Pierre Curto wrote: > Le mer. 7 avr. 2021 à 08:16, Elias Naur <mail@eliasnaur.com> a écrit : > > > > Almost there. > > > > On Tue Apr 6, 2021 at 18:46 CEST, ~pierrec wrote: > > > diff --git a/app/internal/wm/os_x11.go b/app/internal/wm/os_x11.go > > > index b921d468..3c18241a 100644 > > > --- a/app/internal/wm/os_x11.go > > > +++ b/app/internal/wm/os_x11.go > > > @@ -124,6 +126,20 @@ func (w *x11Window) WriteClipboard(s string) { > > > } > > > > > > func (w *x11Window) Option(opts *Options) {
From Elias Naur to ~eliasnaur/gio-patches
Almost there. On Tue Apr 6, 2021 at 18:46 CEST, ~pierrec wrote: > diff --git a/app/internal/wm/os_x11.go b/app/internal/wm/os_x11.go > index b921d468..3c18241a 100644 > --- a/app/internal/wm/os_x11.go > +++ b/app/internal/wm/os_x11.go > @@ -124,6 +126,20 @@ func (w *x11Window) WriteClipboard(s string) { > } > > func (w *x11Window) Option(opts *Options) { > + w.mu.Lock() > + w.opts = opts > + w.mu.Unlock()
From Elias Naur to ~eliasnaur/gio-patches
On Sat Apr 3, 2021 at 21:13, ~pierrec wrote: > From: pierre <pierre.curto@gmail.com> > > A Window can now be requested to change its options after > it has been started via its Option method. > > All options are supported on macOS, Windows and X11. > On Wayland, only the Size and Title options can be changed > at runtime. > > Signed-off-by: pierre <pierre.curto@gmail.com> > --- > diff --git a/app/internal/wm/os_wayland.go b/app/internal/wm/os_wayland.go > index 1e8c59d9..25e86898 100644
From Elias Naur to ~eliasnaur/gio-patches
On Sat Apr 3, 2021 at 21:13 CEST, ~pierrec wrote: > From: pierre <pierre.curto@gmail.com> > > A Window can now be requested to change its options after > it has been started via its Option method. > > All options are supported on macOS, Windows and X11. > On Wayland, only the Size and Title options can be changed > at runtime. > > Signed-off-by: pierre <pierre.curto@gmail.com> > --- > - > func (w *window) SetCursor(name pointer.CursorName) {
From Elias Naur to ~eliasnaur/gio-patches
Thanks, merged. Elias