~eliasnaur

~eliasnaur/gio-patches

Last active an hour ago

~eliasnaur/gio

Last active 5 days ago

~eliasnaur/test

Last active 11 months ago
View more

Recent activity

Re: [PATCH v3] cmd/gogio: added flag for app icon 12 hours ago

From Elias Naur to ~eliasnaur/gio-patches

Thank you. Almost there.

Make the commit message slightly more specific, and conform to the
usual Go style. Suggestion:

cmd/gogio: add -icon flag for specifying the app icon file

On Fri Aug 14, 2020 at 00:30, axel paulander wrote:
> Turns out I'm the one who misread, this version should fix that.

Leave this line out of the commit message.

> ---
>  cmd/go.sum                | 1 +

Re: [PATCH] cmd/gogio: added flag for app icon 23 hours ago

From Elias Naur to ~eliasnaur/gio-patches

Feature LGTM, some comments on the implementation below.

On Thu Aug 13, 2020 at 7:12 PM CEST, axel paulander wrote:
> Before users were limited to only use a appicon.png in the root directory.
> Now the user is free to use any png anywhere on the system with the help of the -icon flag.
>
> Signed-off-by: Axel Paulander <axel.paulander@gmail.com>
> ---
>  cmd/gogio/androidbuild.go | 2 +-
>  cmd/gogio/help.go         | 6 +++---
>  cmd/gogio/iosbuild.go     | 2 +-
>  cmd/gogio/main.go         | 1 +
>  4 files changed, 6 insertions(+), 5 deletions(-)
>

Re: [PATCH] cmd/gogio: added flag for app icon a day ago

From Elias Naur to ~eliasnaur/gio-patches

On Thu Aug 13, 2020 at 7:12 PM CEST, axel paulander wrote:
> Before users were limited to only use a appicon.png in the root directory.
> Now the user is free to use any png anywhere on the system with the help of the -icon flag.
>

What is the usecase for the flag? I hope to keep the number of flags
minimal.

Elias

Re: [PATCH] widget/material: Make checkbox/radio buttons icon modifiable a day ago

From Elias Naur to ~eliasnaur/gio-patches

I believe this change is already merged:

https://git.sr.ht/~eliasnaur/gio/commit/c3574cdabdb100456fe2ecc6baef49d1dda57837

I wrote an email to you, but it probably got lost since your email adress was
invalid (song@zz.local). It said:

"Thank you. Merged except for the kitchen changes which I found more
confusing that worth the example."

Elias

On Wed Aug 12, 2020 at 23:51, Song wrote:
> Signed-off-by: songpv <pvsong10@icloud.com>

Re: [PATCH] widget/material: Make checkbox/radio buttons icon modifiable 4 days ago

From Elias Naur to ~eliasnaur/gio-patches

Thank you. Merged except for the kitchen changes which I found more
confusing that worth the example.

On Mon Aug 10, 2020 at 23:13, songpv wrote:
> From: Song <song@zz.local>
>

Can you update your configuration so that your from address is a real
email address?

> Signed-off-by: songpv <pvsong10@icloud.com>
> ---
>  example/kitchen/kitchen.go     | 17 ++++++++++++++---
>  widget/material/checkbox.go    |  4 ++--

Re: [PATCH 2/2] include/files/architecture: fix comment 4 days ago

From Elias Naur to ~eliasnaur/gio-patches

Merged, and all your fixes deployed.

Re: [PATCH 1/2] content/doc: fix links to package documentation 4 days ago

From Elias Naur to ~eliasnaur/gio-patches

Merged, with a single change.

On Sun Aug 9, 2020 at 22:16, Frank Braun wrote:
> Signed-off-by: Frank Braun <frank@cryptogroup.net>
> ---
>  content/doc/architecture.md | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/content/doc/architecture.md b/content/doc/architecture.md
> index c38bcb8..b811714 100644
> --- a/content/doc/architecture.md
> +++ b/content/doc/architecture.md
> @@ -218,7 +218,7 @@ Input is delivered to the widgets via a [`system.FrameEvent`](https://gioui.org/
>  

Re: [PATCH] content: add godcr link to programs using Gio 4 days ago

From Elias Naur to ~eliasnaur/gio-patches

Good catch. Added sprig as well.

Elias

Re: [PATCH] content/doc: bring text in sync with code 4 days ago

From Elias Naur to ~eliasnaur/gio-patches

Thanks, applied and deployed.

Elias