~eliasnaur

~eliasnaur/gio-patches

Last active 9 hours ago

~eliasnaur/gio

Last active 3 days ago

~eliasnaur/test

Last active 11 months ago
View more

Recent activity

Re: [PATCH] widget/material: Make checkbox/radio buttons icon modifiable 2 days ago

From Elias Naur to ~eliasnaur/gio-patches

Thank you. Merged except for the kitchen changes which I found more
confusing that worth the example.

On Mon Aug 10, 2020 at 23:13, songpv wrote:
> From: Song <song@zz.local>
>

Can you update your configuration so that your from address is a real
email address?

> Signed-off-by: songpv <pvsong10@icloud.com>
> ---
>  example/kitchen/kitchen.go     | 17 ++++++++++++++---
>  widget/material/checkbox.go    |  4 ++--

Re: [PATCH 2/2] include/files/architecture: fix comment 2 days ago

From Elias Naur to ~eliasnaur/gio-patches

Merged, and all your fixes deployed.

Re: [PATCH 1/2] content/doc: fix links to package documentation 2 days ago

From Elias Naur to ~eliasnaur/gio-patches

Merged, with a single change.

On Sun Aug 9, 2020 at 22:16, Frank Braun wrote:
> Signed-off-by: Frank Braun <frank@cryptogroup.net>
> ---
>  content/doc/architecture.md | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/content/doc/architecture.md b/content/doc/architecture.md
> index c38bcb8..b811714 100644
> --- a/content/doc/architecture.md
> +++ b/content/doc/architecture.md
> @@ -218,7 +218,7 @@ Input is delivered to the widgets via a [`system.FrameEvent`](https://gioui.org/
>  

Re: [PATCH] content: add godcr link to programs using Gio 3 days ago

From Elias Naur to ~eliasnaur/gio-patches

Good catch. Added sprig as well.

Elias

Re: [PATCH] content/doc: bring text in sync with code 3 days ago

From Elias Naur to ~eliasnaur/gio-patches

Thanks, applied and deployed.

Elias

Re: [PATCH] widget/material: Make checkbox/radio icon modifiable 3 days ago

From Elias Naur to ~eliasnaur/gio-patches

Looks good to me. Please separate your change to kitchen in a patch on
top of your first patch, and send both with

	git send-email HEAD~2

(or through the sr.ht web interface.)

Add the Signed-off-by line as described in
https://gioui.org/doc/contribute.

Elias

Re: [PATCH] widget/material: Make checkbox/radio buttons icon modifiable 3 days ago

From Elias Naur to ~eliasnaur/gio-patches

Looks good to me. Please add the Signed-off-by line as described in
https://gioui.org/doc/contribute.

Elias

Re: [PATCH] app,app/internal/window,io/system: macOS menus 3 days ago

From Elias Naur to ~eliasnaur/gio-patches

Thank you for working on this. Like your other change, this change
introduces new concepts that I didn't find time to think through until
now. Apologies.

First, I'm not convinced it's worth abstracting this functionality to
other platforms that put menus inside windows. Creating Gio-native menu
widgets is more upfront work but pays off in simpler interfaces, less
maintenance and most importantly in matching menu and widget styles.
Of course, it would be nice to reuse menu descriptor types for both
macOS system menus and Gio menus.

Restricting system menus to macOS also eliminates the question of where
to deliver events. macOS menus are app global, so a natural answer is to
introduce an app global event channel. In addition, menus can be

Re: [PATCH v2] layout: add List.ScrollTo, ScrollPages, and 2 more 5 days ago

From Elias Naur to ~eliasnaur/gio-patches

I apologize for the delay; I've been away and List isn't subtle enough
to deal with in the small time slots I had available.

On Mon Jul 20, 2020 at 11:08 AM CEST, Larry Clapp wrote:
> Also add PagePrev & PageNext.
>
> Include tests for all.
>

Thank you very much for the tests, they make it much easier to focus on
the patch itself and worry less about regressions.

> Signed-off-by: Larry Clapp <larry@theclapp.org>
> ---