~eliasnaur

~eliasnaur/gio-patches

Last active 21 hours ago

~eliasnaur/gio

Last active 10 days ago

~eliasnaur/test

Last active 11 months ago
View more

Recent activity

Re: [PATCH] widget/material: Make checkbox icon modifiable Currently checkbox use default icon. Now can change it 21 hours ago

From Elias Naur to ~eliasnaur/gio-patches

Looks good, one comment below.

On Sun Jul 26, 2020 at 02:07, Song wrote:
> ---
>  widget/material/checkbox.go | 4 ++--
>  widget/material/theme.go    | 8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/widget/material/checkbox.go b/widget/material/checkbox.go
> index 22f37ad..c403a7d 100644
> --- a/widget/material/checkbox.go
> +++ b/widget/material/checkbox.go
> @@ -23,8 +23,8 @@ func CheckBox(th *Theme, checkBox *widget.Bool, label string) CheckBoxStyle {
>  			TextSize:           th.TextSize.Scale(14.0 / 16.0),

Re: [PATCH] fix handling of enter key for android 21 hours ago

From Elias Naur to ~eliasnaur/gio-patches

LGTM. One comment below.

On Wed Jul 29, 2020 at 17:39,  wrote:
> From: David Linus Briemann <dlb@mailbox.org>
>
> - add proper keycode for android enter key event
> - test if a character is printable via unicode pkg from go std lib
> ---
>  app/internal/window/os_android.go | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/app/internal/window/os_android.go b/app/internal/window/os_android.go
> index 3458b26..1beb79b 100644
> --- a/app/internal/window/os_android.go

Re: Make checkbox icon modifiable 9 days ago

From Elias Naur to ~eliasnaur/gio-patches

On Fri Jul 24, 2020 at 17:27, Pham Song wrote:
> Sure, but how I create the patch
>

See https://gioui.org/doc/contribute.

Elias

Re: July Community Call Thu 23. 15.30 UTC 10 days ago

From Elias Naur to ~eliasnaur/gio

On Mon Jul 20, 2020 at 12:38, Elias Naur wrote:
> The next Gio Community call is scheduled for
>
>         Thursday, July 23rd 2020 15.30 UTC
>
> Chris Waldon will present his material design components,
> sprig, and the Arbor chat system. Viktor Ogeman will present
> his work on improving and speeding up Gio vector rendering.
>

The recording is live: https://youtu.be/-LIbXfuzfS0

Elias

Re: July Community Call Thu 23. 15.30 UTC 10 days ago

From Elias Naur to ~eliasnaur/gio

On Mon Jul 20, 2020 at 2:38 PM CEST, Elias Naur wrote:
> The Google Meet link is
>
>        https://meet.google.com/kgh-dchp-vig 
>

The link has changed:

	https://meet.google.com/bvr-exau-mvi

Sorry for the inconvenience.

Elias

Re: Make checkbox icon modifiable 10 days ago

From Elias Naur to ~eliasnaur/gio-patches

On Wed Jul 22, 2020 at 10:41, Pham Song wrote:
> Yes, that would be great

Great. Would you like to prepare the patch?

Elias

Re: Make checkbox icon modifiable 12 days ago

From Elias Naur to ~eliasnaur/gio-patches

On Tue Jul 21, 2020 at 20:26, Pham Song wrote:
> Hello, 
>
> if in checkbox.go, add method to modifiable the icons, it would be useful when user want to custom the icon rather than default
>
>
> func (c *CheckBoxStyle) SetIcons(checked *widget.Icon, unchecked *widget.Icon) {
> 	if checked != nil {
> 		c.checkedStateIcon = checked
> 	}
>
> 	if unchecked != nil {
> 		c.uncheckedStateIcon = unchecked
> 	}

July Community Call Thu 23. 15.30 UTC 13 days ago

From Elias Naur to ~eliasnaur/gio

The next Gio Community call is scheduled for

        Thursday, July 23rd 2020 15.30 UTC

Chris Waldon will present his material design components,
sprig, and the Arbor chat system. Viktor Ogeman will present
his work on improving and speeding up Gio vector rendering.

The Google Meet link is

       https://meet.google.com/kgh-dchp-vig 

Please note that the call will be recorded and published
on YouTube.

Re: [PATCH gio 0/2] Properly animate elliptical material.IconButtons 16 days ago

From Elias Naur to ~eliasnaur/gio-patches

On Fri Jul 17, 2020 at 19:42, ~whereswaldon wrote:
> I can understand if this feature isn't accepted because it is rarely
> needed,

The API should gracefully accept all valid input, including the unusual.

> but I thought I'd propose it just in case. The IconButton
> animation code currently assumes that the button is a circle, which
> makes the animation for a click appear off-center or weirdly aligned.

Thanks, merged.

Elias

Re: [PATCH v2] gpu: cap max texture size to 8192 17 days ago

From Elias Naur to ~eliasnaur/gio-patches

On Thu Jun 11, 2020 at 14:57, Luke Rewega wrote:
> Capping the texture atlas to 8k seems to avoid any corruption caused by
> drawing to coordinates greater than 8192, which seems to be due to some
> loss of precision somewhere else. This texture size should be sufficient
> for any current-era display, except where lots of overlapping (but not
> clipping) paths are being displayed. Additionally, Gio should tolerate
> max texture sizes smaller than the display, and be able to make use of
> multiple textures.
>
> If the precision issues are eventually resolved, and then this change
> should be reverted.
>
> Fixes issue #131
>