~eliasnaur/gio-patches

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 3

[PATCH] pp/window,app/internal/window: Allow max and min window size for macOS

Details
Message ID
<20200616165230.1098143-1-sourcehut@sweatyballs.es>
DKIM signature
missing
Download raw message
Patch: +21 -6
Signed-off-by: Jason <sourcehut@sweatyballs.es>
---
 app/internal/window/os_macos.go | 13 +++++++++++--
 app/internal/window/os_macos.m  | 14 ++++++++++----
 2 files changed, 21 insertions(+), 6 deletions(-)

diff --git a/app/internal/window/os_macos.go b/app/internal/window/os_macos.go
index fef2acd..26e03fc 100644
--- a/app/internal/window/os_macos.go
+++ b/app/internal/window/os_macos.go
@@ -40,7 +40,7 @@ __attribute__ ((visibility ("hidden"))) CFTypeRef gio_readClipboard(void);
__attribute__ ((visibility ("hidden"))) void gio_writeClipboard(unichar *chars, NSUInteger length);
__attribute__ ((visibility ("hidden"))) void gio_setNeedsDisplay(CFTypeRef viewRef);
__attribute__ ((visibility ("hidden"))) void gio_appTerminate(void);
__attribute__ ((visibility ("hidden"))) CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat width, CGFloat height);
__attribute__ ((visibility ("hidden"))) CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat width, CGFloat height, CGFloat minWidth, CGFloat minHeight, CGFloat maxWidth, CGFloat maxHeight);
__attribute__ ((visibility ("hidden"))) void gio_makeKeyAndOrderFront(CFTypeRef windowRef);
__attribute__ ((visibility ("hidden"))) NSPoint gio_cascadeTopLeftFromPoint(CFTypeRef windowRef, NSPoint topLeft);
*/
@@ -311,12 +311,21 @@ func NewWindow(win Callbacks, opts *Options) error {
		// Window sizes is in unscaled screen coordinates, not device pixels.
		width = int(float32(width) / screenScale)
		height = int(float32(height) / screenScale)
		minWidth := cfg.Px(opts.MinWidth)
		minHeight := cfg.Px(opts.MinHeight)
		minWidth = int(float32(minWidth) / screenScale)
		minHeight = int(float32(minHeight) / screenScale)
		maxWidth := cfg.Px(opts.MaxWidth)
		maxHeight := cfg.Px(opts.MaxHeight)
		maxWidth = int(float32(maxWidth) / screenScale)
		maxHeight = int(float32(maxHeight) / screenScale)
		title := C.CString(opts.Title)
		defer C.free(unsafe.Pointer(title))
		errch <- nil
		win.SetDriver(w)
		w.w = win
		w.window = C.gio_createWindow(w.view, title, C.CGFloat(width), C.CGFloat(height))
		w.window = C.gio_createWindow(w.view, title, C.CGFloat(width), C.CGFloat(height),
			C.CGFloat(minWidth), C.CGFloat(minHeight), C.CGFloat(maxWidth), C.CGFloat(maxHeight))
		if nextTopLeft.x == 0 && nextTopLeft.y == 0 {
			// cascadeTopLeftFromPoint treats (0, 0) as a no-op,
			// and just returns the offset we need for the first window.
diff --git a/app/internal/window/os_macos.m b/app/internal/window/os_macos.m
index 9ff1540..4d3fbc4 100644
--- a/app/internal/window/os_macos.m
+++ b/app/internal/window/os_macos.m
@@ -124,7 +124,7 @@ void gio_makeKeyAndOrderFront(CFTypeRef windowRef) {
	[window makeKeyAndOrderFront:nil];
}

CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat width, CGFloat height) {
CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat width, CGFloat height, CGFloat minWidth, CGFloat minHeight, CGFloat maxWidth, CGFloat maxHeight) {
	@autoreleasepool {
		NSRect rect = NSMakeRect(0, 0, width, height);
		NSUInteger styleMask = NSTitledWindowMask |
@@ -133,9 +133,15 @@ CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat width,
			NSClosableWindowMask;

		NSWindow* window = [[NSWindow alloc] initWithContentRect:rect
													   styleMask:styleMask
														 backing:NSBackingStoreBuffered
														   defer:NO];
					styleMask:styleMask
					backing:NSBackingStoreBuffered
					defer:NO];
		if (minWidth > 0 || minHeight > 0) {
			window.minSize = NSMakeSize(minWidth, minHeight);
		}
		if (maxWidth > 0 || maxHeight > 0) {
			window.maxSize = NSMakeSize(maxWidth, maxHeight);
		}
		[window setAcceptsMouseMovedEvents:YES];
		window.title = [NSString stringWithUTF8String: title];
		NSView *view = (__bridge NSView *)viewRef;
-- 
2.27.0
Details
Message ID
<C3IPT0IF73OG.1IZ8L45QX9QRQ@testmac>
In-Reply-To
<20200616165230.1098143-1-sourcehut@sweatyballs.es> (view parent)
DKIM signature
pass
Download raw message
Missing "a" in the subject, use lowercase:

app/window,app/internal/window: allow ...

On Tue Jun 16, 2020 at 8:52 PM CEST, Jason wrote:
> Signed-off-by: Jason <sourcehut@sweatyballs.es>
> ---
>  app/internal/window/os_macos.go | 13 +++++++++++--
>  app/internal/window/os_macos.m  | 14 ++++++++++----
>  2 files changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/app/internal/window/os_macos.go b/app/internal/window/os_macos.go
> index fef2acd..26e03fc 100644
> --- a/app/internal/window/os_macos.go
> +++ b/app/internal/window/os_macos.go
> @@ -40,7 +40,7 @@ __attribute__ ((visibility ("hidden"))) CFTypeRef gio_readClipboard(void);
>  __attribute__ ((visibility ("hidden"))) void gio_writeClipboard(unichar *chars, NSUInteger length);
>  __attribute__ ((visibility ("hidden"))) void gio_setNeedsDisplay(CFTypeRef viewRef);
>  __attribute__ ((visibility ("hidden"))) void gio_appTerminate(void);
> -__attribute__ ((visibility ("hidden"))) CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat width, CGFloat height);
> +__attribute__ ((visibility ("hidden"))) CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat width, CGFloat height, CGFloat minWidth, CGFloat minHeight, CGFloat maxWidth, CGFloat maxHeight);
>  __attribute__ ((visibility ("hidden"))) void gio_makeKeyAndOrderFront(CFTypeRef windowRef);
>  __attribute__ ((visibility ("hidden"))) NSPoint gio_cascadeTopLeftFromPoint(CFTypeRef windowRef, NSPoint topLeft);
>  */
> @@ -311,12 +311,21 @@ func NewWindow(win Callbacks, opts *Options) error {
>  		// Window sizes is in unscaled screen coordinates, not device pixels.
>  		width = int(float32(width) / screenScale)
>  		height = int(float32(height) / screenScale)
> +		minWidth := cfg.Px(opts.MinWidth)
> +		minHeight := cfg.Px(opts.MinHeight)
> +		minWidth = int(float32(minWidth) / screenScale)
> +		minHeight = int(float32(minHeight) / screenScale)
> +		maxWidth := cfg.Px(opts.MaxWidth)
> +		maxHeight := cfg.Px(opts.MaxHeight)
> +		maxWidth = int(float32(maxWidth) / screenScale)
> +		maxHeight = int(float32(maxHeight) / screenScale)
>  		title := C.CString(opts.Title)
>  		defer C.free(unsafe.Pointer(title))
>  		errch <- nil
>  		win.SetDriver(w)
>  		w.w = win
> -		w.window = C.gio_createWindow(w.view, title, C.CGFloat(width), C.CGFloat(height))
> +		w.window = C.gio_createWindow(w.view, title, C.CGFloat(width), C.CGFloat(height),
> +			C.CGFloat(minWidth), C.CGFloat(minHeight), C.CGFloat(maxWidth), C.CGFloat(maxHeight))
>  		if nextTopLeft.x == 0 && nextTopLeft.y == 0 {
>  			// cascadeTopLeftFromPoint treats (0, 0) as a no-op,
>  			// and just returns the offset we need for the first window.
> diff --git a/app/internal/window/os_macos.m b/app/internal/window/os_macos.m
> index 9ff1540..4d3fbc4 100644
> --- a/app/internal/window/os_macos.m
> +++ b/app/internal/window/os_macos.m
> @@ -124,7 +124,7 @@ void gio_makeKeyAndOrderFront(CFTypeRef windowRef) {
>  	[window makeKeyAndOrderFront:nil];
>  }
>  
> -CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat width, CGFloat height) {
> +CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat width, CGFloat height, CGFloat minWidth, CGFloat minHeight, CGFloat maxWidth, CGFloat maxHeight) {
>  	@autoreleasepool {
>  		NSRect rect = NSMakeRect(0, 0, width, height);
>  		NSUInteger styleMask = NSTitledWindowMask |
> @@ -133,9 +133,15 @@ CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat width,
>  			NSClosableWindowMask;
>  
>  		NSWindow* window = [[NSWindow alloc] initWithContentRect:rect
> -													   styleMask:styleMask
> -														 backing:NSBackingStoreBuffered
> -														   defer:NO];
> +					styleMask:styleMask
> +					backing:NSBackingStoreBuffered
> +					defer:NO];

Don't change the indentation. This is supposedly the style for Obj-C
code.

> +		if (minWidth > 0 || minHeight > 0) {
> +			window.minSize = NSMakeSize(minWidth, minHeight);
> +		}
> +		if (maxWidth > 0 || maxHeight > 0) {
> +			window.maxSize = NSMakeSize(maxWidth, maxHeight);
> +		}
>  		[window setAcceptsMouseMovedEvents:YES];
>  		window.title = [NSString stringWithUTF8String: title];
>  		NSView *view = (__bridge NSView *)viewRef;
> -- 
> 2.27.0
Details
Message ID
<U461CQ.5GCJJ4X7485I1@sweatyballs.es>
In-Reply-To
<C3IPT0IF73OG.1IZ8L45QX9QRQ@testmac> (view parent)
DKIM signature
missing
Download raw message

On Tue, 16 Jun, 2020 at 19:50, Elias Naur <mail@eliasnaur.com> wrote:
> Missing "a" in the subject, use lowercase:
> 
> app/window,app/internal/window: allow ...
> 
> On Tue Jun 16, 2020 at 8:52 PM CEST, Jason wrote:
>>  Signed-off-by: Jason <sourcehut@sweatyballs.es>
>>  ---
>>   app/internal/window/os_macos.go | 13 +++++++++++--
>>   app/internal/window/os_macos.m  | 14 ++++++++++----
>>   2 files changed, 21 insertions(+), 6 deletions(-)
>> 
>>  diff --git a/app/internal/window/os_macos.go 
>> b/app/internal/window/os_macos.go
>>  index fef2acd..26e03fc 100644
>>  --- a/app/internal/window/os_macos.go
>>  +++ b/app/internal/window/os_macos.go
>>  @@ -40,7 +40,7 @@ __attribute__ ((visibility ("hidden"))) CFTypeRef 
>> gio_readClipboard(void);
>>   __attribute__ ((visibility ("hidden"))) void 
>> gio_writeClipboard(unichar *chars, NSUInteger length);
>>   __attribute__ ((visibility ("hidden"))) void 
>> gio_setNeedsDisplay(CFTypeRef viewRef);
>>   __attribute__ ((visibility ("hidden"))) void 
>> gio_appTerminate(void);
>>  -__attribute__ ((visibility ("hidden"))) CFTypeRef 
>> gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat 
>> width, CGFloat height);
>>  +__attribute__ ((visibility ("hidden"))) CFTypeRef 
>> gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat 
>> width, CGFloat height, CGFloat minWidth, CGFloat minHeight, CGFloat 
>> maxWidth, CGFloat maxHeight);
>>   __attribute__ ((visibility ("hidden"))) void 
>> gio_makeKeyAndOrderFront(CFTypeRef windowRef);
>>   __attribute__ ((visibility ("hidden"))) NSPoint 
>> gio_cascadeTopLeftFromPoint(CFTypeRef windowRef, NSPoint topLeft);
>>   */
>>  @@ -311,12 +311,21 @@ func NewWindow(win Callbacks, opts *Options) 
>> error {
>>   		// Window sizes is in unscaled screen coordinates, not device 
>> pixels.
>>   		width = int(float32(width) / screenScale)
>>   		height = int(float32(height) / screenScale)
>>  +		minWidth := cfg.Px(opts.MinWidth)
>>  +		minHeight := cfg.Px(opts.MinHeight)
>>  +		minWidth = int(float32(minWidth) / screenScale)
>>  +		minHeight = int(float32(minHeight) / screenScale)
>>  +		maxWidth := cfg.Px(opts.MaxWidth)
>>  +		maxHeight := cfg.Px(opts.MaxHeight)
>>  +		maxWidth = int(float32(maxWidth) / screenScale)
>>  +		maxHeight = int(float32(maxHeight) / screenScale)
>>   		title := C.CString(opts.Title)
>>   		defer C.free(unsafe.Pointer(title))
>>   		errch <- nil
>>   		win.SetDriver(w)
>>   		w.w = win
>>  -		w.window = C.gio_createWindow(w.view, title, C.CGFloat(width), 
>> C.CGFloat(height))
>>  +		w.window = C.gio_createWindow(w.view, title, C.CGFloat(width), 
>> C.CGFloat(height),
>>  +			C.CGFloat(minWidth), C.CGFloat(minHeight), C.CGFloat(maxWidth), 
>> C.CGFloat(maxHeight))
>>   		if nextTopLeft.x == 0 && nextTopLeft.y == 0 {
>>   			// cascadeTopLeftFromPoint treats (0, 0) as a no-op,
>>   			// and just returns the offset we need for the first window.
>>  diff --git a/app/internal/window/os_macos.m 
>> b/app/internal/window/os_macos.m
>>  index 9ff1540..4d3fbc4 100644
>>  --- a/app/internal/window/os_macos.m
>>  +++ b/app/internal/window/os_macos.m
>>  @@ -124,7 +124,7 @@ void gio_makeKeyAndOrderFront(CFTypeRef 
>> windowRef) {
>>   	[window makeKeyAndOrderFront:nil];
>>   }
>> 
>>  -CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title, 
>> CGFloat width, CGFloat height) {
>>  +CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title, 
>> CGFloat width, CGFloat height, CGFloat minWidth, CGFloat minHeight, 
>> CGFloat maxWidth, CGFloat maxHeight) {
>>   	@autoreleasepool {
>>   		NSRect rect = NSMakeRect(0, 0, width, height);
>>   		NSUInteger styleMask = NSTitledWindowMask |
>>  @@ -133,9 +133,15 @@ CFTypeRef gio_createWindow(CFTypeRef viewRef, 
>> const char *title, CGFloat width,
>>   			NSClosableWindowMask;
>> 
>>   		NSWindow* window = [[NSWindow alloc] initWithContentRect:rect
>>  -													   styleMask:styleMask
>>  -														 backing:NSBackingStoreBuffered
>>  -														   defer:NO];
>>  +					styleMask:styleMask
>>  +					backing:NSBackingStoreBuffered
>>  +					defer:NO];
> 
> Don't change the indentation. This is supposedly the style for Obj-C
> code.

Really? About 10 tabs of indentation? Is somebody at Apple having a 
spaces vs. tabs moment?

> 
>>  +		if (minWidth > 0 || minHeight > 0) {
>>  +			window.minSize = NSMakeSize(minWidth, minHeight);
>>  +		}
>>  +		if (maxWidth > 0 || maxHeight > 0) {
>>  +			window.maxSize = NSMakeSize(maxWidth, maxHeight);
>>  +		}
>>   		[window setAcceptsMouseMovedEvents:YES];
>>   		window.title = [NSString stringWithUTF8String: title];
>>   		NSView *view = (__bridge NSView *)viewRef;
>>  --
>>  2.27.0
> 

Any tips on how to make the changes without doing a git reset?
Details
Message ID
<C3IQFVJHNV4G.IK2OJMEBVPU7@testmac>
In-Reply-To
<U461CQ.5GCJJ4X7485I1@sweatyballs.es> (view parent)
DKIM signature
pass
Download raw message
On Tue Jun 16, 2020 at 10:02 PM CEST, Jason wrote:
>
>
> >>   		NSWindow* window = [[NSWindow alloc] initWithContentRect:rect
> >>  -													   styleMask:styleMask
> >>  -														 backing:NSBackingStoreBuffered
> >>  -														   defer:NO];
> >>  +					styleMask:styleMask
> >>  +					backing:NSBackingStoreBuffered
> >>  +					defer:NO];
> > 
> > Don't change the indentation. This is supposedly the style for Obj-C
> > code.
>
> Really? About 10 tabs of indentation? Is somebody at Apple having a 
> spaces vs. tabs moment?
>

I believe they're trying to match up the colons.

> > 
> >>  +		if (minWidth > 0 || minHeight > 0) {
> >>  +			window.minSize = NSMakeSize(minWidth, minHeight);
> >>  +		}
> >>  +		if (maxWidth > 0 || maxHeight > 0) {
> >>  +			window.maxSize = NSMakeSize(maxWidth, maxHeight);
> >>  +		}
> >>   		[window setAcceptsMouseMovedEvents:YES];
> >>   		window.title = [NSString stringWithUTF8String: title];
> >>   		NSView *view = (__bridge NSView *)viewRef;
> >>  --
> >>  2.27.0
> > 
>
> Any tips on how to make the changes without doing a git reset?

I usually commit the changes and use `git rebase -i origin/master` to
squash ("fixup") the fixup with the original commit.
Details
Message ID
<CAE_4BPCLuo=emL8ci0_01LmJopKz319zzf3m7sjG9ZRGDRtk+Q@mail.gmail.com>
In-Reply-To
<U461CQ.5GCJJ4X7485I1@sweatyballs.es> (view parent)
DKIM signature
missing
Download raw message
> Any tips on how to make the changes without doing a git reset?

"git commit --amend" is handy.  Usually used to edit a commit message,
you can also use it to update a commit with new changes.

https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---amend


On Tue, Jun 16, 2020 at 2:02 PM Jason <sourcehut@sweatyballs.es> wrote:
>
>
>
> On Tue, 16 Jun, 2020 at 19:50, Elias Naur <mail@eliasnaur.com> wrote:
> > Missing "a" in the subject, use lowercase:
> >
> > app/window,app/internal/window: allow ...
> >
> > On Tue Jun 16, 2020 at 8:52 PM CEST, Jason wrote:
> >>  Signed-off-by: Jason <sourcehut@sweatyballs.es>
> >>  ---
> >>   app/internal/window/os_macos.go | 13 +++++++++++--
> >>   app/internal/window/os_macos.m  | 14 ++++++++++----
> >>   2 files changed, 21 insertions(+), 6 deletions(-)
> >>
> >>  diff --git a/app/internal/window/os_macos.go
> >> b/app/internal/window/os_macos.go
> >>  index fef2acd..26e03fc 100644
> >>  --- a/app/internal/window/os_macos.go
> >>  +++ b/app/internal/window/os_macos.go
> >>  @@ -40,7 +40,7 @@ __attribute__ ((visibility ("hidden"))) CFTypeRef
> >> gio_readClipboard(void);
> >>   __attribute__ ((visibility ("hidden"))) void
> >> gio_writeClipboard(unichar *chars, NSUInteger length);
> >>   __attribute__ ((visibility ("hidden"))) void
> >> gio_setNeedsDisplay(CFTypeRef viewRef);
> >>   __attribute__ ((visibility ("hidden"))) void
> >> gio_appTerminate(void);
> >>  -__attribute__ ((visibility ("hidden"))) CFTypeRef
> >> gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat
> >> width, CGFloat height);
> >>  +__attribute__ ((visibility ("hidden"))) CFTypeRef
> >> gio_createWindow(CFTypeRef viewRef, const char *title, CGFloat
> >> width, CGFloat height, CGFloat minWidth, CGFloat minHeight, CGFloat
> >> maxWidth, CGFloat maxHeight);
> >>   __attribute__ ((visibility ("hidden"))) void
> >> gio_makeKeyAndOrderFront(CFTypeRef windowRef);
> >>   __attribute__ ((visibility ("hidden"))) NSPoint
> >> gio_cascadeTopLeftFromPoint(CFTypeRef windowRef, NSPoint topLeft);
> >>   */
> >>  @@ -311,12 +311,21 @@ func NewWindow(win Callbacks, opts *Options)
> >> error {
> >>              // Window sizes is in unscaled screen coordinates, not device
> >> pixels.
> >>              width = int(float32(width) / screenScale)
> >>              height = int(float32(height) / screenScale)
> >>  +           minWidth := cfg.Px(opts.MinWidth)
> >>  +           minHeight := cfg.Px(opts.MinHeight)
> >>  +           minWidth = int(float32(minWidth) / screenScale)
> >>  +           minHeight = int(float32(minHeight) / screenScale)
> >>  +           maxWidth := cfg.Px(opts.MaxWidth)
> >>  +           maxHeight := cfg.Px(opts.MaxHeight)
> >>  +           maxWidth = int(float32(maxWidth) / screenScale)
> >>  +           maxHeight = int(float32(maxHeight) / screenScale)
> >>              title := C.CString(opts.Title)
> >>              defer C.free(unsafe.Pointer(title))
> >>              errch <- nil
> >>              win.SetDriver(w)
> >>              w.w = win
> >>  -           w.window = C.gio_createWindow(w.view, title, C.CGFloat(width),
> >> C.CGFloat(height))
> >>  +           w.window = C.gio_createWindow(w.view, title, C.CGFloat(width),
> >> C.CGFloat(height),
> >>  +                   C.CGFloat(minWidth), C.CGFloat(minHeight), C.CGFloat(maxWidth),
> >> C.CGFloat(maxHeight))
> >>              if nextTopLeft.x == 0 && nextTopLeft.y == 0 {
> >>                      // cascadeTopLeftFromPoint treats (0, 0) as a no-op,
> >>                      // and just returns the offset we need for the first window.
> >>  diff --git a/app/internal/window/os_macos.m
> >> b/app/internal/window/os_macos.m
> >>  index 9ff1540..4d3fbc4 100644
> >>  --- a/app/internal/window/os_macos.m
> >>  +++ b/app/internal/window/os_macos.m
> >>  @@ -124,7 +124,7 @@ void gio_makeKeyAndOrderFront(CFTypeRef
> >> windowRef) {
> >>      [window makeKeyAndOrderFront:nil];
> >>   }
> >>
> >>  -CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title,
> >> CGFloat width, CGFloat height) {
> >>  +CFTypeRef gio_createWindow(CFTypeRef viewRef, const char *title,
> >> CGFloat width, CGFloat height, CGFloat minWidth, CGFloat minHeight,
> >> CGFloat maxWidth, CGFloat maxHeight) {
> >>      @autoreleasepool {
> >>              NSRect rect = NSMakeRect(0, 0, width, height);
> >>              NSUInteger styleMask = NSTitledWindowMask |
> >>  @@ -133,9 +133,15 @@ CFTypeRef gio_createWindow(CFTypeRef viewRef,
> >> const char *title, CGFloat width,
> >>                      NSClosableWindowMask;
> >>
> >>              NSWindow* window = [[NSWindow alloc] initWithContentRect:rect
> >>  -                                                                                                      styleMask:styleMask
> >>  -                                                                                                            backing:NSBackingStoreBuffered
> >>  -                                                                                                              defer:NO];
> >>  +                                   styleMask:styleMask
> >>  +                                   backing:NSBackingStoreBuffered
> >>  +                                   defer:NO];
> >
> > Don't change the indentation. This is supposedly the style for Obj-C
> > code.
>
> Really? About 10 tabs of indentation? Is somebody at Apple having a
> spaces vs. tabs moment?
>
> >
> >>  +           if (minWidth > 0 || minHeight > 0) {
> >>  +                   window.minSize = NSMakeSize(minWidth, minHeight);
> >>  +           }
> >>  +           if (maxWidth > 0 || maxHeight > 0) {
> >>  +                   window.maxSize = NSMakeSize(maxWidth, maxHeight);
> >>  +           }
> >>              [window setAcceptsMouseMovedEvents:YES];
> >>              window.title = [NSString stringWithUTF8String: title];
> >>              NSView *view = (__bridge NSView *)viewRef;
> >>  --
> >>  2.27.0
> >
>
> Any tips on how to make the changes without doing a git reset?
>
>
Details
Message ID
<CAE_4BPCdHuJihZsUQ-BYYyNjJ0KW7LfO0k_7VbyG2hsi7tF2AQ@mail.gmail.com>
In-Reply-To
<U461CQ.5GCJJ4X7485I1@sweatyballs.es> (view parent)
DKIM signature
missing
Download raw message
> Any tips on how to make the changes without doing a git reset?

"git commit --amend" is handy.  Usually used to edit a commit message,
you can also use it to update a commit with new changes.

https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---amend

Resending due to error sending to Jason's address; hopefully this one
works better.  The error was:

The response from the remote server was:
554 5.7.1 Mail appears to be unsolicited -- send error reports to
postmaster@sweatyballs.es
Review patch Export thread (mbox)