[PATCH gio v2] app: change background for js

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

2 2

[PATCH gio v2] app: change background for js

Paulo Melo

Details

Message ID: <20210217204038.13465-1-paulo.durrer.melo@gmail.com>
DKIM signature: missing

Download raw message

9 months ago

Patch: +2 -0

Default window background is white.
JS default background is transparent black.

Signed-off-by: Paulo Melo <paulo.durrer.melo@gmail.com>
---
 app/loop.go | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/loop.go b/app/loop.go
index 0bf89fe..32b579e 100644
--- a/app/loop.go
+++ b/app/loop.go
@@ -87,6 +87,8 @@ func (l *renderLoop) renderLoop(ctx window.Context) error {
 			case frame := <-l.frames:
 				ctx.Lock()
 				if runtime.GOOS == "js" {
+					// Use transparent black when Gio is embedded, to allow mixing of Gio and
+					// foreign content below.
 					g.Clear(color.NRGBA{A: 0x00, R: 0x00, G: 0x00, B: 0x00})
 				} else {
 					g.Clear(color.NRGBA{A: 0xff, R: 0xff, G: 0xff, B: 0xff})
-- 
2.26.2

[gio/patches] build failed

builds.sr.ht

Details

Message ID: <C9C3JMRNE9AC.N2WIUS5LGLWV@cirno2>
In-Reply-To: <20210217204038.13465-1-paulo.durrer.melo@gmail.com> (view parent)
DKIM signature: missing

Download raw message

9 months ago

gio/patches: FAILED in 2m22s

[app: change background for js][0] v2 from [Paulo Melo][1]

[0]: https://lists.sr.ht/~eliasnaur/gio-patches/patches/20341
[1]: paulo.durrer.melo@gmail.com

✗ #428941 FAILED gio/patches/openbsd.yml https://builds.sr.ht/~eliasnaur/job/428941
✗ #428938 FAILED gio/patches/apple.yml   https://builds.sr.ht/~eliasnaur/job/428938
✗ #428940 FAILED gio/patches/linux.yml   https://builds.sr.ht/~eliasnaur/job/428940
✗ #428939 FAILED gio/patches/freebsd.yml https://builds.sr.ht/~eliasnaur/job/428939

Elias Naur

Details

Message ID: <C9C3W8H9FORC.3DS62NULD7K9@testmac>
In-Reply-To: <20210217204038.13465-1-paulo.durrer.melo@gmail.com> (view parent)
DKIM signature: fail

Download raw message

9 months ago

DKIM signature: fail

Please squash and send the combined patch. Thanks, and sorry for the
trouble.

On Wed Feb 17, 2021 at 21:40 CET, Paulo Melo wrote:
> Default window background is white.
> JS default background is transparent black.
>
> Signed-off-by: Paulo Melo <paulo.durrer.melo@gmail.com>
> ---
>  app/loop.go | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/app/loop.go b/app/loop.go
> index 0bf89fe..32b579e 100644
> --- a/app/loop.go
> +++ b/app/loop.go
> @@ -87,6 +87,8 @@ func (l *renderLoop) renderLoop(ctx window.Context) error {
>  			case frame := <-l.frames:
>  				ctx.Lock()
>  				if runtime.GOOS == "js" {
> +					// Use transparent black when Gio is embedded, to allow mixing of Gio and
> +					// foreign content below.
>  					g.Clear(color.NRGBA{A: 0x00, R: 0x00, G: 0x00, B: 0x00})
>  				} else {
>  					g.Clear(color.NRGBA{A: 0xff, R: 0xff, G: 0xff, B: 0xff})
> -- 
> 2.26.2