Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
In-Reply-To: <20200113114355.17505-1-mural@ctli.io>
Date: Mon, 13 Jan 2020 14:18:23 +0100
Cc: "mural" <mural@ctli.io>
Subject: Re: [gio v1] app/internal/log: add logger for Windows DebugView
From: "Elias Naur" <mail@eliasnaur.com>
To: "mural" <mural@ctli.io>, <~eliasnaur/gio-patches@lists.sr.ht>
Message-Id: <BZUOYL6MJOBS.76S8LRPRL6OQ@testmac>

On Mon Jan 13, 2020 at 7:43 PM, mural wrote:
> Signed-off-by: mural <mural@ctli.io>
> ---
> According to
> https://docs.microsoft.com/en-us/windows/console/getstdhandle,
> GetStdHandle would return NULL if there is no associated standard
> handles.
> So we chack 0 as well.
>
>=20
> app/internal/log/log_windows.go | 34 +++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 app/internal/log/log_windows.go
>
>=20
> diff --git a/app/internal/log/log_windows.go
> b/app/internal/log/log_windows.go
> new file mode 100644
> index 0000000..0642919
> --- /dev/null
> +++ b/app/internal/log/log_windows.go
> @@ -0,0 +1,34 @@
> + // Windows DebugView already includes timestamps.
> + if syscall.Stderr =3D=3D 0 || syscall.Stderr =3D=3D syscall.InvalidHand=
le {

Your commit message implies that 0 is returned for unattached I/O. If
so, please remove the InvalidHandle check which will only confuse future
readers.