~eliasnaur/gio

18 2

UI is blinking when a window is resizing

Details
Message ID
<71126691573033779@iva7-56e9317134d0.qloud-c.yandex.net>
DKIM signature
pass
Download raw message
Windows7, Arch (X11)

On the latest gio version, UI is blinking when i changing a window's size
Details
Message ID
<CAMAFT9W_Km8ZbinPSB8DJbqCgvXCXu+qFTRGvenx7kmv-V=dWQ@mail.gmail.com>
In-Reply-To
<71126691573033779@iva7-56e9317134d0.qloud-c.yandex.net> (view parent)
DKIM signature
pass
Download raw message
On Wed, Nov 6, 2019 at 10:49 AM <fralx@yandex.ru> wrote:
>
> Windows7, Arch (X11)
>
> On the latest gio version, UI is blinking when i changing a window's size

On both Windows 7 and Arch (X11)? Does it blink on resize when using the
Wayland backend?

Is this a regression? If so, please state which version introduced blinking.

-- elias
Details
Message ID
<1202351573035593@vla5-5336eea6ea62.qloud-c.yandex.net>
In-Reply-To
<CAMAFT9W_Km8ZbinPSB8DJbqCgvXCXu+qFTRGvenx7kmv-V=dWQ@mail.gmail.com> (view parent)
DKIM signature
pass
Download raw message
Yes on both. 
I have not the possibility to test Wayland. 
I can't say which commit broke the UI but on windows 5c0f1ed95466 is working without blinking.  

06.11.2019, 13:00, "Elias Naur" <mail@eliasnaur.com>:
> On Wed, Nov 6, 2019 at 10:49 AM <fralx@yandex.ru> wrote:
>>  Windows7, Arch (X11)
>>
>>  On the latest gio version, UI is blinking when i changing a window's size
>
> On both Windows 7 and Arch (X11)? Does it blink on resize when using the
> Wayland backend?
>
> Is this a regression? If so, please state which version introduced blinking.
>
> -- elias
Details
Message ID
<CAMAFT9WwsX8TfhhHVPoDFqBgR3pPy-2AdUUcGu7eC1bckpRFGg@mail.gmail.com>
In-Reply-To
<1202351573035593@vla5-5336eea6ea62.qloud-c.yandex.net> (view parent)
DKIM signature
pass
Download raw message
On Wed, Nov 6, 2019 at 11:19 AM <fralx@yandex.ru> wrote:
>
> Yes on both.
> I have not the possibility to test Wayland.
> I can't say which commit broke the UI but on windows 5c0f1ed95466 is working without blinking.
>

Can you try the latest version
(90e25ed52fb562f41bc351a6460aaa79e7cdaecd)? I pushed a potential fix.

-- elias
Details
Message ID
<1298441573036787@vla1-3991b5027d7d.qloud-c.yandex.net>
In-Reply-To
<CAMAFT9WwsX8TfhhHVPoDFqBgR3pPy-2AdUUcGu7eC1bckpRFGg@mail.gmail.com> (view parent)
DKIM signature
pass
Download raw message
I have tested, result the same UI is blinking :( 

06.11.2019, 13:27, "Elias Naur" <mail@eliasnaur.com>:
> On Wed, Nov 6, 2019 at 11:19 AM <fralx@yandex.ru> wrote:
>>  Yes on both.
>>  I have not the possibility to test Wayland.
>>  I can't say which commit broke the UI but on windows 5c0f1ed95466 is working without blinking.
>
> Can you try the latest version
> (90e25ed52fb562f41bc351a6460aaa79e7cdaecd)? I pushed a potential fix.
>
> -- elias
Details
Message ID
<CAMAFT9Vm52YLBn19Y0_SxU=PBvpwMZ85kH6adeRRKM4T=1HQ_w@mail.gmail.com>
In-Reply-To
<1298441573036787@vla1-3991b5027d7d.qloud-c.yandex.net> (view parent)
DKIM signature
pass
Download raw message
On Wed, Nov 6, 2019 at 11:39 AM <fralx@yandex.ru> wrote:
>
> I have tested, result the same UI is blinking :(
>

That's too bad. Commit 5c0f1ed... is quite far back. Can I persuade
you to use `git bisect` to isolate the
commit that introduced flickering?

-- elias
Details
Message ID
<75977301573039155@vla1-c477e3898c96.qloud-c.yandex.net>
In-Reply-To
<CAMAFT9Vm52YLBn19Y0_SxU=PBvpwMZ85kH6adeRRKM4T=1HQ_w@mail.gmail.com> (view parent)
DKIM signature
pass
Download raw message
Ok, i will try to find  the commit that introduced flickering

06.11.2019, 13:55, "Elias Naur" <mail@eliasnaur.com>:
> On Wed, Nov 6, 2019 at 11:39 AM <fralx@yandex.ru> wrote:
>>  I have tested, result the same UI is blinking :(
>
> That's too bad. Commit 5c0f1ed... is quite far back. Can I persuade
> you to use `git bisect` to isolate the
> commit that introduced flickering?
>
> -- elias
Details
Message ID
<186821573040937@vla4-9d01d86ae0b7.qloud-c.yandex.net>
In-Reply-To
<75977301573039155@vla1-c477e3898c96.qloud-c.yandex.net> (view parent)
DKIM signature
pass
Download raw message
Unfortunately, i can't check all commits because  513b19b2c5746192dcfd168239312e9954812cf7 not works on windows7 as i wrote early.
Last good commit is 5eeaadccead599f61c41bf3491a26b56082f3411   

06.11.2019, 14:19, "fralx@yandex.ru" <fralx@yandex.ru>:
> Ok, i will try to find the commit that introduced flickering
>
> 06.11.2019, 13:55, "Elias Naur" <mail@eliasnaur.com>:
>>  On Wed, Nov 6, 2019 at 11:39 AM <fralx@yandex.ru> wrote:
>>>   I have tested, result the same UI is blinking :(
>>
>>  That's too bad. Commit 5c0f1ed... is quite far back. Can I persuade
>>  you to use `git bisect` to isolate the
>>  commit that introduced flickering?
>>
>>  -- elias
Details
Message ID
<BY8WC7VYSMH4.56PU3VW02187@testmac>
In-Reply-To
<186821573040937@vla4-9d01d86ae0b7.qloud-c.yandex.net> (view parent)
DKIM signature
pass
Download raw message
On Wed Nov 6, 2019 at 2:48 PM  wrote:
> Unfortunately, i can't check all commits because  513b19b2c5746192dcfd168239312e9954812cf7 not works on windows7 as i wrote early.
> Last good commit is 5eeaadccead599f61c41bf3491a26b56082f3411   
> 

If you're using git bisect, you can issue a `git biset skip` to skip
an unusable commit.

One commit that stands out is 60e4cca934eaa4713fdf693ac4afcacc43f7b632,
which ironically fixes resize flickering (on X11).

I can't reproduce the flickering on my Windows 10, so can you try a
revert of just 60e4cca93 locally?

-- elias
Details
Message ID
<70299371573053903@myt4-a1257bff88cb.qloud-c.yandex.net>
In-Reply-To
<BY8WC7VYSMH4.56PU3VW02187@testmac> (view parent)
DKIM signature
pass
Download raw message
I have reproduced the flickering on Windows 8
1438e504cc95bb9f5c8c7adafb03101296381746 is the first bad commit 

06.11.2019, 17:50, "Elias Naur" <mail@eliasnaur.com>:
> On Wed Nov 6, 2019 at 2:48 PM wrote:
>>  Unfortunately, i can't check all commits because 513b19b2c5746192dcfd168239312e9954812cf7 not works on windows7 as i wrote early.
>>  Last good commit is 5eeaadccead599f61c41bf3491a26b56082f3411
>
> If you're using git bisect, you can issue a `git biset skip` to skip
> an unusable commit.
>
> One commit that stands out is 60e4cca934eaa4713fdf693ac4afcacc43f7b632,
> which ironically fixes resize flickering (on X11).
>
> I can't reproduce the flickering on my Windows 10, so can you try a
> revert of just 60e4cca93 locally?
>
> -- elias
Details
Message ID
<BY8X7AP9ZV4B.RYW1TJH6RNQR@toolbox>
In-Reply-To
<70299371573053903@myt4-a1257bff88cb.qloud-c.yandex.net> (view parent)
DKIM signature
pass
Download raw message
On Wed Nov 6, 2019 at 6:25 PM  wrote:
> I have reproduced the flickering on Windows 8
> 1438e504cc95bb9f5c8c7adafb03101296381746 is the first bad commit 
> 

Thanks. 1438e504... is the commit where go.mod is updated. Can you verify the offending commit by running

	$ git checkout master
	$ git revert 60e4cca934eaa4713fdf693ac4afcacc43f7b632
	$ go mod edit -replace gioui.org=../              # to use the local version of gioui.org
	$ cd example
	$ go run ./kitchen

?

If it's convenient to you, you can join on the #gioui channel on gophers.slack.com for faster
turnaround.

-- elias
Details
Message ID
<BY8YLAJNNBYK.JD0THDKDCRY8@toolbox>
In-Reply-To
<70299371573053903@myt4-a1257bff88cb.qloud-c.yandex.net> (view parent)
DKIM signature
pass
Download raw message
On Wed Nov 6, 2019 at 6:25 PM  wrote:
> I have reproduced the flickering on Windows 8
> 1438e504cc95bb9f5c8c7adafb03101296381746 is the first bad commit 
> 

I think I found (one) reason for the X11 and Windows flickering.
Please try the latest commit (c3533c3f8421a0f1ccc8b691e36e708b23e022a6).

-- elias
Details
Message ID
<70598541573066165@myt5-094cfe5c1616.qloud-c.yandex.net>
In-Reply-To
<BY8YLAJNNBYK.JD0THDKDCRY8@toolbox> (view parent)
DKIM signature
pass
Download raw message
Unfortunately, still flickering. 
If I make a video of how this happens, will it be useful?

06.11.2019, 19:36, "Elias Naur" <mail@eliasnaur.com>:
> On Wed Nov 6, 2019 at 6:25 PM wrote:
>>  I have reproduced the flickering on Windows 8
>>  1438e504cc95bb9f5c8c7adafb03101296381746 is the first bad commit
>
> I think I found (one) reason for the X11 and Windows flickering.
> Please try the latest commit (c3533c3f8421a0f1ccc8b691e36e708b23e022a6).
>
> -- elias
Details
Message ID
<71707041573084690@sas2-d4e8b88e2941.qloud-c.yandex.net>
In-Reply-To
<70598541573066165@myt5-094cfe5c1616.qloud-c.yandex.net> (view parent)
DKIM signature
pass
Download raw message
On Arch Linux flickering is disappeared, but on Windows 7 still exists.

06.11.2019, 21:49, "fralx@yandex.ru" <fralx@yandex.ru>:
> Unfortunately, still flickering.
> If I make a video of how this happens, will it be useful?
>
> 06.11.2019, 19:36, "Elias Naur" <mail@eliasnaur.com>:
>>  On Wed Nov 6, 2019 at 6:25 PM wrote:
>>>   I have reproduced the flickering on Windows 8
>>>   1438e504cc95bb9f5c8c7adafb03101296381746 is the first bad commit
>>
>>  I think I found (one) reason for the X11 and Windows flickering.
>>  Please try the latest commit (c3533c3f8421a0f1ccc8b691e36e708b23e022a6).
>>
>>  -- elias
Details
Message ID
<74345661573087628@iva3-d9cc776f5dad.qloud-c.yandex.net>
In-Reply-To
<BY8X7AP9ZV4B.RYW1TJH6RNQR@toolbox> (view parent)
DKIM signature
pass
Download raw message
After revert 60e4cca934eaa4713fdf693ac4afcacc43f7b632 flickering on windows is gone away

06.11.2019, 18:31, "Elias Naur" <mail@eliasnaur.com>:
> On Wed Nov 6, 2019 at 6:25 PM wrote:
>>  I have reproduced the flickering on Windows 8
>>  1438e504cc95bb9f5c8c7adafb03101296381746 is the first bad commit
>
> Thanks. 1438e504... is the commit where go.mod is updated. Can you verify the offending commit by running
>
>         $ git checkout master
>         $ git revert 60e4cca934eaa4713fdf693ac4afcacc43f7b632
>         $ go mod edit -replace gioui.org=../ # to use the local version of gioui.org
>         $ cd example
>         $ go run ./kitchen
>
> ?
>
> If it's convenient to you, you can join on the #gioui channel on gophers.slack.com for faster
> turnaround.
>
> -- elias
Details
Message ID
<BY9KYQ0QITXD.1UEYWOLRNQFBC@toolbox>
In-Reply-To
<71707041573084690@sas2-d4e8b88e2941.qloud-c.yandex.net> (view parent)
DKIM signature
pass
Download raw message
On Thu Nov 7, 2019 at 2:58 AM  wrote:
> On Arch Linux flickering is disappeared, but on Windows 7 still exists.
> 
> 06.11.2019, 21:49, "fralx@yandex.ru" <fralx@yandex.ru>:
> > Unfortunately, still flickering.
> > If I make a video of how this happens, will it be useful?
> >
> > 06.11.2019, 19:36, "Elias Naur" <mail@eliasnaur.com>:
> >>  On Wed Nov 6, 2019 at 6:25 PM wrote:
> >>>   I have reproduced the flickering on Windows 8
> >>>   1438e504cc95bb9f5c8c7adafb03101296381746 is the first bad commit
> >>
> >>  I think I found (one) reason for the X11 and Windows flickering.
> >>  Please try the latest commit (c3533c3f8421a0f1ccc8b691e36e708b23e022a6).
> >>
> >>  -- elias

Does the attached patch fix the flickering on Windows? Remember to use
`go mod edit -replace ...` to ensure the patches version is used by your test program.

-- elias
Details
Message ID
<BY9KZ8DQ9BMW.3XB0237F8WD3@toolbox>
In-Reply-To
<70598541573066165@myt5-094cfe5c1616.qloud-c.yandex.net> (view parent)
DKIM signature
pass
Download raw message
On Wed Nov 6, 2019 at 9:49 PM  wrote:
> Unfortunately, still flickering. 
> If I make a video of how this happens, will it be useful?
> 

Sure, if it's not too much trouble, I'd like to see the flickering
effect.

-- elias
Details
Message ID
<3460741573144193@vla1-a4c6eab2e6c6.qloud-c.yandex.net>
In-Reply-To
<BY9KYQ0QITXD.1UEYWOLRNQFBC@toolbox> (view parent)
DKIM signature
pass
Download raw message
Yes. This patch fixes the flickering on Windows

07.11.2019, 13:08, "Elias Naur" <mail@eliasnaur.com>:
> On Thu Nov 7, 2019 at 2:58 AM wrote:
>>  On Arch Linux flickering is disappeared, but on Windows 7 still exists.
>>
>>  06.11.2019, 21:49, "fralx@yandex.ru" <fralx@yandex.ru>:
>>  > Unfortunately, still flickering.
>>  > If I make a video of how this happens, will it be useful?
>>  >
>>  > 06.11.2019, 19:36, "Elias Naur" <mail@eliasnaur.com>:
>>  >>  On Wed Nov 6, 2019 at 6:25 PM wrote:
>>  >>>   I have reproduced the flickering on Windows 8
>>  >>>   1438e504cc95bb9f5c8c7adafb03101296381746 is the first bad commit
>>  >>
>>  >>  I think I found (one) reason for the X11 and Windows flickering.
>>  >>  Please try the latest commit (c3533c3f8421a0f1ccc8b691e36e708b23e022a6).
>>  >>
>>  >>  -- elias
>
> Does the attached patch fix the flickering on Windows? Remember to use
> `go mod edit -replace ...` to ensure the patches version is used by your test program.
>
> -- elias
Details
Message ID
<BY9USR3K62YJ.2N8TWU7C5J96T@toolbox>
In-Reply-To
<3460741573144193@vla1-a4c6eab2e6c6.qloud-c.yandex.net> (view parent)
DKIM signature
pass
Download raw message
On Thu Nov 7, 2019 at 7:29 PM  wrote:
> Yes. This patch fixes the flickering on Windows
> 

Thanks, the patch is now merged.