Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
In-Reply-To: <20191106133921.24319-1-db047h@gmail.com>
Date: Wed, 06 Nov 2019 15:02:35 +0100
To: "Denis Bernard" <db047h@gmail.com>, <~eliasnaur/gio@lists.sr.ht>
Cc: "Denis Bernard" <db047h@gmail.com>
Subject: Re: [PATCH] app/internal/window: Fix keyboard handling on X11
From: "Elias Naur" <mail@eliasnaur.com>
Message-Id: <BY8VBDNS1Y7H.2TXYFB30TTQ02@toolbox>

On Wed Nov 6, 2019 at 2:39 PM Denis Bernard wrote:
> ---
>  app/internal/window/os_x11.go | 62 ++++++++++++++++++++---------------
>  1 file changed, 35 insertions(+), 27 deletions(-)
>=20
> diff --git a/app/internal/window/os_x11.go b/app/internal/window/os_x11.g=
o
> index 2abb1bd..d8d6ceb 100644
> --- a/app/internal/window/os_x11.go
> +++ b/app/internal/window/os_x11.go
> @@ -408,6 +407,10 @@ func (e *xEvent) getUint(off int) C.uint {
>  	return *(*C.uint)(unsafe.Pointer(uintptr(unsafe.Pointer(e)) + uintptr(o=
ff)))
>  }
> =20
> +func (e *xEvent) setUint(off int, v C.uint) {
> +	*(*C.uint)(unsafe.Pointer(uintptr(unsafe.Pointer(e)) + uintptr(off))) =
=3D v

I don't like unrestricted pointer arithmetic, even internally, and I'm not =
even sure
the Go unsafe rules allow it. How about reading out the struct directly:

func (e *xEvent) asKeyEvent() *C.XKeyEvent {
	return (*C.XKeyEvent)(unsafe.Pointer(e))?
}

In fact, I believe you can get rid of xEvent altogether:

	var evt *C.XEvent

	kevt :=3D (*C.XKeyEvent)(unsafe.Pointer(evt)

	kevt.state &^=3D (C.uint(C.ControlMask) | C.uint(C.ShiftMask))

> +}
> +
>  func (e *xEvent) getUlong(off int) C.ulong {
>  	return *(*C.ulong)(unsafe.Pointer(uintptr(unsafe.Pointer(e)) + uintptr(=
off)))

Same.