~eliasnaur/gio

Re: [PATCH 2/2] app/permission: add storage permissions

Details
Message ID
<BYL3YSWT772W.2MTW89BO0UPL@toolbox>
DKIM signature
pass
Download raw message
On Wed Nov 20, 2019 at 6:00 PM Gregory Pomerantz wrote:
> On 11/20/19 5:44 PM, Elias Naur wrote:
> > Add package documentation.
> I'm not sure if we had decided where was the best place for this -- 
> there is general documentation already in app/doc.go but we elected not 
> to list all permissions individually as those can be seen by browsing 
> the package hierarchy.

Indeed, but I'd still like to document exactly which native permission(s)
importing the package implies. Please also add the documentation for the
other permission packages.

Finally, I think the "permissions" section in app/doc.go should be moved
to app/permission/doc.go. Empty packages are a code smell, and the
app/permission package documentation should describe the general
functinoality.