go.work file in example repo

3 2

go.work file in example repo

Reto <reto@slightlybroken.com>

Details

Message ID: <cxhzv2tnebdlqjw6zdqahjtc2raenjqjtqscpgn6redvrut5li@mkkd2co4kpp5>
Sender timestamp: 1737539369
DKIM signature: pass

Download raw message

a month ago

Heya,
Not sure if this was intentional, but you added a go.work file into
the example repo (https://git.sr.ht/~eliasnaur/gio-example/) with 

commit cc20163cce554b5cbbc4b2cf0d988604af7de373
Author: Chris Waldon <christopher.waldon.dev@gmail.com>
Date:   Tue Jan 14 11:00:23 2025 -0500

  go.*: update to gio v0.8.0

  Signed-off-by: Chris Waldon <christopher.waldon.dev@gmail.com>

That breaks builds, as most folks won't have ../gio et al.

In my case it lead to *very* funny module errors as I do in fact
have a gio repo at .., but a very outdated version as I haven't pulled.
That leads to errors along those lines:

../gio/font/opentype/opentype.go:20:2: no required module provides package github.com/go-text/typesetting/opentype/api/font; to add it:
        cd /home/reto/sourcecode/gio
        go get github.com/go-text/typesetting/opentype/api/font

That's a tad non obvious and probably not very great for a repo intended
for newbies to the lib like me ;)

If it was intentional, because you want to make sure folks get the right
gio version for non tagged commits, you might want to make it a git submodule
or such.

Cheers,
Reto

Chris Waldon <christopher.waldon.dev@gmail.com>

Details

Message ID: <CAFcc3FQLutwja9v8om5UAh=BoxKTbn-DqDdx8WHqOqCYQvfrUQ@mail.gmail.com>
In-Reply-To: <cxhzv2tnebdlqjw6zdqahjtc2raenjqjtqscpgn6redvrut5li@mkkd2co4kpp5> (view parent)
Sender timestamp: 1737525653
DKIM signature: pass

Download raw message

a month ago

Hi Reto,

> Not sure if this was intentional, but you added a go.work file into
> the example repo (https://git.sr.ht/~eliasnaur/gio-example/) with
>
> commit cc20163cce554b5cbbc4b2cf0d988604af7de373
> Author: Chris Waldon <christopher.waldon.dev@gmail.com>
> Date:   Tue Jan 14 11:00:23 2025 -0500

:facepalm: It was not intentional. Thank you very much for bringing it
to my attention. I have removed it, added work files to the gitignore,
and tagged v0.8.1.

Thank you,
Chris

Elias Naur <mail@eliasnaur.com>

Details

Message ID: <CAMAFT9UhJKDQMVkn2bO_QZoWH6L3g9mPHc7FJCfPcPcMzU-1=A@mail.gmail.com>
In-Reply-To: <CAFcc3FQLutwja9v8om5UAh=BoxKTbn-DqDdx8WHqOqCYQvfrUQ@mail.gmail.com> (view parent)
Sender timestamp: 1737881878
DKIM signature: pass

Download raw message

a month ago

On Wed, 22 Jan 2025 at 12:01, Chris Waldon
<christopher.waldon.dev@gmail.com> wrote:
>
> Hi Reto,
>
> > Not sure if this was intentional, but you added a go.work file into
> > the example repo (https://git.sr.ht/~eliasnaur/gio-example/) with
> >
> > commit cc20163cce554b5cbbc4b2cf0d988604af7de373
> > Author: Chris Waldon <christopher.waldon.dev@gmail.com>
> > Date:   Tue Jan 14 11:00:23 2025 -0500
>
> :facepalm: It was not intentional. Thank you very much for bringing it
> to my attention. I have removed it, added work files to the gitignore,
> and tagged v0.8.1.
>

Thanks for doing this. FWIW, I'm weakly against tracking user-generated
files in the repository gitignore. Should IDE files be added there as well?
I find it better to just add them to my local (yet project-global) gitignore
configuration.

Elias

Chris Waldon <christopher.waldon.dev@gmail.com>

Details

Message ID: <CAFcc3FRsrEi=3ya2MXrEs_Rddd9=MvqrP3Shs4JnC-erFzCk3w@mail.gmail.com>
In-Reply-To: <CAMAFT9UhJKDQMVkn2bO_QZoWH6L3g9mPHc7FJCfPcPcMzU-1=A@mail.gmail.com> (view parent)
Sender timestamp: 1738082231
DKIM signature: pass

Download raw message

a month ago

> Thanks for doing this. FWIW, I'm weakly against tracking user-generated
> files in the repository gitignore. Should IDE files be added there as well?
> I find it better to just add them to my local (yet project-global) gitignore
> configuration.

That's fair; I've switched to this approach and dropped the ignorefile.

Cheers,
Chris