~eliasnaur/gio

op/paint: make documentation of Line clearer v1 PROPOSED

Thanks, merged.
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~eliasnaur/gio/patches/8971/mbox | git am -3
Learn more about email & git

[PATCH] op/paint: make documentation of Line clearer Export this patch

aarzilli
The movement is not to an absolute coordinate but by a delta relative
to the current position of the pen.
---
 op/paint/path.go | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/op/paint/path.go b/op/paint/path.go
index 73f3fab..225c8b9 100644
--- a/op/paint/path.go
+++ b/op/paint/path.go
@@ -65,9 +65,9 @@ func (p *Path) end() {
 	p.contour++
 }
 
-// Line records a line from the pen to end.
-func (p *Path) Line(to f32.Point) {
-	to = to.Add(p.pen)
+// Line moves the pen by the amount specified by delta, recording a line.
+func (p *Path) Line(delta f32.Point) {
+	to := delta.Add(p.pen)
 	p.lineTo(to)
 }
 
-- 
2.17.1
Thanks, merged.
View this thread in the archives