> +const (
> +	ON_CLOSE = iota
> +)

Go style would be OnClose.

I'm not a fan of this patch. Is it really needed? What's the
motivation? Do we really need to embrace callbacks like this?

If we really need to, I'd much rather have a signal type (similar to
Wayland's wl_signal) which tracks only a single signal type. Having
this int seems very error-prone.

---
 listssrht/process.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/listssrht/process.py b/listssrht/process.py
index 794d746783cd..bbdda0f45c0d 100644
--- a/listssrht/process.py
+++ b/listssrht/process.py
@@ -299,6 +299,7 @@ Feel free to reply to this email if you have any questions.""".format(
     reply["To"] = mail["From"]
     reply["From"] = "mailer@" + cfg("lists.sr.ht", "posting-domain")
     reply["In-Reply-To"] = mail["Message-ID"]
+    reply["Auto-Submitted"] = "auto-replied"
     reply["Subject"] = "Re: " + (
[message trimmed]

The current code doesn't drop auto-submitted replies, it only drops
auto-generated messages (that are not a direct reply to another message).
See [1].

[1]: https://tools.ietf.org/html/rfc3834#section-5.1

Closes: https://todo.sr.ht/~sircmpwn/lists.sr.ht/124
---
 listssrht/process.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/listssrht/process.py b/listssrht/process.py
index fdd83906b72d..794d746783cd 100644
--- a/listssrht/process.py
[message trimmed]

This lets smtplib deal with choosing the right message formatting based on the
remote server's capabilities.
---
 listssrht/process.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/listssrht/process.py b/listssrht/process.py
index bbdda0f45c0d..96c429c7b2cc 100644
--- a/listssrht/process.py
+++ b/listssrht/process.py
@@ -505,8 +505,7 @@ def send_error_for(mail, error):
     sender = parseaddr(mail["From"])
     if smtp_user and smtp_password:
         smtp.login(smtp_user, smtp_password)
[message trimmed]

Pushed, thanks!

To github.com:emersion/go-message
   d512711c7be7..9e53e1db5d08  master -> master

On Friday, August 2, 2019 5:23 PM, Ben Burwell <ben@benburwell.com> wrote:

> Ah, good catch about the header comment!
>
> If this is being fixed upstream, I suppose it does not make sense to
> patch it in go-message. Though, it doesn't look like that CL has been
> applied yet and since go 1.13 is frozen we won't see it until at least
> February 2020 with 1.14. In the meantime, I have a few broken messages
> in aerc, so I'm not quite sure what to do about that. Doesn't seem like
> this is affecting too many people based on the activity on that github
> issue, so maybe I'll just keep it patched locally until go is fixed.

I'd be interested by a patch in go-message. I think there are cases
(apart from Date and addresses) in which we should ignore CFWS anyway.

Seems to me like this is a header field comment (so there could be
anything inside the parentheses).

See [1] for the definition of CFWS and [2] for the definition of
date-time inside Date header fields:

    date-time       =   [ day-of-week "," ] date time [CFWS]

Note the trailing CFWS.

It seems like there is already a Go patch for this [3].

[1]: https://tools.ietf.org/html/rfc5322#section-3.2.2
[2]: https://tools.ietf.org/html/rfc5322#section-3.3

A bug corrupting long In-Reply-To headers has been fixed upstream in
go-message:
https://github.com/emersion/go-message/issues/44
---
 go.mod | 31 +++++++++++++-----------
 go.sum | 75 ++++++++++++++++++++++++++++++++--------------------------
 2 files changed, 58 insertions(+), 48 deletions(-)

diff --git a/go.mod b/go.mod
index e59dc0bb3f84..21492a74fbd5 100644
--- a/go.mod
+++ b/go.mod
@@ -3,36 +3,39 @@ module git.sr.ht/~sircmpwn/aerc
 go 1.12
[message trimmed]

Pushed:

To github.com:emersion/go-maildir.git
   81c527bce6e9..941194b0ac70  master -> master

Thanks!