France
I'm Simon Ser, I write open-source software.
From Simon Ser to ~sircmpwn/sr.ht-discuss
On Sunday, June 4th, 2023 at 05:56, Devin Weaver <suki@tritarget.org> wrote: > I've noticed several misunderstandings with my use of git send-email. > I just recently learned that if you have more than one commit you can > generate a thread using the --compose option. I just tried to send > three commits with a cover email (four) but only two emails made it to > the mailing list. > > The email thread in question: > https://lists.sr.ht/~sircmpwn/sr.ht-dev/<20230604032508.22683-1-suki%40tritarget.org> > > I was clever enough to run --smtp-debug=1 so I captured the entire > exchange with my SMTP server which does look as if it accepted all four > emails.
From Simon Ser to ~sircmpwn/sr.ht-dev
We still need to send Content-Type/Content-Length/etc for HEAD. We should only return early for OPTIONS.
From Simon Ser to ~sircmpwn/sr.ht-dev
Can we allow HEAD as well?
From Simon Ser to ~sircmpwn/sr.ht-dev
This patch has the condition inverted: it terminates early for GET/HEAD, and sends the whole body for OPTIONS.
From Simon Ser to ~sircmpwn/sr.ht-dev
Can we skip the whole "fetch from S3" stuff for OPTIONS? We only need to return the CSP.
From Simon Ser to ~sircmpwn/sr.ht-dev
On Friday, June 2nd, 2023 at 16:09, Devin Weaver <weaver.devin@gmail.com> wrote: > Agreed, however I have no idea how to do that in Go. I am a total Golang newb. > > You wouldn’t happen to have some examples would you? It should be possible to move the new headers right under the CSP one, and return early after setting these if the method is OPTIONS.
From Simon Ser to ~sircmpwn/sr.ht-discuss
(CC hwrd) The chat.sr.ht bouncer issue preventing you both from logging in should now be addressed.
From Simon Ser to ~sircmpwn/sr.ht-discuss
Okay, it seems that the failure message I've seen on the server is unrelated then. I now see another error for 2023/06/02 06:07:11, which is caused by a soju bug related to the recent out-of-disk outage. The on-disk logs are malformed and this causes a panic. This has been addressed in soju [1], but not yet deployed. I will do this ASAP and let you know. Looking at the bouncer stats, this bug is hitting 2 users (the other user has reported the issue on IRC). I apologize for the inconvenience, Simon
From Simon Ser to ~sircmpwn/sr.ht-dev
I think http.ServeContent will send the whole file back when handling OPTIONS? (It will properly handle HEAD.) OPTIONS is important to handle since it's used for pre-flight requests. It might be nice to allow the HEAD method too.