Pushed, thanks!

Pushed, thanks!

Pushed, thanks!

On Saturday, June 12th, 2021 at 17:38, Gregory Anders <greg@gpanders.com> wrote:

> Sure. I run soju on a single-user server using a dedicated user and
> group (soju:soju). I've added my user to the 'soju' group and chmod'ed
> the soju log directory to g+rX to make browsing and reading log files a
> little easier (i.e. without using sudo).
>
> However, new log files are written with 0600 so even though they are
> owned by the 'soju' group I still can't read them without sudo.
>
> I don't know if my use case is common or not. I can always do something
> ad hoc like run a cron job to update the permissions on the log dir once
> per hour or something. But for users like myself who run soju on a
> dedicated single-user server there is no benefit to using 0600, so the

On Thursday, June 10th, 2021 at 06:51, Gregory Anders <greg@gpanders.com> wrote:

> Now that I think about it I wonder if the best way to handle this is
> to just delegate to the actual umask set by the user/OS instead of
> re-implementing the functionality in soju.

I agree. I'd prefer to avoid adding a new knob for this.

> In order to do that, the patch would be much simpler: we’d simply
> change the mode argument of the MkdirAll call to 0777 and the mode
> argument of the OpenFile call to 0666.

Hm. 0777 sounds like it could be dangerous, but it also sounds like
it's a common practice to just use 0777 and rely on umask to do the

> I've merged the soju sections into a single paragraph. One thing to
> notice, is that I don't really know if when running soju in a production
> environment, you'll not need to set the `http-origin` directive. I wrote
> it like that, as you haven't specified that before and I've only
> encountered this problem when running locally. Let me know if it need
> any adjustments.

You shouldn't need to. I've tried to make this clearer in [1].

[1]: https://git.sr.ht/~emersion/soju/commit/520ed76adf33cc516964938d2625660b3a6147a5

>  README.md | 29 +++++++++++++++++++++--------
>  1 file changed, 21 insertions(+), 8 deletions(-)
>

Moved "auth" to a standalone ConnectForm param instead of a member of
connectParam. LGTM otherwise.

Pushed, thanks!

webircgateway usage doesn't mean that password auth is optional. Some
networks have mandatory auth, some networks don't have auth at all.

Maybe we should just add a "auth" field which can be set to
"mandatory", "optional" or "disabled"?

Moved the RPL_UMODEIS message right before RPL_NOMOTD in
downstreamConn.welcome(), as instructed by the spec. Also ran go fmt.
With these changes, this LGTM.

Pushed, thanks!

LGTM.

Pushed, thanks!