Is checking the error message really required? Is using a regex really
required?

Note that the preferred, standard way to do this is now OAUTHBEARER
[1][2]. XOAUTH2 is a non-standard Gmail extension.

[1]: https://tools.ietf.org/html/rfc7628
[2]: https://github.com/emersion/go-sasl/issues/6

Pushed, thanks

Thanks!

To git.sr.ht:~emersion/python-emailthreads
   76e447e5ad08..230ed678eb3e  master -> master

I was about to push with minor edits (see below), but I wrote a basic
test and got it to segfault:

==12346==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000008 (pc 0x7f8893d614c5 bp 0x7ffde5aa28e0 sp 0x7ffde5aa28c0 T0)
==12346==The signal is caused by a READ memory access.
==12346==Hint: address points to the zero page.
    #0 0x7f8893d614c4 in task_poll ../shell/task/task.c:30
    #1 0x7f8893d5e64b in task_loop_clause_poll ../shell/task/loop_clause.c:50
    #2 0x7f8893d61572 in task_poll ../shell/task/task.c:31
    #3 0x7f8893d60885 in task_pipeline_poll ../shell/task/pipeline.c:123
    #4 0x7f8893d61572 in task_poll ../shell/task/task.c:31
    #5 0x7f8893d5dc20 in task_list_poll ../shell/task/list.c:27
    #6 0x7f8893d61572 in task_poll ../shell/task/task.c:31
    #7 0x7f8893d61955 in task_run ../shell/task/task.c:48

> -		item := feed.Items[0]
> +		items := feed.Items[:perSource]

This will panic if len(feed.Items) < perSource. We need to pick the
maximum between the configured number of posts per source and the
number of posts available from this source.

Thsi fixes build failures due to pkg not finding /dev/null. See [1].

[1]: https://github.com/freebsd/pkg/issues/1763#issuecomment-502579057
---

See [2] for a successful build. (Side note, the deploy step should probably
fail but doesn't?)

[2]: https://builds.sr.ht/~emersion/job/70243

 images/freebsd/genimg | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/images/freebsd/genimg b/images/freebsd/genimg
[message trimmed]

> On 16-06-2019 10:15:11, Simon Ser wrote:
> > > 2.  Maildir support.
> >
> > The number of messages in your mailboxes shouldn't matter since aerc
> > only downloads what you see on screen, nothing more.
>
> Thanks for the clearification. What happens if I do not have connection to the
> internet?

You can't read your messages. For this use-case, a maildir backend
would be better.

> 2.  Maildir support. I know it is its early days, so I don't mind that it does
>     not have Maildir support yet (I hope it will have at some point). But I have a
>     rather slow internet connection right now and also have mailboxes with 20k and
>     more messages in them,... maybe it is just a convenience thing on my side, I
>     don't know.

The number of messages in your mailboxes shouldn't matter since aerc
only downloads what you see on screen, nothing more.

> diff --git a/builtin/break.c b/builtin/break.c
> new file mode 100644
> index 0000000..63667aa
> --- /dev/null
> +++ b/builtin/break.c
> @@ -0,0 +1,35 @@
> +#define _POSIX_C_SOURCE 200809L
> +#include <mrsh/builtin.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>
> +#include "builtin.h"
> +#include "shell/shell.h"
> +#include "shell/task.h"