On Tuesday, December 10, 2019 10:26 AM, Denis Laxalde <denis@laxalde.org> wrote:

> Agreed, formataddr is not nice.
> Perhaps this is better:
>
> >>> display_name, addr_spec = parseaddr(cfg('mail', 'smtp-from'))
> >>> addr = Address(display_name=display_name, addr_spec=addr_spec)
> >>> msg['From'] = addr

Yeah, that's what we've been trying to do, however for some reason when
used in sr.ht's code with smtplib's send_message, this raises an
exception [1].

[1]: https://paste.sr.ht/%7Exenrox/ab320f3991f300e30dfdd221453f210163be3c8f

I guess calling formataddr explicitly wouldn't be as nice as setting
Address but would workaround the bug linked in my previous e-mail…

On Tuesday, December 10, 2019 8:36 AM, Denis Laxalde <denis@laxalde.org> wrote:

> Another solution would be to parse and re-format the email address from
> configuration value so that it gets properly encoded (in particular the
> < > around address).

Indeed. We've been discussing about a better solution on IRC [1] but we
still haven't got to make it work yet [2].

[1]: https://paste.sr.ht/%7Eemersion/a2ebad93e45325f9d6cb36094f7dff2aaa0d2392
[2]: https://paste.sr.ht/%7Exenrox/ab320f3991f300e30dfdd221453f210163be3c8f

The current code is already RFC compliant, since header field names
are case-insensitive. See section 1.2.2:

> a case-insensitive literal value enclosed in quotation marks

Pushed:

To git.sr.ht:~emersion/mrsh
   715e6efeb77b..307cb3693614  master -> master

Thanks!

Pushed:

To git.sr.ht:~sircmpwn/wxrc
   d832312e368b..5c81e982f5c2  master -> master

Thanks!

This change LGTM. Just a minot nitpick below.

> And update our implementation to consider it. This does not add a depth
> buffer to wxrc, it just adds it to the state tracker for the XR shell
> protocol.
> ---
>  example/cube.c                     |  3 ++-
>  include/xr-shell-protocol.h        |  5 ++++-
>  protocol/zxr-shell-unstable-v1.xml | 18 +++++++++++++++---
>  src/render.c                       |  3 ++-
>  src/xr-shell-protocol.c            | 21 +++++++++++++++++----
>  5 files changed, 40 insertions(+), 10 deletions(-)
>
> diff --git a/example/cube.c b/example/cube.c

---
 images/freebsd/12.x/genimg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/images/freebsd/12.x/genimg b/images/freebsd/12.x/genimg
index acdc6ad6e133..9849b83a1b5c 100755
--- a/images/freebsd/12.x/genimg
+++ b/images/freebsd/12.x/genimg
@@ -1,6 +1,6 @@
 #!/bin/sh
 arch="${1:-amd64}"
-export release="12.0-RELEASE"
+export release="12.1-RELEASE"
 export dist_base="https://download.freebsd.org/ftp/releases/$arch/$release"
[message trimmed]

Nice, thanks! Pushed:

To git.sr.ht:~emersion/wayland.emersion.fr
   1fbf1a3c5912..b6569e7e0df1  master -> master

Pushed, thanks!

To git.sr.ht:~emersion/drmdb
   23cd002cfad8..971340a0d0b7  master -> master