[PATCH] irc: use RFC 2812 default for CHANTYPES

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH] irc: use RFC 2812 default for CHANTYPES

Simon Ser <contact@emersion.fr>

Details

Message ID: <20230116171911.19578-1-contact@emersion.fr>
DKIM signature: missing

Download raw message

1 year, 8 months ago

Patch: +1 -1

Some servers don't comply with RFC 2812 and don't send RPL_ISUPPORT.
Use a legacy default for CHANTYPES in this case.

Modern servers can advertise "CHANTYPES=" (empty value) to indicate
that they don't support channels.
---

I'll wait before applying this patch because:

- It would be nice to get modern-irc updated accordingly.
- soju only sends an empty CHANTYPES since today.

 lib/irc.dart | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/irc.dart b/lib/irc.dart
index 4ffcefb06d4c..bcdf06f88372 100644
--- a/lib/irc.dart
+++ b/lib/irc.dart
@@ -630,7 +630,7 @@ class IrcIsupportRegistry {
 	IrcIsupportElist? _elist;
 
 	String? get network => _raw['NETWORK'];
-	String get chanTypes => _raw['CHANTYPES'] ?? '';
+	String get chanTypes => _raw['CHANTYPES'] ?? '#&+!';
 	CaseMapping get caseMapping => _caseMapping ?? defaultCaseMapping;
 	String? get bouncerNetId => _raw['BOUNCER_NETID'];
 	UnmodifiableListView<IrcIsupportMembership> get memberships => UnmodifiableListView(_memberships);

base-commit: c3f46e3567d89d299809594d26aa43dabe7d9e51
-- 
2.39.0

~emersion/goguma-dev

[PATCH] irc: use RFC 2812 default for CHANTYPES