buffer: Fix compact message text v1 APPLIED

delthas: 1
 buffer: Fix compact message text

 1 files changed, 3 insertions(+), 3 deletions(-)

[PATCH] buffer: Fix compact message text Export this patch

Previously, on some Android devices, the sender text could appear larger
than intended and would then end after the message text start.

This fixes the issue by using Text.rich which properly merges the base
theme applied by the Widget (coming from the device Theme) with our own
formatting overrides. (Text.rich is the high-level counterpart of
RichText).
---
 lib/page/buffer.dart | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/page/buffer.dart b/lib/page/buffer.dart
index c3dcb68..0e47222 100644
--- a/lib/page/buffer.dart
+++ b/lib/page/buffer.dart
@@ -514,7 +514,7 @@ class _CompactMessageItem extends StatelessWidget {
 		var prevIrcMsg = prevMsg?.msg;
 		var prevMsgSameSender = prevIrcMsg != null && ircMsg.source!.name == prevIrcMsg.source!.name;
 
-		var textStyle = DefaultTextStyle.of(context).style.apply(color: Theme.of(context).textTheme.bodyText1!.color);
+		var textStyle = TextStyle(color: Theme.of(context).textTheme.bodyText1!.color);
 		var linkStyle = textStyle.apply(decoration: TextDecoration.underline);
 		TextSpan textSpan;
 
@@ -573,8 +573,8 @@ class _CompactMessageItem extends StatelessWidget {
 
 		stack.add(Container(
 			margin: EdgeInsets.only(left: 4),
-			child: RichText(
-				text: TextSpan(
+			child: Text.rich(
+				TextSpan(
 					children: content,
 				),
 			),

base-commit: d38cd528962fd2479475836121ee682393b0cc5a
-- 
2.17.1

Simon Ser <contact@emersion.fr>

3 months ago

Pushed, thanks!