Date: Sun, 23 Jan 2022 07:20:41 +0000
To: Simon Ser <contact@emersion.fr>
From: Renato Torres <renato.torres@protonmail.com>
Cc: ~emersion/hut-dev@lists.sr.ht
Reply-To: Renato Torres <renato.torres@protonmail.com>
Subject: Re: [PATCH v1 0/1] git: show license spike
Message-ID: <CHCVEDAG1NOA.3OHNG8NXUR1CG@mint2>
In-Reply-To: <VVEqWeSlVFfoMZ2hNXzVOcwM-VtrM6VF_vBqhaMIw4dtqyuGvleSLKbEU2Cxd8ync0sEEg0NfB3SzUYhdIZLRZ1eq0K9nUzT23bTaLVfi0I=@emersion.fr>
References: <20220122233022.1256016-1-renato.torres@protonmail.com> <VVEqWeSlVFfoMZ2hNXzVOcwM-VtrM6VF_vBqhaMIw4dtqyuGvleSLKbEU2Cxd8ync0sEEg0NfB3SzUYhdIZLRZ1eq0K9nUzT23bTaLVfi0I=@emersion.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

> I wonder. Maybe a more generally useful feature could be a cat-file
> command.

Sounds good.

> I've been wondering about this, and I'm not sure a Go interface is the=20
> best way to represent a GraphQL interface. (...)

I'm checking your suggestions, I have no previous experience with
graphql nor gqlclientgen.

Just adding extra information.

Previouslly I had requested the raw fields and they were empty.

For example:

query licenseByRepositoryName($name: String!) {
    repositoryByName(name: $name) {
        path(path: "LICENSE") {
            name
            object {
                id
                shortId
                raw
                __typename
                ... on TextBlob {
                    text
                }
            }
        }
    }
}

Returns:

{
  "data": {
    "repositoryByName": {
      "path": {
        "name": "LICENSE",
        "object": {
          "id": "0ad25db4bd1d86c452db3f9602ccdbe172438f52",
          "shortId": "0ad25db",
          "raw": "",
          "__typename": "TextBlob",
          "text": "                    GNU AFFERO GENERAL ..."
        }
      }
    }
  }
}

I took a look a the git.sr.ht API and found the following TODO at
api/graph/model/object.go:

...

func LookupObject(repo *RepoWrapper, hash plumbing.Hash) (Object, error) {
=09repo.Lock()
=09obj, err :=3D repo.Object(plumbing.AnyObject, hash)
=09repo.Unlock()
=09if err !=3D nil {
=09=09return nil, fmt.Errorf("lookup object %s: %w", hash.String(), err)
=09}
=09// TODO: Add raw object data, if requested
=09switch obj :=3D obj.(type) {
=09case *object.Commit:
=09=09return CommitFromObject(repo, obj), nil
=09case *object.Tree:
=09=09return TreeFromObject(repo, obj), nil
=09case *object.Blob:
=09=09return BlobFromObject(repo, obj), nil
=09default:
=09=09return nil, fmt.Errorf("Unknown object type %T", obj)
=09}
}

We would need first to add the raw support.=20