6 2

[PATCH] Drop minimum meson version to 0.37.1

Details
Message ID
<20181118011639.GA56051@airmail.cc>
DKIM signature
pass
Download raw message
Patch: +1 -1
The minimum required meson version is 0.43.0, but no features are
actually being used that are incompatible with 0.37.1 (the latest
version shipped by Debian).
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 6d607a0..f4e719e 100644
--- a/meson.build
+++ b/meson.build
@@ -3,7 +3,7 @@ project(
 	'c',
 	version: '0.0.0',
 	license: 'MIT',
-	meson_version: '>=0.43.0',
+	meson_version: '>=0.37.1',
 	default_options: [
 		'c_std=c99',
 		'warning_level=2',
Details
Message ID
<iLWKCKq_FyYXQAO1AWAuU0Szk9Tgqjo_ft0lInUKfr4fR7uZ-QLlvMhK9FMersBuEXij3y6gVYpS-4sATPe01v2KerTmp2qc6vWxj7bl5FA=@emersion.fr>
In-Reply-To
<20181118011639.GA56051@airmail.cc> (view parent)
DKIM signature
pass
Download raw message
Pushed:

To git.sr.ht:~emersion/mrsh
   fed1075..42c50b2  master -> master

Thanks!

(As a side note, git-am refused to apply your patch, failing with "error:
corrupt patch at line 17". I don't know why this happened, can you make sure
you're using git-send-email [1]?)

[1]: https://man.sr.ht/git.sr.ht/send-email.md
Details
Message ID
<20181119023716.GA20013@airmail.cc>
In-Reply-To
<iLWKCKq_FyYXQAO1AWAuU0Szk9Tgqjo_ft0lInUKfr4fR7uZ-QLlvMhK9FMersBuEXij3y6gVYpS-4sATPe01v2KerTmp2qc6vWxj7bl5FA=@emersion.fr> (view parent)
DKIM signature
pass
Download raw message
Simon Ser wrote:
> (As a side note, git-am refused to apply your patch, failing with
> "error: corrupt patch at line 17". I don't know why this happened, can
> you make sure you're using git-send-email [1]?)

It looks like I made some other commits/changes before my patch; the
hashes in my patch don't match any in the repo. If you correct the
hashes in the index line it applies cleanly.

Sorry about that! I'll be more careful.
Details
Message ID
<20181119024955.GJ1543@homura.localdomain>
In-Reply-To
<20181119023716.GA20013@airmail.cc> (view parent)
DKIM signature
permerror
Download raw message
The issue is more likely that you didn't send the email with git
send-email. Did you try to copy+paste the output of git format-patch
into a different mail client?
Details
Message ID
<20181119041111.GA31383@airmail.cc>
In-Reply-To
<20181119023716.GA20013@airmail.cc> (view parent)
DKIM signature
pass
Download raw message
Jason Valencia wrote:
> Simon Ser wrote:
> > (As a side note, git-am refused to apply your patch, failing with
> > "error: corrupt patch at line 17". I don't know why this happened,
> > can you make sure you're using git-send-email [1]?)
>
> It looks like I made some other commits/changes before my patch; the
> hashes in my patch don't match any in the repo. If you correct the
> hashes in the index line it applies cleanly.
>
> Sorry about that! I'll be more careful.

I messed up the formatting.

It looks like the actual issue is that the patch has no final newline.
(There is no signature after the patch.) I must have accidentally
removed it when I sent it. Checking against the output of git
send-email, it looks like if you send without a signature, it will
automatically add a newline, but git format-patch will not (I emailed
with mutt -H).

(The reason I thought editing the index line was fixing the issue is
that when I made the change and saved, a newline was automatically
added. `printf '\n' >> patch` fixes it the same way.)

Sorry again!
Details
Message ID
<20181119124726.GG2375@homura.localdomain>
In-Reply-To
<20181119041111.GA31383@airmail.cc> (view parent)
DKIM signature
permerror
Download raw message
Yep, seems you forgot the golden rule of sending patches with git:

https://man.sr.ht/git.sr.ht/send-email.md

Just use git send-email! Lesson learned for next time. Thanks!
Details
Message ID
<-GvGxUevYmXGtd_cApdb8P92jo-VWeGzfomeBFN0wuKQviNUpCa4r17MbjueZN70jiTiNr5JuUKr5JVahEdpGqTAVWujd-Zm1bfEXxRrVJs=@emersion.fr>
In-Reply-To
<20181119041111.GA31383@airmail.cc> (view parent)
DKIM signature
pass
Download raw message
On Monday, November 19, 2018 5:11 AM, Jason Valencia <jasval@airmail.cc> wrote:
> Jason Valencia wrote:
>
> > Simon Ser wrote:
> >
> > > (As a side note, git-am refused to apply your patch, failing with
> > > "error: corrupt patch at line 17". I don't know why this happened,
> > > can you make sure you're using git-send-email [1]?)
> >
> > It looks like I made some other commits/changes before my patch; the
> > hashes in my patch don't match any in the repo. If you correct the
> > hashes in the index line it applies cleanly.
> > Sorry about that! I'll be more careful.
>
> I messed up the formatting.
>
> It looks like the actual issue is that the patch has no final newline.
> (There is no signature after the patch.) I must have accidentally
> removed it when I sent it. Checking against the output of git
> send-email, it looks like if you send without a signature, it will
> automatically add a newline, but git format-patch will not (I emailed
> with mutt -H).
>
> (The reason I thought editing the index line was fixing the issue is
> that when I made the change and saved, a newline was automatically
> added. `printf '\\n' >> patch` fixes it the same way.)
>
> Sorry again!

No worries! Just make sure to use git-send-email next time. :)