This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH mrsh] mrsh_populate_env: unset COLUMNS

Message ID
DKIM signature
Download raw message
Patch: +5 -0
This fixes the ls problem
This was brought up a while ago, but forgotten about. POSIX allows us to
unset this, and it fixes some stupid problems with GNU tools. For your

 shell/entry.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/shell/entry.c b/shell/entry.c
index 80dcbea..62377ba 100644
--- a/shell/entry.c
+++ b/shell/entry.c
@@ -111,6 +111,11 @@ bool mrsh_populate_env(struct mrsh_state *state, char **environ) {

	mrsh_env_set(state, "OPTIND", "1", MRSH_VAR_ATTRIB_NONE);

	/* POSIX 8.3: If this variable is unset or null, the implementation
	 * determines the number of columns */
	mrsh_env_unset(state, "LINES");
	mrsh_env_unset(state, "COLUMNS");
	return true;

Reply to thread Export thread (mbox)