parser: fix build with gcc 10's -Wformat-truncation v1 PROPOSED

Arseny Maslennikov: 1
 parser: fix build with gcc 10's -Wformat-truncation

 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH] parser: fix build with gcc 10's -Wformat-truncation Export this patch

There is no reason for the array to not be static, and this qualifier
prevents type erasure so this file can be compiled with
-Werror=format-truncation.
---

Arseny Maslennikov <arseny@altlinux.org>

3 years ago

This fix is actually incomplete, at least on armv7 and i686 — since
we're linking this file into a shared library.
The complete fix has to get rid of pointers at all — we have to make
reserved[i] an array of arrays, or an array of subindexes in a single
static string.
See https://akkadia.org/drepper/dsohowto.pdf,
"2.4.3 Arrays of Data Pointers".

 parser/program.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/parser/program.c b/parser/program.c
index 921f7cf..6214751 100644
--- a/parser/program.c
+++ b/parser/program.c
@@ -875,7 +875,7 @@ static struct mrsh_function_definition *function_definition(
 }
 
 static bool unspecified_word(struct mrsh_parser *parser) {
-	const char *const reserved[] = {
+	static const char *const reserved[] = {
 		"[[",
 		"]]",
 		"function",
-- 
2.29.3