~emersion/public-inbox

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH gamja] components/connect-form: forward ping value

Details
Message ID
<165195952730.4627.18223701380444413941-0@git.sr.ht>
DKIM signature
missing
Download raw message
Patch: +3 -0
From: xse <xse@riseup.net>

---
The ping interval was only set when using autoconnect,
Have a good day!

 components/connect-form.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/components/connect-form.js b/components/connect-form.js
index 5b8a529..f971e81 100644
--- a/components/connect-form.js
+++ b/components/connect-form.js
@@ -11,6 +11,7 @@ export default class ConnectForm extends Component {
		username: "",
		realname: "",
		autojoin: true,
		ping: 0,
	};
	nickInput = createRef();

@@ -28,6 +29,7 @@ export default class ConnectForm extends Component {
				rememberMe: props.params.autoconnect || false,
				username: props.params.username || "",
				realname: props.params.realname || "",
				ping: props.params.ping || 0,
			};
		}
	}
@@ -54,6 +56,7 @@ export default class ConnectForm extends Component {
			realname: this.state.realname,
			saslPlain: null,
			autojoin: [],
			ping: this.state.ping,
		};

		if (this.state.password) {
-- 
2.34.2

[gamja/patches/.build.yml] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CJTUSPVO8LUL.QJ8F5JIZEWB2@cirno>
In-Reply-To
<165195952730.4627.18223701380444413941-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
gamja/patches/.build.yml: SUCCESS in 50s

[components/connect-form: forward ping value][0] from [~xse][1]

[0]: https://lists.sr.ht/~emersion/public-inbox/patches/32094
[1]: xse@riseup.net

✓ #753504 SUCCESS gamja/patches/.build.yml https://builds.sr.ht/~emersion/job/753504
Details
Message ID
<DbDaojg_faK0AdcoOCwtwdMP6oJHW9KIHOlCqtMxae314qCmvTOf3RXzkfXzZdLA1H94qMFLbOHyb2tgG4H0Z2lDY_67I28G_J3metkVEs0=@emersion.fr>
In-Reply-To
<165195952730.4627.18223701380444413941-0@git.sr.ht> (view parent)
DKIM signature
pass
Download raw message
Good catch! One comment below.

On Saturday, May 7th, 2022 at 23:25, ~xse <xse@git.sr.ht> wrote:

> @@ -54,6 +56,7 @@ export default class ConnectForm extends Component {
>  			realname: this.state.realname,
>  			saslPlain: null,
>  			autojoin: [],
> +			ping: this.state.ping,

We shouldn't need to add this to the state, we should be able to directly use
props.params.ping here.
Reply to thread Export thread (mbox)