Hello :wave:


I used your blog about the wayland drag and drop support to port a
header library to wayland. And it helped for most of my needs, so first
and foremost thank you for taking your time to do that work.

Now I think that this blog post is one of the few detailed resources
there is on how to configure wayland for clipboard support, I wanted to
tell you that I found an issues with the code:

The `wl_data_offer_accept()` call needs to be moved from
`data_device_handle_drop` to `data_offer_handle_offer` for the specific
mime_type and with a serial:
`wl_data_offer_accept(current_drag_offer, serial, mime_type);`

Otherwise the wayland compositor will never dispatch the `drop` event
and the client can thus never access the data. This took me longer than
I care to admit to figure this out.

Sorry for being a bit verbose, I would have supplied a patch, but I
don't think your blog posts are in a public repo, are they? Thank you
for your consideration, though. :)


Much love :v:

Hi,

Sorry for the delay.

On Thursday, February 11th, 2021 at 9:04 PM, Karl <fleischmann.karl@googlemail.com> wrote:

> I used your blog about the wayland drag and drop support to port a
> header library to wayland. And it helped for most of my needs, so first
> and foremost thank you for taking your time to do that work.

Nice!

> Now I think that this blog post is one of the few detailed resources
> there is on how to configure wayland for clipboard support, I wanted to
> tell you that I found an issues with the code:
>
> The `wl_data_offer_accept()` call needs to be moved from
> `data_device_handle_drop` to `data_offer_handle_offer` for the specific
> mime_type and with a serial:
> `wl_data_offer_accept(current_drag_offer, serial, mime_type);`
>
> Otherwise the wayland compositor will never dispatch the `drop` event
> and the client can thus never access the data. This took me longer than
> I care to admit to figure this out.

Hm, indeed, it seems like this should be used at the same time as set_actions.

> Sorry for being a bit verbose, I would have supplied a patch, but I
> don't think your blog posts are in a public repo, are they? Thank you
> for your consideration, though. :)

At the moment my blog repo is on GitHub [1]. Would you be willing to send a
patch (either as a pull request or by email to my public-inbox)?

Thanks,

Simon

[1]: https://github.com/emersion/emersion.fr