[PATCH gamja] components/app: allow multiple spaces between command arguments

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

3 3

[PATCH gamja] components/app: allow multiple spaces between command arguments

Matthew Martin <phy1729@gmail.com>

Details

Message ID: <ZIe4omLW4mQ7-2Sy@CptOrmolo.darkstar>
DKIM signature: missing

Download raw message

1 year, 6 months ago

Patch: +1 -1

---
 components/app.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/app.js b/components/app.js
index 3987749..876b9b5 100644
--- a/components/app.js
+++ b/components/app.js
@@ -1504,7 +1504,7 @@ export default class App extends Component {
 	}
 
 	executeCommand(s) {
-		let parts = s.split(" ");
+		let parts = s.split(/ +/);
 		let name = parts[0].toLowerCase().slice(1);
 		let args = parts.slice(1);
 
-- 
2.41.0

[gamja/patches/.build.yml] build success

builds.sr.ht <builds@sr.ht>

Details

Message ID: <CTB3KSHYW645.2X2V6JF2DCI32@cirno2>
In-Reply-To: <ZIe4omLW4mQ7-2Sy@CptOrmolo.darkstar> (view parent)
DKIM signature: missing

Download raw message

1 year, 6 months ago

gamja/patches/.build.yml: SUCCESS in 59s

[components/app: allow multiple spaces between command arguments][0] from [Matthew Martin][1]

[0]: https://lists.sr.ht/~emersion/public-inbox/patches/41814
[1]: phy1729@gmail.com

✓ #1006065 SUCCESS gamja/patches/.build.yml https://builds.sr.ht/~emersion/job/1006065

Simon Ser <contact@emersion.fr>

Details

Message ID: <P4At9vLK6rQxXTyiRpRRlnr9_Uxl4EzvE8MMheRvn99wTNwIN5h81pcECEA4NJSi4u-m5THlKFP78mrI0Ehc7GDhBM_OaACR8LuY7aEs0Hw=@emersion.fr>
In-Reply-To: <ZIe4omLW4mQ7-2Sy@CptOrmolo.darkstar> (view parent)
DKIM signature: missing

Download raw message

1 year, 6 months ago

Unfortunately this will break things like:

    /msg emersion this  is a    message with      many  spaces

Matthew Martin <phy1729@gmail.com>

Details

Message ID: <ZIkaVl4EYNlInbME@CptOrmolo.darkstar>
In-Reply-To: <P4At9vLK6rQxXTyiRpRRlnr9_Uxl4EzvE8MMheRvn99wTNwIN5h81pcECEA4NJSi4u-m5THlKFP78mrI0Ehc7GDhBM_OaACR8LuY7aEs0Hw=@emersion.fr> (view parent)
DKIM signature: missing

Download raw message

1 year, 6 months ago

On Tue, Jun 13, 2023 at 10:07:10AM +0000, Simon Ser wrote:
> Unfortunately this will break things like:
> 
>     /msg emersion this  is a    message with      many  spaces

Right, sorry. I don't think there's a simple solution, so I'll just drop
the idea. Thanks.