~emersion/public-inbox

soju: Don't save corrupted NickServ credentials v1 APPLIED

Hubert Hirtz: 1
 Don't save corrupted NickServ credentials

 1 files changed, 2 insertions(+), 0 deletions(-)
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~emersion/public-inbox/patches/11325/mbox | git am -3
Learn more about email & git
View this thread in the archives

[PATCH soju] Don't save corrupted NickServ credentials Export this patch

soju saved most NickServ messages[0] as credentials because of a missing
`default` clause in the check of the NickServ command.

[0] messages that had at least a command and two other parameters
---
 downstream.go | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/downstream.go b/downstream.go
index 6ea160c..fdc6cc6 100644
--- a/downstream.go
+++ b/downstream.go
@@ -1557,6 +1557,8 @@ func parseNickServCredentials(text, nick string) (username, password string, ok
			username = nick
			password = params[1]
		}
	default:
		return "", "", false
	}
	return username, password, true
}
-- 
2.27.0
Pushed, thanks for the fix!