goguma: Make all buffer list buffer items the same height v1 SUPERSEDED

delthas: 1
 Make all buffer list buffer items the same height

 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH goguma v1] Make all buffer list buffer items the same height Export this patch

Previously, buffers without a topic would be smaller in the list. Using
an empty text makes all buffer items the same height, which arguably
looks nicer.

Simon Ser <contact@emersion.fr>

a month ago

Unfortunately this also makes it so the CircleAvatar and the title are
no longer vertically aligned...

---
 lib/page/buffer_list.dart | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/page/buffer_list.dart b/lib/page/buffer_list.dart
index c0a36c7..6381604 100644
--- a/lib/page/buffer_list.dart
+++ b/lib/page/buffer_list.dart
@@ -273,7 +273,7 @@ class _BufferItem extends AnimatedWidget {
 				children: trailing,
 			),
 			title: title,
-			subtitle: subtitle == null ? null : Text(subtitle,
+			subtitle: Text(subtitle ?? "",
 				overflow: TextOverflow.fade,
 				softWrap: false,
 			),

base-commit: 77c54b392662b36526c5c3adfa8c4f036a684e01
-- 
2.17.1

builds.sr.ht <builds@sr.ht>

a month ago

goguma/patches/android.yml: SUCCESS in 14m51s

[Make all buffer list buffer items the same height][0] from [delthas][1]

[0]: https://lists.sr.ht/~emersion/public-inbox/patches/30726
[1]: mailto:delthas@dille.cc

✓ #727898 SUCCESS goguma/patches/android.yml https://builds.sr.ht/~emersion/job/727898