gamja: components/connect-form: forward ping value v1 SUPERSEDED

~xse: 1
 components/connect-form: forward ping value

 1 files changed, 3 insertions(+), 0 deletions(-)

[PATCH gamja] components/connect-form: forward ping value Export this patch

From: xse <xse@riseup.net>

---
The ping interval was only set when using autoconnect,
Have a good day!

 components/connect-form.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/components/connect-form.js b/components/connect-form.js
index 5b8a529..f971e81 100644
--- a/components/connect-form.js
+++ b/components/connect-form.js
@@ -11,6 +11,7 @@ export default class ConnectForm extends Component {
 		username: "",
 		realname: "",
 		autojoin: true,
+		ping: 0,
 	};
 	nickInput = createRef();
 
@@ -28,6 +29,7 @@ export default class ConnectForm extends Component {
 				rememberMe: props.params.autoconnect || false,
 				username: props.params.username || "",
 				realname: props.params.realname || "",
+				ping: props.params.ping || 0,
 			};
 		}
 	}
@@ -54,6 +56,7 @@ export default class ConnectForm extends Component {
 			realname: this.state.realname,
 			saslPlain: null,
 			autojoin: [],
+			ping: this.state.ping,

Simon Ser <contact@emersion.fr>

6 months ago

We shouldn't need to add this to the state, we should be able to directly use
props.params.ping here.

 		};
 
 		if (this.state.password) {
-- 
2.34.2

builds.sr.ht <builds@sr.ht>

6 months ago

gamja/patches/.build.yml: SUCCESS in 50s

[components/connect-form: forward ping value][0] from [~xse][1]

[0]: https://lists.sr.ht/~emersion/public-inbox/patches/32094
[1]: mailto:xse@riseup.net

✓ #753504 SUCCESS gamja/patches/.build.yml https://builds.sr.ht/~emersion/job/753504

Simon Ser <contact@emersion.fr>

6 months ago

Good catch! One comment below.

On Saturday, May 7th, 2022 at 23:25, ~xse <xse@git.sr.ht> wrote: