~emersion/public-inbox

gamja: sort member-list with localeCompare v1 PROPOSED

Nolan Prescott: 1
 sort member-list with localeCompare

 1 files changed, 1 insertions(+), 1 deletions(-)
#813302 .build.yml success
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~emersion/public-inbox/patches/34316/mbox | git am -3
Learn more about email & git

[PATCH gamja] sort member-list with localeCompare Export this patch

The difference in case sensitivity is the most obvious change with
servers like soju that support CASEMAPPING ascii and
rfc1459. Currently the list:
  'Alpha', 'aardvark', 'Charlie', 'comma'
currently sorts to:
  'Alpha', 'Charlie', 'aardvark', 'comma'
with this change it will instead become:
  'aardvark', 'Alpha', 'Charlie', 'comma'

If something like RFC 7613 gets broader support then there are a few
more differences for a list like:
  'éclair', 'ecstatic, 'aardvark', 'zed', 'Gamma'
currently sorts to:
  'Gamma', 'aardvark', 'ecstatic', 'zed', 'éclair'
with this patch would instead sort to:
  'aardvark', 'éclair', 'ecstatic', 'Gamma', 'zed'

The above examples were run with a locale unspecified which fell back
to my browser/host default of 'en'.

diff --git a/components/member-list.js b/components/member-list.js
--- a/components/member-list.js
+++ b/components/member-list.js
@@ -101,7 +101,7 @@ function sortMembers(a, b) {
		return i - j;
	}

	return nickA < nickB ? -1 : 1;
	return nickA.localeCompare(nickB);
}

export default class MemberList extends Component {
gamja/patches/.build.yml: SUCCESS in 41s

[sort member-list with localeCompare][0] from [Nolan Prescott][1]

[0]: https://lists.sr.ht/~emersion/public-inbox/patches/34316
[1]: mailto:mail@nprescott.com

✓ #813302 SUCCESS gamja/patches/.build.yml https://builds.sr.ht/~emersion/job/813302