This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH v2] Make sure that WebSocket messages are valid UTF-8

Message ID
DKIM signature
Download raw message
Patch: +3 -1
... by replacing invalid bytes with the REPLACEMENT CHARACTER U+FFFD

This is better than:
- discarding the whole message, since the user would not see it...
- removing invalid bytes, since the user would not see their presence,
- converting the encoding (this is actually not possible).

Contrary to its documentation, strings.ToValidUTF8 doesn't copy the
string if it's valid UTF-8:
 conn.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/conn.go b/conn.go
index 6914179..c14f13e 100644
--- a/conn.go
+++ b/conn.go
@@ -5,8 +5,10 @@ import (

@@ -62,7 +64,7 @@ func (wic websocketIRCConn) ReadMessage() (*irc.Message, error) {

func (wic websocketIRCConn) WriteMessage(msg *irc.Message) error {
	b := []byte(msg.String())
	b := []byte(strings.ToValidUTF8(msg.String(), string(unicode.ReplacementChar)))
	ctx := context.Background()
	if !wic.writeDeadline.IsZero() {
		var cancel context.CancelFunc
Message ID
<20200902150617.119576-1-hubert@hirtzfr.eu> (view parent)
DKIM signature
Download raw message
DKIM signature: fail
LGTM and pushed, thanks!
Review patch Export thread (mbox)