~emersion/soju-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] Don't send TAGMSG to upstreams that don't support it

Details
Message ID
<20201120101951.6413-1-hubert@hirtz.pm>
DKIM signature
pass
Download raw message
Patch: +3 -0
TAGMSG are (in current specs and drafts from IRCv3) only used for
client tags. These are optional information by design (since they are
not distributed to all users), therefore it is preferable to discard
them accordingly to upstream, instead of waiting for all upstreams to
support the capability to advertise it.
---
 downstream.go | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/downstream.go b/downstream.go
index 6352f23..6a9cf55 100644
--- a/downstream.go
+++ b/downstream.go
@@ -1553,6 +1553,9 @@ func (dc *downstreamConn) handleMessageRegistered(msg *irc.Message) error {
			if err != nil {
				return err
			}
			if _, ok := uc.caps["message-tags"]; !ok {
				continue
			}

			uc.SendMessageLabeled(dc.id, &irc.Message{
				Tags:    tags,
-- 
2.26.2
Details
Message ID
<RKPyHyxXftN8W17HtGxbRCxBQW-4kCNks_78BXKhZM5n2uldb62xkRD4V1ZXWlYk0YuIxN1XK5BdFEhmzGDnhFQaxFz28bc9rQdVkum9af8=@emersion.fr>
In-Reply-To
<20201120101951.6413-1-hubert@hirtz.pm> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
LGTM, thanks!
Reply to thread Export thread (mbox)