[PATCH] Correctly handle empty IRC messages

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH] Correctly handle empty IRC messages

Hubert Hirtz

Details

Message ID: <20210119180758.10565-1-hubert@hirtz.pm>
DKIM signature: pass

Download raw message

a month ago

Patch: +1 -1

A new version of go-irc includes a fix that makes irc.Conn.ReadMessage
ignore empty messages. This fixes soju closing connections on an empty
message.
---
 go.mod | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/go.mod b/go.mod
index 462d99c..e3b1457 100644
--- a/go.mod
+++ b/go.mod
@@ -11,6 +11,6 @@ require (
 	github.com/pires/go-proxyproto v0.2.0
 	golang.org/x/crypto v0.0.0-20201016220609-9e8e0b390897
 	golang.org/x/sys v0.0.0-20201024232916-9f70ab9862d5 // indirect
-	gopkg.in/irc.v3 v3.1.3
+	gopkg.in/irc.v3 v3.1.4
 	nhooyr.io/websocket v1.8.6
 )
-- 
2.26.2

Simon Ser

Details

Message ID: <hugAUOlfLLw97H10VLUkZoZeeYkEryy1QD_80fDms8zqJzBlu9PbmelB1L_gifzFBETU9QJaC8acH43KfrtSTr1rYR5psrrK9XYw-vKvRe0=@emersion.fr>
In-Reply-To: <20210119180758.10565-1-hubert@hirtz.pm> (view parent)
DKIM signature: pass

Download raw message

a month ago

Ah, thanks. This patch won't quite work as-is because  we need to
update go.sum as well.

Can we update all dependencies while at it?

   go get -u ./...
   go mod tidy

~emersion/soju-dev

[PATCH] Correctly handle empty IRC messages