[PATCH] if true return true else return false

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH] if true return true else return false

Hubert Hirtz

Details

Message ID: <20210217182735.2897-1-hubert@hirtz.pm>
DKIM signature: pass

Download raw message

10 days ago

Patch: +1 -4

	Trivial improvement
---
 upstream.go | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/upstream.go b/upstream.go
index 8843b1b..59cf827 100644
--- a/upstream.go
+++ b/upstream.go
@@ -227,10 +227,7 @@ func (uc *upstreamConn) getChannel(name string) (*upstreamChannel, error) {
 }
 
 func (uc *upstreamConn) isChannel(entity string) bool {
-	if i := strings.IndexByte(uc.availableChannelTypes, entity[0]); i >= 0 {
-		return true
-	}
-	return false
+	return strings.ContainsRune(uc.availableChannelTypes, rune(entity[0]))
 }
 
 func (uc *upstreamConn) getPendingLIST() *pendingLIST {
-- 
2.26.2

Simon Ser

Details

Message ID: <BbjjVyEdOsxM2O_Hx6FCwH4gLouidKovP4NkkR9vcoiYJuILzZEEs1Vjl4Pk-ckcw7KMBzT40iC4-nMWaf7Q6Fw7tlcIXXRw6MwKE1zXkYY=@emersion.fr>
In-Reply-To: <20210217182735.2897-1-hubert@hirtz.pm> (view parent)
DKIM signature: pass

Download raw message

10 days ago

Pushed, thanks!

~emersion/soju-dev

[PATCH] if true return true else return false