~emersion/soju-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] Don't directly reply to network-specific NICK

Details
Message ID
<20210430084435.6922-1-hubert@hirtz.pm>
DKIM signature
pass
Download raw message
Patch: +1 -1
The NICK must only apply to the specific network, not to the downstream
connection.

---

Maybe there should be some sort of reporting from BouncerServ when
upstream replies back with a NICK, such as "Your nickname on network foo
has changed to bar"?

 downstream.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/downstream.go b/downstream.go
index 1a38c16..3eed62f 100644
--- a/downstream.go
+++ b/downstream.go
@@ -1209,7 +1209,7 @@ func (dc *downstreamConn) handleMessageRegistered(msg *irc.Message) error {
			})
		})

		if dc.upstream() == nil && dc.nick != nick {
		if dc.upstream() == nil && upstream == nil && dc.nick != nick {
			dc.SendMessage(&irc.Message{
				Prefix:  dc.prefix(),
				Command: "NICK",
-- 
2.31.1
Details
Message ID
<qTtVdMC21g0pEhR5i1OTD4wIXUQre7Ri4V6MdDp-DDwv_b85aUo9-hc6WtSPtkx0qprfw-VRhMZLKTGG5xMYCqS09UkYNlWlEf6SQ_9uvAk=@emersion.fr>
In-Reply-To
<20210430084435.6922-1-hubert@hirtz.pm> (view parent)
DKIM signature
pass
Download raw message
> The NICK must only apply to the specific network, not to the downstream
> connection.

Ah, right. When downstream sends `NICK newnick/network` we don't want to reply
back with that.

Thanks for the fix, pushed!

> Maybe there should be some sort of reporting from BouncerServ when
> upstream replies back with a NICK, such as "Your nickname on network foo
> has changed to bar"?

Maybe. But only in multi-upstream mode, because we have a better way to bubble
up NICK changes in single-upstream mode.
Reply to thread Export thread (mbox)