~emersion/soju-dev

1

Crash in container

Details
Message ID
<CR6PX9SU5FSO.3UR92LHKXOXML@hades.moritz.sh>
DKIM signature
missing
Download raw message
Hi, I'm running soju in this[0] container (likely unrelated, but better
to be complete) and I've encountered the following panic:

soju-soju-1  | 2023/03/14 22:59:55 downstream "10.10.10.1:60718": new connection
soju-soju-1  | 2023/03/14 22:59:55 downstream "10.10.10.1:60718": received: CAP LS 302
soju-soju-1  | 2023/03/14 22:59:55 downstream "10.10.10.1:60718": received: NICK moritz
soju-soju-1  | 2023/03/14 22:59:55 downstream "10.10.10.1:60718": received: USER mpldr@pc 0 * :Moritz Poldrack
soju-soju-1  | 2023/03/14 22:59:55 downstream "10.10.10.1:60718": sent: :irc.moritz.sh CAP * LS :batch soju.im/bouncer-networks away-notify soju.im/webpush invite-notify setname draft/read-marker soju.im/bouncer-networks-notify sasl=PLAIN extended-monitor message-tags draft/extended-monitor chghost server-time soju.im/read soju.im/no-implicit-names echo-message draft/chathistory account-notify account-tag multi-prefix cap-notify soju.im/account-required soju.im/search extended-join
soju-soju-1  | 2023/03/14 22:59:55 downstream "10.10.10.1:60718": received: CAP REQ :soju.im/bouncer-networks away-notify invite-notify sasl chghost server-time soju.im/read account-notify multi-prefix cap-notify extended-join
soju-soju-1  | 2023/03/14 22:59:55 downstream "10.10.10.1:60718": sent: :irc.moritz.sh CAP * ACK :soju.im/bouncer-networks away-notify invite-notify sasl chghost server-time soju.im/read account-notify multi-prefix cap-notify extended-join
soju-soju-1  | 2023/03/14 22:59:55 downstream "10.10.10.1:60718": received: AUTHENTICATE PLAIN
soju-soju-1  | 2023/03/14 22:59:55 downstream "10.10.10.1:60718": sent: :irc.moritz.sh AUTHENTICATE +
soju-soju-1  | 2023/03/14 22:59:55 downstream "10.10.10.1:60718": received: AUTHENTICATE bXBsZHIAbXBsZHIAVzVXdWI3UVFEM0ZjMGZGbTZnRkhnb2dIQmpTcGlL
soju-soju-1  | 2023/03/14 22:59:55 panic serving downstream "10.10.10.1:60718": runtime error: invalid memory address or nil pointer dereference
soju-soju-1  | goroutine 264 [running]:
soju-soju-1  | runtime/debug.Stack()
soju-soju-1  | 	runtime/debug/stack.go:24 +0x65
soju-soju-1  | git.sr.ht/~emersion/soju.(*Server).Handle.func1()
soju-soju-1  | 	git.sr.ht/~emersion/soju/server.go:447 +0x85
soju-soju-1  | panic({0x9eecc0, 0xeddfc0})
soju-soju-1  | 	runtime/panic.go:884 +0x213
soju-soju-1  | git.sr.ht/~emersion/soju.(*downstreamConn).setUser(0xc00044b2c0, {0xc0000ae050, 0x5}, {0x0, 0x0}, {0x0, 0x0})
soju-soju-1  | 	git.sr.ht/~emersion/soju/downstream.go:1252 +0x9d
soju-soju-1  | git.sr.ht/~emersion/soju.(*downstreamConn).handleMessageUnregistered(0xc00044b2c0, {0xb7a658, 0xc0000f6210}, 0xc000024340)
soju-soju-1  | 	git.sr.ht/~emersion/soju/downstream.go:699 +0xb54
soju-soju-1  | git.sr.ht/~emersion/soju.(*downstreamConn).handleMessage(0xc00044b2c0, {0xb7a658?, 0xc000510060?}, 0xc000024340)
soju-soju-1  | 	git.sr.ht/~emersion/soju/downstream.go:625 +0x128
soju-soju-1  | git.sr.ht/~emersion/soju.(*downstreamConn).runUntilRegistered(0xc00044b2c0)
soju-soju-1  | 	git.sr.ht/~emersion/soju/downstream.go:1701 +0x11e
soju-soju-1  | git.sr.ht/~emersion/soju.(*Server).Handle(0xc0002d2000, {0xb7d240, 0xc0004261f8})
soju-soju-1  | 	git.sr.ht/~emersion/soju/server.go:463 +0x1ef
soju-soju-1  | created by git.sr.ht/~emersion/soju.(*Server).Serve
soju-soju-1  | 	git.sr.ht/~emersion/soju/server.go:590 +0x29f

Let me know if you need anything more :)

-- 
Moritz Poldrack
https://moritz.sh
Details
Message ID
<1HV7ejLgy2DwPo4-e1A5E7o8KRYyqmUayxr66_RQO8Bshm5VFJFi8UVy1Ig06wYmau877-KO96u00vLol2QjYdRQSNZzgkD4SBdx3jVizWU=@emersion.fr>
In-Reply-To
<CR6PX9SU5FSO.3UR92LHKXOXML@hades.moritz.sh> (view parent)
DKIM signature
missing
Download raw message
Ah, thanks for the report! Should be fixed by 4ca8dfa37d27 ("downstream: fix
nil pointer deref in downstreamConn.setUser").
Reply to thread Export thread (mbox)