~emersion/soju-dev

Downstream labeled-response support v1 REJECTED

Hubert Hirtz: 1
 Downstream labeled-response support

 1 files changed, 9 insertions(+), 8 deletions(-)
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~emersion/soju-dev/patches/25540/mbox | git am -3
Learn more about email & git
View this thread in the archives

[PATCH] Downstream labeled-response support Export this patch

---

Since it'd be hard to send labels for all downstream message, we don't.
It's fine if the spec allows it?

> For any message received from a client that includes this tag, the
> server MUST include the same tag and value in any response required
> from this message where it is feasible to do so.
- https://ircv3.net/specs/extensions/labeled-response

It's not feasible right now because it's not been implemented...
 downstream.go | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/downstream.go b/downstream.go
index d03a244..bc4b161 100644
--- a/downstream.go
+++ b/downstream.go
@@ -115,14 +115,15 @@ const illegalNickChars = " :@!*?$"
// permanentDownstreamCaps is the list of always-supported downstream
// capabilities.
var permanentDownstreamCaps = map[string]string{
	"batch":         "",
	"cap-notify":    "",
	"echo-message":  "",
	"invite-notify": "",
	"message-tags":  "",
	"sasl":          "PLAIN",
	"server-time":   "",
	"setname":       "",
	"batch":            "",
	"cap-notify":       "",
	"echo-message":     "",
	"invite-notify":    "",
	"labeled-response": "",
	"message-tags":     "",
	"sasl":             "PLAIN",
	"server-time":      "",
	"setname":          "",

	"soju.im/bouncer-networks":        "",
	"soju.im/bouncer-networks-notify": "",
-- 
2.33.0