~emersion/soju-dev

downstream: fix interface type panic for xirc.MembershipSet v1 SUPERSEDED

Jeff Martin: 1
 downstream: fix interface type panic for xirc.MembershipSet

 1 files changed, 2 insertions(+), 2 deletions(-)
Should be fixed by this commit:
https://git.sr.ht/~emersion/soju/commit/657e25b25c47511ac8a1bb042d0bc9481a813e3b
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~emersion/soju-dev/patches/32777/mbox | git am -3
Learn more about email & git

[PATCH] downstream: fix interface type panic for xirc.MembershipSet Export this patch

---
noticed this when deploying HEAD today
 downstream.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/downstream.go b/downstream.go
index 26032eb..4992546 100644
--- a/downstream.go
+++ b/downstream.go
@@ -3331,8 +3331,8 @@ func sendNames(dc *downstreamConn, ch *upstreamChannel) {
	var members []string
	for _, entry := range ch.Members.innerMap {
		nick := entry.originalKey
		memberships := entry.value.(*xirc.MembershipSet)
		s := formatMemberPrefix(*memberships, dc) + dc.marshalEntity(ch.conn.network, nick)
		memberships := entry.value.(xirc.MembershipSet)
		s := formatMemberPrefix(memberships, dc) + dc.marshalEntity(ch.conn.network, nick)
		members = append(members, s)
	}

--
2.25.1
after sending this, i noticed that the issue is actually that sometimes
entry is a pointer, other times a value. sorry for the spam.

On 22/06/05 01:18PM, Jeff Martin wrote: