Match http-origin against src.Hostname instead of self v1 REJECTED

sentriz: 1
 Match http-origin against src.Hostname instead of self

 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH] Match http-origin against src.Hostname instead of self Export this patch

it looks like for http-origin validation, path.Match() was matching a
pattern against itself. it looks to me like the validation should check
against srv.Hostname instead

Simon Ser <contact@emersion.fr>

5 months ago

Hm, the goal here is to validate that the pattern is well-formed.
There is no requirement that the http-origin directive matches the
hostname.

---
 config/config.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/config.go b/config/config.go
index 1d9122f..c50c5fb 100644
--- a/config/config.go
+++ b/config/config.go
@@ -220,7 +220,7 @@ func Load(filename string) (*Server, error) {
 		srv.FileUpload = &FileUpload{driver, source}
 	}
 	for _, origin := range raw.HTTPOrigin {
-		if _, err := path.Match(origin, origin); err != nil {
+		if _, err := path.Match(origin, srv.Hostname); err != nil {
 			return nil, fmt.Errorf("directive http-origin: %v", err)
 		}
 	}
-- 
2.44.0