Hi,

amtoaster <toastergithubmail@gmail.com> writes:

> Hello. I tried to install sweep today (yesterday), and ran into a few
> problems.

Thank you for this detailed report.  ISTM that the issue is with your
SWI-Prolog installation, see below.

> First, I installed SWI Prolog from my distributions (arch linux) package
> manager, here is the version:
>      -> % swipl --version
>      SWI-Prolog version 9.0.4 for x86_64-linux

Philip Kaludercic <philipk@posteo.net> writes:

> ---
>  sweeprolog.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sweeprolog.el b/sweeprolog.el
> index 7c5167d..2634722 100644
> --- a/sweeprolog.el
> +++ b/sweeprolog.el
> @@ -3325,6 +3325,7 @@ GOAL.  Otherwise, GOAL is set to a default value specified by
>                comment-start "%")
>    (add-hook 'post-self-insert-hook #'sweeprolog-top-level--post-self-insert-function nil t)
>    (add-hook 'completion-at-point-functions #'sweeprolog-completion-at-point nil t)

Philip Kaludercic <philipk@posteo.net> writes:

> OK, nevermind everything I have said up until now.  The issue turns out
> to have been my own.  In my ~/.config/swi-prolog/init.pl I had
>
> use_module(library(clpfd)).
>
>
> instead of 
>
> :- use_module(library(clpfd)).
>
> and apparently that messed everything up.

Philip Kaludercic <philipk@posteo.net> writes:

> Eshel Yaron <me@eshelyaron.com> writes:
>
>> I still tend to think it's a problem with the SWI-Prolog installation,
>> could you try to load the Prolog modules that Sweep can't seem to find
>> in a regular SWI-Prolog top-level (from a shell outside of Emacs)?  If
>> something like `use_module(library(prolog_source))` works in the regular
>> top-level that would point to a problem with Sweep, otherwise it'd mean
>> we can probably rule out Sweep as the root cause.
>
> Looks like it doesn't work:
>
> ?- use_module(library(prolog_source)).

Hi,

Philip Kaludercic <philipk@posteo.net> writes:

> (Sorry for the late response, I had apparently falsely assumed that I've
> already responded to this message)
>
> Eshel Yaron <me@eshelyaron.com> writes:
>

[...27 lines elided...]

>> This sounds like a problem with the SWI-Prolog setup on the university
>> system, the following shell command should give us some more details:

Hello Philip,

Philip Kaludercic <philip.kaludercic@fau.de> writes:

> Hi, it seems this issue hasn't been mentioned anywhere on the mailing
> list, so I think it is worth bringing up.

Of course, thanks for reporting :)

> Whenever the point is on a symbol, and an eldoc hint should pop up, I
> get this error message instead:
>
> eldoc error: (prolog-exception compound error (compound
> existence_error (atom . procedure) (compound : (atom . sweep)

Philip Kaludercic <philipk@posteo.net> writes:

> When a keymap is autoloaded (and the definition is copied over to the
> -autoloads.el file), and the function are sharp-quoted, Emacs can
> complain about undefined symbols, especially in combination with
> 'package-quickstart'.
> ---
>  sweeprolog.el | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/sweeprolog.el b/sweeprolog.el
> index 5a5fe7a..567665d 100644
> --- a/sweeprolog.el
> +++ b/sweeprolog.el

>> Admittedly, this adds a layer of complication to the code, and I'm not
>> sure the current approach (namely the sweeprolog-defface macro) is the
>> most elegant...
>
> Maybe a more elegant approach (or at least, one that fits better with
> the rest of Emacs facilities) is to make the dark and the light options
> custom-themes?  A "custom theme" is nothing more than a set of
> variable&face settings, and users can enable any number of themes they
> want, so it wouldn't prevent them from using some other theme at the
> same time?

That makes a lot of sense, thanks!  I'll look into extracting the
non-default variants and refactoring them as custom themes.

Hi Stefan,

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Hi,
>
> The patch below simplifies face definitions by consolidating common
> elements from dark&light into the default.

Thank you, I really appreciate you taking an interest in Sweep.

The changes you suggest to the face definitions actually alter the
various faces that we end up with, though.  Basically, we have three
sets of faces: default, light and dark.  The default faces are what most

Protesilaos Stavrou <info@protesilaos.com> writes:

>> From: Eshel Yaron <me@eshelyaron.com>
>> Date: Tue, 20 Jun 2023 15:33:30 +0300
>>
>> * README.org (Preview theme colors): Fix typo.
>> (Sample configuration, Option for headings):
>> * ef-themes.el (ef-themes-headings): Prefer saying '(foo bar baz)'
>> over '(foo . (bar baz))' where appropriate; say "non-nil non-list
>> value" to describe such values.
>> ---
>>  README.org   | 54 ++++++++++++++++++++++++++--------------------------
>>  ef-themes.el | 33 ++++++++++++++++----------------
>>  2 files changed, 44 insertions(+), 43 deletions(-)