[PATCH] Do not autoload keymaps

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch

[PATCH] Do not autoload keymaps

Philip Kaludercic <philipk@posteo.net>

Details

Message ID: <87il9vrjy8.fsf@posteo.net>
DKIM signature: missing

Download raw message

1 year, 5 months ago

Patch: +0 -2

When a keymap is autoloaded (and the definition is copied over to the
-autoloads.el file), and the function are sharp-quoted, Emacs can
complain about undefined symbols, especially in combination with
'package-quickstart'.
---
 sweeprolog.el | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sweeprolog.el b/sweeprolog.el
index 5a5fe7a..567665d 100644
--- a/sweeprolog.el
+++ b/sweeprolog.el
@@ -541,7 +541,6 @@ for top-level buffers that don't belong to any project."
     map)
   "Local keymap for `sweeprolog-top-level-menu-mode' buffers.")
 
-;;;###autoload
 (defvar sweeprolog-help-prefix-map
   (let ((map (make-sparse-keymap)))
     (define-key map "m" #'sweeprolog-describe-module)
@@ -549,7 +548,6 @@ for top-level buffers that don't belong to any project."
     map)
   "Keymap for `sweeprolog' help commands.")
 
-;;;###autoload
 (defvar sweeprolog-prefix-map
   (let ((map (make-sparse-keymap)))
     (define-key map "B" #'sweeprolog-list-breakpoints)
-- 
2.39.2

Eshel Yaron <me@eshelyaron.com>

Details

Message ID: <m1il9uad2v.fsf@eshelyaron.com>
In-Reply-To: <87il9vrjy8.fsf@posteo.net> (view parent)
DKIM signature: missing

Download raw message

1 year, 5 months ago

Philip Kaludercic <philipk@posteo.net> writes:

> When a keymap is autoloaded (and the definition is copied over to the
> -autoloads.el file), and the function are sharp-quoted, Emacs can
> complain about undefined symbols, especially in combination with
> 'package-quickstart'.
> ---
>  sweeprolog.el | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/sweeprolog.el b/sweeprolog.el
> index 5a5fe7a..567665d 100644
> --- a/sweeprolog.el
> +++ b/sweeprolog.el
> @@ -541,7 +541,6 @@ for top-level buffers that don't belong to any project."
>      map)
>    "Local keymap for `sweeprolog-top-level-menu-mode' buffers.")
>  
> -;;;###autoload
>  (defvar sweeprolog-help-prefix-map
>    (let ((map (make-sparse-keymap)))
>      (define-key map "m" #'sweeprolog-describe-module)
> @@ -549,7 +548,6 @@ for top-level buffers that don't belong to any project."
>      map)
>    "Keymap for `sweeprolog' help commands.")
>  
> -;;;###autoload
>  (defvar sweeprolog-prefix-map
>    (let ((map (make-sparse-keymap)))
>      (define-key map "B" #'sweeprolog-list-breakpoints)

Applied as commit cc45fa4bf5717cf2edc2e75613e06a647533c2de, thank you!

~eshel/dev

[PATCH] Do not autoload keymaps